commit 58155a2de4869ed3a350f52d1519ad3604693d5c Author: Dan Wells Date: Sun May 27 10:20:16 2018 -0400 Bump version number for upgrade doc Signed-off-by: Dan Wells 16 32 docs/installation/server_upgrade.adoc commit aab0f40b4a0be02dcae8d8256243ddf09b65727c Author: Dan Wells Date: Mon Feb 24 12:09:57 2014 -0500 Bump OpenILS.pm version Signed-off-by: Dan Wells 1 1 Open-ILS/src/perlmods/lib/OpenILS.pm commit afc7b4b68be51200bbb7e0a1f5a467cd58d8e7c9 Author: Dan Wells Date: Sun May 27 09:53:51 2018 -0400 Translation updates - newpot Signed-off-by: Dan Wells 3 3 build/i18n/po/cat.properties/cat.properties.pot 3 3 build/i18n/po/common.properties/common.properties.pot 4 4 build/i18n/po/conify/conify.pot 2653 2647 build/i18n/po/db.seed/db.seed.pot 25 24 build/i18n/po/lang.dtd/lang.dtd.pot 68 68 build/i18n/po/tpac/tpac.pot 2 2 build/i18n/po/vandelay/vandelay.pot 442 353 build/i18n/po/webstaff/webstaff.pot commit 3e29888a078690ecc1e58c6daa4ce3c4d9c270c6 Author: Kathy Lussier Date: Fri May 25 17:12:59 2018 -0400 Docs: Release notes entry for lp1732975 Signed-off-by: Kathy Lussier Conflicts: docs/RELEASE_NOTES_3_1.adoc 1 0 docs/RELEASE_NOTES_3_0.adoc commit bc6b25bdc9a8d4e9bbf9e9057182a8687e3d4caf Author: Kyle Huckins Date: Wed May 2 17:47:04 2018 +0000 lp1732975 Parts Column Not Populated - Retrieve Parts information in egItem Signed-off-by: Kyle Huckins Changes to be committed: modified: Open-ILS/src/templates/staff/cat/item/t_list.tt2 modified: Open-ILS/web/js/ui/default/staff/circ/services/item.js Signed-off-by: Jeanette Lundgren Signed-off-by: Kathy Lussier 1 1 Open-ILS/src/templates/staff/cat/item/t_list.tt2 12 0 Open-ILS/web/js/ui/default/staff/circ/services/item.js commit ce0d0d8567689a11bae4643f14801a14066e3bb5 Author: Kathy Lussier Date: Fri May 25 16:49:26 2018 -0400 Docs: Add release note for bug 1707063 Signed-off-by: Kathy Lussier 2 0 docs/RELEASE_NOTES_3_0.adoc commit e38cc7773fd88b9025c08675c3684af971a57c8e Author: Mike Rylander Date: Mon Jan 29 16:37:15 2018 -0500 LP#1707063: Naive ng-class test for last-column-modified Instead of comparing a (potentially undefined) property of a column, we'll just compare the column object directly when checking to see if a column header should be highlighted for "last touched in editing mode." Signed-off-by: Mike Rylander Signed-off-by: Cesar Velez Signed-off-by: Kathy Lussier 1 1 Open-ILS/src/templates/staff/share/t_autogrid.tt2 8 2 Open-ILS/web/js/ui/default/staff/services/grid.js commit eabf775510b3a28d11d202b25c8f80e016ec56ac Author: Jane Sandberg Date: Fri May 25 13:14:12 2018 -0700 Docs: correcting description of a bugfix Signed-off-by: Jane Sandberg 4 1 docs/RELEASE_NOTES_3_0.adoc commit 059d435253d6ce547b901551514c8e3a058f351b Author: Jane Sandberg Date: Fri May 25 12:53:28 2018 -0700 Docs: adding to 3.0.8 release notes Signed-off-by: Jane Sandberg 16 0 docs/RELEASE_NOTES_3_0.adoc commit a3b74e058e4143b29efbb78aeeb79ab948c1d0b4 Author: Jason Boyer Date: Wed Feb 21 13:59:44 2018 -0500 LP1750887: Copy Objects when Saving Copy Templates Copy the callnumbers and statcats objects when saving copy templates to prevent accidental and confusing editing of in-memory copies. cesardv: changed tabs to spaces. Signed-off-by: Jason Boyer Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 0 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js commit 862b921cf10644a4d5a87aaf19880da61478c614 Author: Bill Erickson Date: Tue May 15 16:12:12 2018 -0400 LP#1771422 Reset transiting hold copy status fix Avoid modifying the copy status in the hold-reset API when it's passing the copy off to the transit API for canceling the transit. Let the transit API handle the status instead. This fixes a bug where resetting a transiting hold, and canceling its transit, would leave the targeted copy in "in transit" status instead of "canceled transit". Signed-off-by: Bill Erickson Signed-off-by: Garry Collum Signed-off-by: Galen Charlton 0 2 Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm commit 340d71f1f39566c9d6b836ea23fdc3bad05f3bac Author: Lynn Floyd Date: Mon May 7 10:43:01 2018 -0700 LP#1750630: use proper quoting to un-break Transit List print template Signed-off-by: Jeff Davis Signed-off-by: Garry Collum Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/staff/share/print_templates/t_transit_list.tt2 commit f3f5ec4fcacb9037b27b1bd47b2e572a0d88db18 Author: Bill Erickson Date: Tue May 22 11:18:01 2018 -0400 LP#1528909: Patron search clickable barcodes Patron barcodes in the patron search grid are now click-able, making it possible to quickly open multiple patrons in new tabs from patron search by control-clicking (or middle-clicking) the barcode links. Signed-off-by: Bill Erickson Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton 3 1 Open-ILS/src/templates/staff/circ/patron/t_search_results.tt2 commit 6a8f7e927ec87d6028f2b3d6c6ee16ab40eeec27 Author: Bill Erickson Date: Mon May 21 14:22:32 2018 -0400 LP#1721148: In-house use shows copy status Adds a Copy Status column to the In-House use checkout grid. Signed-off-by: Bill Erickson Signed-off-by: Geoff Sams Signed-off-by: Galen Charlton 1 0 Open-ILS/src/templates/staff/circ/in_house_use/index.tt2 1 1 Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js commit 754a28bb0f6c76f21b6bc827d0d41fde60198d31 Author: Jeanette Lundgren Date: Mon May 14 13:26:45 2018 -0400 Lp#1760859: Add Missing Images to Tranist and Hold Slips Added new truck transit.png image for web client holds/transit dialog Added holds.png img tag to t_hold_shelf_dialog.tt2 Added transit.png img tag to t_transit_dialog.tt2 Signed-off-by: Jeanette Lundgren Signed-off-by: Jason Stephenson Signed-off-by: Galen Charlton 1 0 Open-ILS/src/templates/staff/circ/share/t_hold_shelf_dialog.tt2 1 0 Open-ILS/src/templates/staff/circ/share/t_transit_dialog.tt2 - - Open-ILS/web/images/transit.png create mode 100644 Open-ILS/web/images/transit.png commit c8b4f62dd5b9b680ac63d41eb5a60a5a40a2ddd7 Author: Cesar Velez Date: Fri Mar 30 11:32:45 2018 -0400 LP#1759352: improve webstaff fix checkout specific due date UX The Date Options dropdown UI added as a result of bug 1717025 hides the state of the "checkboxes" for custom due date and the datepicker wasn't disabled when custom due date was disabled. This addresses these UX issues, to that the user has visual feedback as to the state of that option. Signed-off-by: Cesar Velez Signed-off-by: Rogan Hamby Signed-off-by: Galen Charlton 3 2 Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2 commit e663cbf61114980cec74d6528d9796b5ba474bab Author: Jason Stephenson Date: Tue Apr 10 10:51:24 2018 -0400 LP#1751126: Make print holds shelf list aware of clear mode. We change the Print Full List button on the holds shelf view to be aware of whether clear mode is active. If clear mode is active, then the list of holds to clear is printed. If not, then the full holds shelf list is printed. This commit does not change the label of the print full list button. Signed-off-by: Jason Stephenson Signed-off-by: Dawn Dale Signed-off-by: Galen Charlton 4 1 Open-ILS/web/js/ui/default/staff/circ/holds/app.js commit 12c6acbded284d055a227b89b29f4dc8ddde637b Author: Jeff Davis Date: Thu Mar 1 16:55:46 2018 -0800 LP#1752753: Guard against invalid timezone If the lib.timezone org setting is not a valid timezone, attempting to use it can result in an internal server error in the OPAC. Let's handle the error with try/catch instead. To test ------- 1. In Library Settings Editor, edit the "Library time zone" setting for Example Branch 1, setting the value to something that's not the name of a time zone (like "invalid" or "UTC-07:00"). 2. In the OPAC, retrieve a record with holdings at Example Branch 1. You will get an Internal Server Error. 3. Edit the library setting to use a valid timezone name, like "America/Vancouver". 4. Retrieve the same record again. This time, the record will display properly. 5. Apply the patch and repeat steps 1 and 2; this time, there should be no internal server error. Signed-off-by: Jeff Davis Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 7 1 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm commit 9374c73dd9c6db7c98bc3371a99e82227141a64c Author: Galen Charlton Date: Fri May 25 14:25:44 2018 -0400 LP#1772417: (follow-up) improve I18N of the bucket title string Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/staff/circ/patron/bucket/t_bucket_info.tt2 commit c4842074e96f683f66abea268b8548fef11c8648 Author: Jane Sandberg Date: Mon May 21 09:28:39 2018 -0700 LP1772417: Adding the bucket ID to the user bucket display To test: 1) Open a patron bucket. Note that the bucket ID is not listed in the bucket information section at the top of this screen. 2) Apply this commit. 3) Open the same patron bucket. Note that the bucket ID is listed in the bucket information section Signed-off-by: Jane Sandberg Signed-off-by: Garry Collum Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/staff/circ/patron/bucket/t_bucket_info.tt2 commit e863820e3715470e6cfe604259b809a49a3ad103 Author: Bill Erickson Date: Tue Oct 17 12:40:11 2017 -0400 LP#1693035 Login timeout honors workstation org Use the org unit linked to the provided workstation to collect the login timeout org unit setting value during login. Previously, all checks defaulted to the global org unit. This patch solidifies the precedence order for OUS lookups during login like so: 1. Workstation org unit. 2. API org unit value. 3. Users' home org unit. Signed-off-by: Bill Erickson Signed-off-by: Michele Morgan Signed-off-by: Galen Charlton 23 13 Open-ILS/src/c-apps/oils_auth_internal.c commit b5eb8762b6ac7bd14f6866051659d0a17c214c68 Author: Cesar Velez Date: Mon Feb 5 17:45:22 2018 -0500 LP#1746815: Fix sticky hold url param Renamed the hold_id url param from "id" to "hid" and prevent it from sticking in url's where it not needed. To test ------- [1] Log in to the public catalog as a patron that has at least two hold requests. [2] Go to the My Account holds tab and edit one of the holds. [3] Rather than submit a change, click on the holds tab again. [4] Note that /only/ the hold you were edit displays, and that the 'id' URL parameter persists as you navigate through the public catalog. [5] Apply the patch and repeat steps 1-3. This time, you should see all of the holds. Signed-off by: Cesar Velez Signed-off-by: Michele Morgan Signed-off-by: Galen Charlton 1 1 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm 1 1 Open-ILS/src/templates/opac/myopac/holds.tt2 2 2 Open-ILS/src/templates/opac/parts/myopac/base.tt2 7 7 Open-ILS/src/templates/opac/parts/topnav.tt2 commit 1061e8db2e52be57e27dd30c1e3a2f07722775d2 Author: Jason Boyer Date: Fri May 18 09:12:37 2018 -0400 LP1772017: Correctly Extract Cast from Records authors.tt2 has been using field 508 for cast display but the correct field is 511 when ind1=1. Testing note: In the Concerto data set, the title "The rum diary" is a good test record, as it has both a 508 field and a 511. Signed-off-by: Jason Boyer Signed-off-by: Garry Collum Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/opac/parts/record/authors.tt2 commit 9b5bbff9b37678cc9af45c49ae94f21f9186f904 Author: Jane Sandberg Date: Fri May 25 08:50:53 2018 -0700 Docs: adding to 3.0.8 release notes Signed-off-by: Jane Sandberg 10 0 docs/RELEASE_NOTES_3_0.adoc commit 1ed3e20ba6884c38a0297ea6646746ebfa44ffb8 Author: Mike Rylander Date: Fri May 4 09:58:53 2018 -0400 LP#1755220: Return value checking in offline session fetch We need to make sure that we receive the correct shape of data (array) rather than that we simply got anything when fetching sessions. In the case of an expired session token, we'll receive an ILS Event object informing us of the expiration where we'd normally see a list of sessions. Signed-off-by: Mike Rylander Signed-off-by: Dawn Dale Signed-off-by: Jason Stephenson 2 1 Open-ILS/web/js/ui/default/staff/offline.js commit 41fd8d996f9e8be253f9928ac7575e261d41d2ff Author: Garry Collum Date: Wed May 23 19:47:56 2018 -0400 LP#1745240: Hold Alias Missing from Hold Shelf Slip A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias. This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency. Signed-off-by: Garry Collum Signed-off-by: John Amundson Signed-off-by: Jason Stephenson 2 1 Open-ILS/src/templates/staff/share/print_templates/t_hold_shelf_slip.tt2 commit 84ad556b25d9bd70d742d55c572d326685c1017f Author: Garry Collum Date: Wed May 23 22:17:38 2018 -0400 LP#1745232 - Bill History Receipt doesn't have Finish Date Adds xact.finish and xact.summary.last_payment to the example data. Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made. Also adds a list of variables that can be used in the template in the template's description. To test - 1. apply the patch 2. find a patron with billings, or add some billings to a patron record. 3. make payments on some of the billings using various methods. 4. go to billing history and print the history list. Signed-off-by: Garry Collum Signed-off-by: John Amundson Signed-off-by: Jason Stephenson 20 4 Open-ILS/src/templates/staff/share/print_templates/t_bills_historical.tt2 4 0 Open-ILS/web/js/ui/default/staff/admin/workstation/app.js commit 047dd1a625dbcc896df8fbe426ff1ea629178fda Author: gcollum Date: Sun May 20 13:18:18 2018 -0400 LP#1743782 Copy Status not available in Check-In Screen Makes the status an available column to display in the Check-In screen. To test: 1. Apply patch. 2. Go to check-in and display 'Status' as a column in the table. 3. Check-in various items that may be checked-out, catch a hold, not checked out, etc. Signed-off-by: gcollum Signed-off-by: Dawn Dale Signed-off-by: Jason Stephenson 3 0 Open-ILS/src/templates/staff/circ/checkin/t_checkin_table.tt2 commit b1540c7bc72163de3c6ff542f15972ba84450bd7 Author: Cesar Velez Date: Thu Apr 19 17:25:59 2018 -0400 LP#1765731 - restore CN suffix and preffix in Holds Pull List Overly gung-ho removal of "redundant" fields/columns in bug 1728147 removed call number prefix and suffix as available columns in the hold pull list grid in the web staff client; this will restore them there. Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 13 1 Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2 commit 0db68e6738f06cfb36dd0f0b33767301099416f7 Author: Jane Sandberg Date: Wed May 23 15:48:02 2018 -0700 Docs: Adding to and reorganizing the 3.0.8 release notes Signed-off-by: Jane Sandberg 60 18 docs/RELEASE_NOTES_3_0.adoc commit e05cf34dd061463b10653c9e929a51e32e2bd7f9 Author: Galen Charlton Date: Thu Apr 19 11:44:42 2018 -0400 LP#1765444: improve how MARC editor fetches fixed field metadata This patch fixes a problem where the web staff MARC editor would make repeated and redundant calls to two Evergreen methods to fetch data about fixed field positions and values if that metadata was not already cached by local storage or Hatch. In particular, this patch caches and returns the data retrieval promises, ensuring that only one set of FF position and value requests are made. Prior to this patch, each eg-marc-edit-fixed-field directive, of which there are 64, could end up invoking those methods when initializing the editor for a record type that had not been previously seen. To test ------- [1] Clear all FFPosTable_* and FFValueTable_* keys from local storage (or Hatch). [2] Retrieve a bib record in the web staff client. Note that up to 64 calls each are made of open-ils.cat.biblio.fixed_field_values.by_rec_type and open-ils.fielder.cmfpm.atomic. [3] Apply the patch and repeat steps #1 and #2. [4] This time, note that only one call each are made. [5] Verify that the fixed field inputs continue to work as expected. Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander Signed-off-by: Cesar Velez Signed-off-by: Mike Rylander 41 35 Open-ILS/web/js/ui/default/staff/cat/services/tagtable.js commit 2545bc37ac0e6ee1cc3bbf4e7632de6400ad29c8 Author: Mike Rylander Date: Tue May 15 17:21:00 2018 -0400 LP#1770478: Offline org unit tree can break A thinko in the org tree reconstruction for offline mode caused the tree to be broken in some situations, when the orgs were not ordered strictly by ID in the list stored in the browser's IndexedDB storage. This commit removes that requirement, and allows trees of any ID and storage ordering to be reconstituted. Signed-off-by: Mike Rylander Signed-off-by: Jeff Davis Signed-off-by: Jason Stephenson 6 4 Open-ILS/web/js/ui/default/staff/services/lovefield.js commit 02d3d6c7c2bb797102feefe0ac4b2c781ea43210 Author: Kyle Huckins Date: Tue May 1 18:28:36 2018 +0000 lp1759327 Populate Copy Templates Floating Dropdown - Add update watcher and call itemSvc.get_floating_groups within egVolTemplate directive to properly populate dropdown when accessing volcopy editor from local administration. Signed-off-by: Kyle Huckins Signed-off-by: Jeanette Lundgren Signed-off-by: Jason Stephenson 7 1 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js commit b45e85bdc2c47f20c8ee0f3613f7d7dd88bdc6fa Author: Jeff Davis Date: Tue Apr 24 14:00:07 2018 -0700 LP#1749996: add option to remove floating in web client copy editor Signed-off-by: Jeff Davis Signed-off-by: Jason Stephenson 3 2 Open-ILS/src/templates/staff/cat/volcopy/t_attr_edit.tt2 commit 012f1904375cd812d1949b3975be24fa7215c2cb Author: Kyle Huckins Date: Wed May 16 17:00:26 2018 +0000 lp1760997 Holds Pull List Blank Fields - Requires field data to be loaded into holds pull list grid initially. Signed-off-by: Kyle Huckins Signed-off-by: Jason Stephenson 14 14 Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2 commit 9d0777cf4f58ed998c52be037d7738a9c53b4ead Author: gcollum Date: Fri May 18 20:10:49 2018 -0400 LP1749994 Disable payment button pending payment amount Apply payment button on patron bills screen should be inactive if Payment Received is blank Adds a test to see if there is a value in Payment Received input box. The Apply Payment button doesn't activate unless a billing or billings is selected and a numerical value is in Payment Received. To test. 1. Add some billings to a patron's account. 2. Click some of the billings to select them. Notice that the Apply Payment button is active. 3. Apply patch 4. Select some of the billings. The Apply Payment button is not active. 5. Enter some values into Payment Received. If values other than numbers are entered the Apply Payment button is not activated. If numbers are added the button is activated. 6. Uncheck all of the billings to see that the activated button deactivates, if no billings are checked. Signed-off-by: gcollum Signed-off-by: Cesar Velez Signed-off-by: Dawn Dale Signed-off-by: Bill Erickson 1 1 Open-ILS/src/templates/staff/circ/patron/t_bills.tt2 commit 8ff8b98bdd4d7f26c649ef63196a0200feeb89e6 Author: Bill Erickson Date: Wed May 16 17:24:05 2018 -0400 LP#1639022 Webstaff convert change to credit Add support for converting change to patron credit in the patron bills interface, consistent with the XUL feature. When the 'circ.disable_patron_credit' org unit setting is applied, the option is hidden. Signed-off-by: Bill Erickson Signed-off-by: Laura Sachjen Signed-off-by: Kathy Lussier 8 0 Open-ILS/src/templates/staff/circ/patron/t_bills.tt2 17 6 Open-ILS/web/js/ui/default/staff/circ/patron/bills.js commit 2819c442346e2128d0a228ca3b8e3e5f91fcc161 Author: Jane Sandberg Date: Tue May 22 17:55:03 2018 -0700 Docs: updating 3.0.8 release notes Signed-off-by: Jane Sandberg 3 0 docs/RELEASE_NOTES_3_0.adoc commit 6fb9fc8659241a65405845b0dff0e7c4355dc56d Author: Galen Charlton Date: Mon Apr 30 17:03:26 2018 -0400 LP#14973322: (follow-up) allow profile-only patron searches This patch removes the implicit requirement introduced by the previous patch that a field other than profile be used in the patron search. For performance reasons, it might be good to mark permission.grp_descendants() as stable. Signed-off-by: Galen Charlton Signed-off-by: Jason Boyer Signed-off-by: Mike Rylander 8 4 Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm commit d5e7320a9c1bde5838a4f244c3370d48df2f9346 Author: Jason Boyer Date: Fri Apr 20 14:49:25 2018 -0400 LP14973322: Search for Users by Profile Stop treating profile like a text value, instead include users in the selected profiles and descendants. To test ------- [0] Search for users by last name (and / or first) and do not select a profile, take note of results [1] Select the top of your permission group tree (Users, likely) and search again, results should be the same. [2] Select a group further down the tree (Circulators, Administrators, Patrons, etc.) and repeat the search, there should only be results from that group and its descendants. [3] Finally, select a group with no child groups. Results will only be that specific group. Signed-off-by: Jason Boyer Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 7 0 Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm 1 1 Open-ILS/web/js/ui/default/staff/services/patron_search.js commit ead1711400e1b161c53515e620e50ef3bf1d3404 Author: Galen Charlton Date: Mon Apr 30 16:14:52 2018 -0400 LP#1497322: add Perl live_t regression and unit tests for patron searching Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 62 0 Open-ILS/src/perlmods/live_t/27-lp1497322-patron-search-by-profile.t create mode 100644 Open-ILS/src/perlmods/live_t/27-lp1497322-patron-search-by-profile.t commit 3126271e138d694ffbd6b46983e0da9c7f47f09a Author: Lynn Floyd Date: Mon Apr 30 18:45:41 2018 -0400 Docs: Update "Receipt Template Editor" for Web Client Completely rewritten chapter. Many thanks to Terran McCanna, as much was borrowed from her wiki pages. Signed-off-by: Lynn Floyd Signed-off-by: Remington Steed 257 0 docs/admin/receipt_template_editor.adoc 0 628 docs/admin/workstation_admin_receipt_template_editor.adoc - - docs/media/receipt1.png - - docs/media/receipt2.png 1 1 docs/root.adoc 1 1 docs/root_staff_client_admin.adoc create mode 100644 docs/admin/receipt_template_editor.adoc delete mode 100644 docs/admin/workstation_admin_receipt_template_editor.adoc create mode 100644 docs/media/receipt1.png create mode 100644 docs/media/receipt2.png commit 05ea2da8d9a58ad34a884e388274a1972ae580ed Author: Remington Steed Date: Thu May 17 10:24:37 2018 -0400 Docs: Fix two minor typos Signed-off-by: Remington Steed 1 1 docs/admin/MARC_RAD_MVF_CRA.adoc 1 1 docs/admin/librarysettings.adoc commit 390ed2d64a98b05fd7082a061570bf379f0a7865 Author: Remington Steed Date: Tue May 15 09:59:13 2018 -0400 Docs: Update Long-overdue docs for web client This commit completes LP #1325704 by documenting the setting which controls which tabs the long-overdue circ can appear on. Signed-off-by: Remington Steed 9 4 docs/circulation/circulating_items_web_client.adoc commit 2196e6e9dfaa3ab4efb4f317ab566a0e45092d0a Author: Jane Sandberg Date: Thu May 17 04:35:55 2018 -0700 Docs: adding to 3.0.8 release notes Signed-off-by: Jane Sandberg 4 1 docs/RELEASE_NOTES_3_0.adoc commit 7a55a11618b1e3ecfae21d6348135f13a59744e1 Author: Kathy Lussier Date: Tue May 15 17:21:53 2018 -0400 LP#1756912: Stamping upgrade script for add preferred lib to unapi feeds Signed-off-by: Kathy Lussier Conflicts: Open-ILS/src/sql/Pg/002.schema.config.sql 1 1 Open-ILS/src/sql/Pg/002.schema.config.sql 128 0 Open-ILS/src/sql/Pg/upgrade/1110.schema.add_pref_lib_to_unapi_feeds.sql 0 128 Open-ILS/src/sql/Pg/upgrade/XXXX.schema.add_pref_lib_to_unapi_feeds.sql create mode 100644 Open-ILS/src/sql/Pg/upgrade/1110.schema.add_pref_lib_to_unapi_feeds.sql delete mode 100644 Open-ILS/src/sql/Pg/upgrade/XXXX.schema.add_pref_lib_to_unapi_feeds.sql commit b1c3e85d4ed000d168abf8663f2d27d5ca4d1ea3 Author: Galen Charlton Date: Wed Mar 21 12:03:27 2018 -0400 LP#1756912: restore display of copy counts for preferred library This patch fixes a regression introduced by the patches for bug 1698206 and restores the display of copy counts for the preferred library (when set) on the public catalog results and record details pages. To test ------- [1] Log into the public catalog as a user and set a preferred library. [2] Perform a catalog search at a system that is other than the preferred library set in step 1. Repeat the search with "Groups Formats and Editions" checked. [3] Note that in both cases, the copy counts displayed in search results and the record details pages do not include a line for the preferred library. [4] Apply the patch and repeat step 2. This time, the preferred library count should be included in the display. The substance of this patch (with the exception of the pgTAP tests) follows an approach suggested by Bob Wicksall Signed-off-by: Galen Charlton Signed-off-by: Cesar Velez Signed-off-by: Kathy Lussier Conflicts: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm 3 2 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm 6 6 Open-ILS/src/sql/Pg/990.schema.unapi.sql 46 0 Open-ILS/src/sql/Pg/t/lp1756912_unapi_feed_copy_counts_include_preflib.pg 128 0 Open-ILS/src/sql/Pg/upgrade/XXXX.schema.add_pref_lib_to_unapi_feeds.sql create mode 100644 Open-ILS/src/sql/Pg/t/lp1756912_unapi_feed_copy_counts_include_preflib.pg create mode 100644 Open-ILS/src/sql/Pg/upgrade/XXXX.schema.add_pref_lib_to_unapi_feeds.sql commit f14c6b9d89616fce058f172a562adf02f76397e7 Author: Kathy Lussier Date: Tue May 15 15:47:56 2018 -0400 LP#1738893: Release notes entry for batch edit stat cat fix Adding release notes entry since the initial maintenance release notes have already been done. Signed-off-by: Kathy Lussier Conflicts: docs/RELEASE_NOTES_3_1.adoc 3 0 docs/RELEASE_NOTES_3_0.adoc commit bdffb043789132527eef5bc2f57ab727a9b985d4 Author: Cesar Velez Date: Mon Apr 30 15:12:53 2018 -0400 LP#1738893-allow saving required statcats in multi record vol-copy edit This change allows the user to set a required stat cat for multiple record copies in the Volcopy editor. Signed-off-by: Cesar Velez Signed-off-by: Kathy Lussier 1 1 Open-ILS/src/templates/staff/cat/volcopy/t_attr_edit.tt2 commit 890cc968a1fbc04f9663d1de3d92b5e27eb1a05f Author: Katie G. Martin Date: Wed May 2 10:21:10 2018 -0500 Docs: Updated Long Overdue items section for web client Updated section as per launchpad bug #1325704. - Updated screenshots. - Changed name of "Lost, Claimed Returned, Long Overdue, Has Unpaid Billings" to "Other/Special Circulations". - Added tip pointing to the docs chapter on the library settings editor. - Changed a setting code to its equivalent display name. Signed-off-by: Katie G. Martin Signed-off-by: Remington Steed 17 7 docs/circulation/circulating_items_web_client.adoc - - docs/media/long_overdue1.png - - docs/media/long_overdue2.png create mode 100644 docs/media/long_overdue1.png create mode 100644 docs/media/long_overdue2.png commit ce13b43bb01eb43be8ae9bb4f823de24ff4a5756 Author: Jane Sandberg Date: Sun May 13 17:14:18 2018 -0700 Docs: adding docs contributor to release notes Signed-off-by: Jane Sandberg 1 0 docs/RELEASE_NOTES_3_0.adoc commit 6ff617f8fd894e3c304a6503b126572e1a373ded Author: Jane Sandberg Date: Sun May 13 17:01:10 2018 -0700 Docs: starting 3.0.8 release notes Signed-off-by: Jane Sandberg 78 1 docs/RELEASE_NOTES_3_0.adoc commit 6f00dd1e16311b8dfd22fb523ea45bb246a60714 Author: Katie G. Martin Date: Mon Apr 30 15:36:56 2018 -0500 Docs: Update Patron Search to add DOB Patron Search now includes DOB y/m/d -- this adds those fields to the list of searches and adds tips for search syntax for DOB. Updated advanced search screenshot to include the DOB search fields. Corrected and simplified sentence about the "include inactive" checkbox. Signed-off-by: Katie G. Martin Signed-off-by: Remington Steed 8 1 docs/circulation/circulation_patron_records_web_client.adoc - - docs/media/circulation_patron_records-1b_web_client.png commit e6eccddbbc1d6c1071b6c157126653731c4f5301 Author: Remington Steed Date: Thu May 10 11:00:16 2018 -0400 Docs: Fix inaccuracies in Holdings Import Profiles sections In dev/_importing_materials_in_the_staff_client.html: - Fix "For more details" link - Remove remaining references to "Keep" (some were removed previously in commit 7570423802) - Remove "static values" references from both pages (not supported) - Add link to related Library Settings In dev/_import_item_attributes_2.html: - Remove sentence fragment left behind when previous "Keep" reference was deleted. - Add table row for "Parts Data" Signed-off-by: Remington Steed 4 6 docs/admin_initial_setup/importing_via_staff_client.adoc 4 4 docs/cataloging/batch_importing_MARC.adoc commit 353ffdfd6ca5fea72715bc75f443caad9e20f153 Author: Bill Erickson Date: Mon Apr 30 14:27:41 2018 -0400 LP#1740537 Transit dialog showing wrong branch Always retrieve the latest copy transit from the server when displaying the copy transit dialog. This resolves an issue where a just-closed transit is used instead. Add a filter to avoid canceled transits. Make the transit lookup call authoritative, since the transit may have just been created. To test (test plan courtesy of John Amundson): 1. Sign in as Library A. 2. Check in an item owned by Library B that does not have any holds associated with it. This will send the item in transit to its home, Library B. 3. Place a hold on the item to be picked up at Library C. 4. Sign in as Library B. 5. Check in the item. The transit pop-up and printout will show that the item needs to be transited to Library B instead of Library C. 6. Apply the patch and repeat steps 1-5 using a different item. This time, the transit pop-up will show that the item needs to be transited to Library C. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 5 4 Open-ILS/web/js/ui/default/staff/circ/services/circ.js commit 06fe3824d7f71913a7bfd99156bd3a176f2c324c Author: Jane Sandberg Date: Mon Apr 30 15:49:59 2018 -0500 LP1766712: Add Scrollbar to Patron Search Permission Group Field To test: * Open the patron search screen * Click the Profile Group dropdown * Confirm that there is a scrollbar Signed-off-by: Jane Sandberg Signed-off-by: Jeanette Lundgren Signed-off-by: Jason Stephenson 1 1 Open-ILS/src/templates/staff/share/t_patron_search_form.tt2 commit 5ca6ede3099b6c2d11a16d9d5e6051c3eada0799 Author: Galen Charlton Date: Thu Apr 19 15:11:41 2018 -0400 LP#1765501: ensure that webstaff MARC editor can deal with short 008s This patch ensures that the 008 field, when maintained by the web staff MARC editor, is kept at its proper length. In particular, this solves a problem where input can get messed up if the user selects the entire contents of the 008 field and replaces it with a shorter string. To test ------ [1] Create a new bib record. Ensure that the MARC record editor is /not/ in flat text mode. [2] Edit the 008 field by selecting its entire contents and replacing it with a subset. For example, this might be done when the first action that a cataloger takes is to set the 008/00-05. [3] Enter value in the individual fixed-field inputs at the top of the MARC editor form. For example, enter 'eng' in the Lang field. [4] Note that the results are wrong; e.g., the text ends up as "080419en en eng". [5] Apply the patch and repeat steps #1-#4. This time, the results should be correct. Signed-off-by: Galen Charlton Signed-off-by: Cesar Velez Signed-off-by: Mike Rylander 17 0 Open-ILS/web/js/ui/default/staff/marcrecord.js commit 7f6d82980d0d8147f926f6da5a5bfe21223e921c Author: Chris Sharp Date: Mon May 7 08:31:56 2018 -0400 LP#1743854 - Correct initial cursor focus in in-house use UI Previously, the "Record In-House Use" UI opened with the cursor focused in the "# of Uses" field, which required staff to manually select the "Barcode" field. It is far more intuitive to have the "Barcode" field have initial focus. Signed-off-by: Chris Sharp Signed-off-by: Geoff Sams 1 1 Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js commit 77da2221756ceb28b17c83a7c0b206b40f117e2c Author: Ben Shum Date: Thu May 3 10:02:50 2018 -0500 LP#1758426: Disable triggers before recalculating bib visibility in 1085 Followup to also disable triggers as part of the numbered upgrade script. Signed-off-by: Ben Shum 23 0 Open-ILS/src/sql/Pg/upgrade/1085.function.luri_vis_cache.sql commit 863b1c1ab0b4b2e4b50ba8f1dba1d54d080cc1df Author: Kathy Lussier Date: Fri Mar 23 16:35:16 2018 -0400 LP#1758426: Disable triggers before recalculating bib visibility Disabling triggers in the 3.0.2-3.0.3 upgrade script to speed up the recalculation of bib visibility. These are the same triggers that were disabled when performing a similar recalculation in the 2.12.6-3.0.0 upgrade script. Signed-off-by: Kathy Lussier Signed-off-by: Ben Shum 23 0 Open-ILS/src/sql/Pg/version-upgrade/3.0.2-3.0.3-upgrade-db.sql commit 38a9bde3a2c386f9e004b713860b98464dbef27b Author: Rogan Hamby Date: Fri Dec 22 09:37:06 2017 -0500 LP#1739029: adding profile and password env var for novelist Signed-off-by: Rogan Hamby Signed-off-by: Ben Shum 2 1 Open-ILS/examples/apache/eg_vhost.conf.in 2 1 Open-ILS/examples/apache_24/eg_vhost.conf.in commit e2da2c7c6b539e2c4f4b17b73e99ee4639dcdae9 Author: Jane Sandberg Date: Mon Mar 19 15:30:03 2018 -0700 LP1724026: fixing alignment issues in patron registration/edit screen Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 0 16 Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 commit 6ad74f16ff4f2133b322f07bcba440f501174784 Author: Galen Charlton Date: Tue May 1 14:29:50 2018 -0400 LP#1576727: (follow-up) add unit test Signed-off-by: Galen Charlton 22 0 Open-ILS/src/perlmods/live_t/28-marc_cn.t create mode 100644 Open-ILS/src/perlmods/live_t/28-marc_cn.t commit 5920f3f1f7a6cc219df409827ac95977945e9a07 Author: Mike Rylander Date: Fri Apr 29 15:30:17 2016 -0400 LP#1576727: Delimit bib CN subfields with a space When suggested call numbers are pulled from a bib record, space delimiters are dropped. This is bad for noralization routines. Now we will forcibly inject a space between subfield values. Also included are two small optimizations: exit early if no nodes are found for a particular bib CN definition; use map+join instead of a for loop and blind substring trim to stitch together an xpath expression. Signed-off-by: Mike Rylander Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 9 7 Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm commit 3cc70dc3bb996210d326feb7f275ae5ffd7627a9 Author: Galen Charlton Date: Mon Apr 30 22:45:48 2018 -0400 LP#1732591: (follow-up) fix major regressions This patch works around two regressions introduced by a previous patch: - record links from titles on the OPAC results page simply re-ran the search - record links from cover images on the OPAC results page dropped all paramters In one case, a 'record_url' should have been a mkurl() expression. In the other case, the prior patch did not handle the clear_params parameter correctly; an empty array is /not/ equivalent to undef, and all CGI parameters were getting cleared. This patch is offered in lieu of simply pushing a revert. Signed-off-by: Galen Charlton 3 3 Open-ILS/src/templates/opac/parts/result/table.tt2 commit 3b70230b51fd18348d06afd964d08d36481db6ab Author: Katie G. Martin Date: Mon Apr 30 15:04:48 2018 -0500 Docs: Update circulation_patron_records_web_client.adoc Signed-off-by: Katie G. Martin Signed-off-by: Remington Steed 1 0 docs/admin/librarysettings.adoc 31 0 docs/circulation/circulation_patron_records_web_client.adoc commit d673ae1d2cb69cd51f999898dfe9c95591a27ee7 Author: Jane Sandberg Date: Mon Apr 30 15:21:21 2018 -0500 Docs: adding info about bibliographic fingerprints Signed-off-by: Jane Sandberg 15 0 docs/admin/schema_bibliographic.adoc 4 0 docs/root.adoc 2 0 docs/root_command_line_admin.adoc create mode 100644 docs/admin/schema_bibliographic.adoc commit a96107ab2594000cabaa25cce55ffe54973beceb Author: Jane Sandberg Date: Sat Feb 10 08:22:20 2018 -0800 LP1748649: Don't show bib call # in show_details mode Using "show more details" in the public catalog displays a list of items associated with each bib in the results list -- and their call numbers. Consequently, when in that mode, it is not necessary to separately display one of the bib call numbers in the bib summary on the results page; this patch removes it. Signed-off-by: Jane Sandberg Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/opac/parts/result/table.tt2 commit f9c8e6ae4315871abc08179c137b8d199261e43c Author: Bill Erickson Date: Fri Feb 9 14:27:05 2018 -0500 LP#1748006 Patron edit juv flag manual override Allow staff to manually override the patron juvenile flag value regardless of patron DoB. Patch removes the ng-blur handler for dob and expire_date, which fires too aggressively. The dob handler is replaced with a $watch handler, so the new and old value can be compared. No watch is applied to expire_date, since no code is currently fired when it's changed. Change the log level of the "field changed" message from log to debug. To test: [1] Open a patron in the web staff patron editor. [2] Apply a juvenile birth date (less than 18 years by default). [3] Confirm the juvenile flag is automatically activated (if it wasn't already). [4] Confirm it's possible to un-check the juvenile flag and save the patron. Signed-off-by: Bill Erickson Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 3 Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 17 5 Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js commit 0c3135c78913e9e55417012b5e84bb8f276c1c6f Author: Dan Pearl Date: Fri Mar 2 13:37:43 2018 -0500 LP173259 - Array error appears in search box while placing hold after advanced search The place-hold code assumed it was not in "_adv" parameter mode. This assumption was faulty. Now, the link generated for Place Hold will translate the argument list to the single-line format that Place Hold expected, when necessary. Testing procedure: Set holds for all the following items, observing that the searchbox in the searchbar is not blank and does not contain ARRAY(xxx). Basic Search / Place Hold Basic Search / Record Detail / Place Hold Advanced Search with a plain search term / Place Hold Advanced Search with a plain search term / Record Detail / Place Hold Advanced Search with a fancy (multiline) search term / Place Hold Advanced Search with a fancy (multiline) search term / Record Detail / Place Hold Signed-off-by: Dan Pearl Signed-off-by: Jason Stephenson Signed-off-by: Dan Wells 38 8 Open-ILS/src/templates/opac/parts/result/table.tt2 commit 3896f1ec89970c8e8e2e984b38558558977b8810 Author: Galen Charlton Date: Tue Feb 6 16:56:56 2018 -0500 LP#1738249: sort out circ or renewal workstation This patch uses accs to work out the name of the workstation of the most recent renewal, if it exists, or the original checkout. It implicitly handles the case where the workstation on the original circulation is null. As a bonus, this patch adds an explicit "Last Renewal Workstation" to the item status grid. Signed-off-by: Galen Charlton Signed-off-by: Cesar Velez Signed-off-by: Jason Stephenson 2 1 Open-ILS/src/templates/staff/cat/item/t_list.tt2 5 0 Open-ILS/web/js/ui/default/staff/circ/services/item.js commit 6f4002306d8fec5a33ec41fc12d5e831be6aa4aa Author: Galen Charlton Date: Tue Feb 6 16:44:32 2018 -0500 LP#1738249: further fix to checkout workstation Since accs.checkout_workstation contains the workstation associated with the initial loan (and not any subsequent renewals), use that. Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 1 1 Open-ILS/src/templates/staff/cat/item/t_list.tt2 0 1 Open-ILS/web/js/ui/default/staff/circ/services/item.js commit 785de699ea51c21377e2223ee8c0e8338297989f Author: Cesar Velez Date: Thu Jan 25 12:50:59 2018 -0500 LP#1738249 - Fix checkout_workstation display issue Addresses the issue with checkout workstation, by attaching as a object property to the flatCopy hash. Also makes sure the pcrud call uses combcirc. Signed-off by: Cesar Velez Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 1 1 Open-ILS/src/templates/staff/cat/item/t_list.tt2 2 1 Open-ILS/web/js/ui/default/staff/circ/services/item.js commit 9bd1e83b54e3089bc537085a59525a39280abad3 Author: Cesar Velez Date: Fri Jan 19 12:55:03 2018 -0500 LP#1738249 - Webstaff CircLib should point to item's circ_lib plus misc This addresses some display issues in the webstaff Item Status grid. Besides, correcting the Circ Lib to be the item's and not the circulation,this also fleshes the owning lib. Additionally, I've applied miker's fix to 1743819 in order to prevent a regression. Signed-off by: Cesar Velez Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 3 3 Open-ILS/src/templates/staff/cat/item/t_list.tt2 4 2 Open-ILS/web/js/ui/default/staff/circ/services/item.js commit 7af83a833a138778b223da0b191893df30975201 Author: Kathy Lussier Date: Tue Jan 16 23:40:32 2018 -0500 LP#1738249: Item status column picker fixes Adds some fixes to the column pickers in the web staff client Item Status interface: * The Circulation Library field now displays the asset.copy circ library instead of the checkout library. * The Circulation Library and Checkout / Renewal Library now show the shortname instead of the full name. * A typo fix so that Remaining Renewals display Conflicts: Open-ILS/src/templates/staff/cat/item/t_list.tt2 Signed-off-by: Kathy Lussier Signed-off-by: Cesar Velez Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 2 2 Open-ILS/src/templates/staff/cat/item/t_list.tt2 commit 18ac86c66617cbe3efefb52407877902c691ef86 Author: Kathy Lussier Date: Mon Mar 19 16:15:01 2018 -0400 LP#1756993: Add padding to bottom of web client pages Adds 50px of padding at the bottom of web client interfaces. This padding provides some breathing room at the bottom of the page without giving the appearance of too much white space. Signed-off-by: Kathy Lussier Signed-off-by: Terran McCanna Signed-off-by: Galen Charlton 3 0 Open-ILS/src/templates/staff/css/style.css.tt2 commit 509d9a3617797a32a288d75aab10a897e069a898 Author: Chris Sharp Date: Tue Apr 10 11:40:35 2018 -0400 LP#1746300: Fix circulation counts in Item Status Details Currently, the "Total Circs -Current Year" and "Total Circs - Prev Year" numbers are seemingly randomly incorrect. This is caused by pulling the numbers from the "circbyyr" fieldmapper object, which results in an array of 2 rows (one for renewals and one for new circs). The current JS only displays the count for the first item in the array, ignoring the other. This branch totals the two, resulting in the right result for each year's circulations. Signed-off-by: Chris Sharp Signed-off-by: Jeff Davis Signed-off-by: Galen Charlton 18 4 Open-ILS/web/js/ui/default/staff/cat/item/app.js commit ecb4bc828e622d3a080c1cc6c8802380a743f3e0 Author: Galen Charlton Date: Fri Mar 23 14:48:02 2018 -0400 LP#1758360: handle DOB display logic in egPatronSummary correctly This patch ensures that the patron DOB will be displayed or obscured correctly by the standalone egPatronSummary directive in the same way that the patron app does. To test ------- [1] In the web staff client, do a patron search, select two patrons, then click the Merge Patrons button. [2] Note that the patron DOB is not displayed in the modal. [3] Apply the patch and repeat step #1. [4] This time, the patron DOB will be displayed (if the circ.obscure_dob library setting is not enabled) or the the field label will be clickable (and clicking it will cause the DOB to be displayed). Signed-off-by: Galen Charlton Signed-off-by: Terran McCanna Signed-off-by: Bill Erickson 18 0 Open-ILS/web/js/ui/default/staff/circ/services/patrons.js commit 1915e01c775bae9b28dfe39efd2e5f1fdda5f357 Author: Jane Sandberg Date: Sat Mar 17 11:01:08 2018 -0700 LP1721143: making permission group dropdown scrollable in patron create/edit interface Signed-off-by: Jane Sandberg Signed-off-by: Terran McCanna Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 commit 2fcf3c8f583e56142014ab8d4669bcf42c301924 Author: Jeff Davis Date: Mon May 22 13:26:10 2017 -0700 LP#1682296: Avoid database query error on serials batch receive To test ------- [1] Example Search -> Retrieve title by database ID -> Actions for this Record -> Serials Batch Receive -> Next -> this works as expected & receivable issues are listed. [2] Click on "Start Over"; you are prompted to "Enter an identifier for a bibliographic record" this is where the search fails Example enter "109242427" results in two errors. [3] Desired behavior - If you enter a database ID or ISSN in the "Enter an identifier for a bibliographic record" field the receivable issuances should be displayed Signed-off-by: Jeff Davis Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/perlmods/lib/OpenILS/Application/Serial.pm commit fa7a46b6d511af4339a81be70129d49ce9801583 Author: Sam Link Date: Wed Jan 24 10:34:56 2018 -0500 LP#1744585: Patron summary display accessibility fix. When a patron summary contains an image of the patron, that image tag now has a null alt attribute to remove it from the flow of a screen reader. As the image provides no navigation capabilities or additional data, this is the proper way to assign an alt attribute Signed-off-by: Sam Link Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/templates/staff/circ/patron/t_summary.tt2 commit 3e6b8e3bc4498040acbf0b4336f2e0ddeb2b3a94 Author: Josh Stompro Date: Tue Dec 19 08:37:55 2017 -0600 LP#1739044: fix lock file detection in eg-pbx-allocator.pl Lock file detection wasn't working correctly. The wrong operator was used to read the contents of the lock file. Testing: Running the eg-pbx-allocator.pl in the background multiple times will trigger the lock file detection. Use -t to run in test mode to avoid moving any files while testing. /usr/local/bin/eg-pbx-allocator.pl -t -v -c /usr/local/etc/eg-pbx-daemon.conf & /usr/local/bin/eg-pbx-allocator.pl -t -v -c /usr/local/etc/eg-pbx-daemon.conf In syslog you can see entries that are missing the PID number when you test before the fix is installed. virt-asterisk1 eg-pbx-allocator.pl: lock file present (/tmp/eg-pbx-allocator-LOCK), still running after the fix is installed, you will see the PID in the syslog entry. virt-asterisk1 eg-pbx-allocator.pl: lock file present (/tmp/eg-pbx-allocator-LOCK), 21039 still running Signed-off-by: Josh Stompro Signed-off-by: Galen Charlton 1 1 Open-ILS/src/asterisk/pbx-daemon/eg-pbx-allocator.pl commit 546c15c8165fc397ca4feda492ca7be466a2eb96 Author: Josh Stompro Date: Tue Jan 23 13:19:20 2018 -0600 LP#1745001 - action_trigger_runner.pl max-sleep argument broken. Fix the --max-sleep argument so it accepts an integer number of max seconds to sleep waiting for a lock file to disappear. Testing: Before Fix: Add --max-sleep=60 to action_trigger_runner.pl and view the error message that results. After Fix: Run the same command and notice that it no longer errors out. Signed-off-by: Josh Stompro Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/support-scripts/action_trigger_runner.pl.in commit b5bc4ba61d71654d12f7f73f4c2b548c01e469c9 Author: Mike Rylander Date: Mon Apr 2 16:09:12 2018 -0400 LP#1760223: Update HTTP headers to follow standard In the olden days, some browsers didn't understand the "attachment" content disposition. They only understood "inline" but would let the user save a file if a filename was provided. However, in these modern days, relevant browsers all do the right thing and know about both flavors of content disposition, so we, too, must change with the times and support the letter of the standard. This commit fixes downloading of MARCXML from the Exporter module. Signed-off-by: Mike Rylander Signed-off-by: Jane Sandberg Signed-off-by: Cesar Velez Signed-off-by: Galen Charlton 1 1 Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm commit f7bc0a6417313fdc98d41a63bbde7049bb8fe138 Author: Mike Rylander Date: Mon Apr 16 10:29:05 2018 -0400 LP#1745233: Don't test for LURIs during copy location searches When a user is searching with a copy location or location group filter, Located URIs should not be used to include records in the result set because they are not "within" a copy location. Signed-off-by: Mike Rylander Signed-off-by: Cesar Velez Signed-off-by: Kathy Lussier 9 7 Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm commit 30965b209d817dd6e8298bab114e3f32cffd0592 Author: Remington Steed Date: Fri Apr 20 12:09:55 2018 -0400 Docs: Update several chapters for web client - User and Group Permissions - One new screenshot - Minor line reformatting - SMS Text Messaging - Update screenshots and alt text - Correction/clarification to some instructions - Barcode Completion - Replace composite screenshot with separate updated screenshots - Reformat headings to accommodate new screenshots - Update other screenshots - Slight rewording (change "actor" to "patron", "asset" to "copy") - Remove release date and reference to previous name of feature Signed-off-by: Remington Steed 12 8 docs/admin/SMS_messaging.adoc 32 17 docs/admin/lsa-barcode_completion.adoc 6 7 docs/admin/permissions.adoc - - docs/media/Barcode_Check_In.png - - docs/media/Barcode_Checkout_Item_Barcode.png - - docs/media/Barcode_Checkout_Patron_Barcode.png - - docs/media/Barcode_Item_Status.png - - docs/media/Barcode_OPAC_Staff_Place_Hold.png - - docs/media/SMS_Text_Messaging1.png - - docs/media/SMS_Text_Messaging2.png - - docs/media/SMS_Text_Messaging5.png - - docs/media/SMS_Text_Messaging6.png - - docs/media/lsa-barcode_completion_fields.png - - docs/media/lsa-barcode_completion_multiple.png - - docs/media/permissions_1a.png create mode 100644 docs/media/Barcode_Check_In.png create mode 100644 docs/media/Barcode_Checkout_Item_Barcode.png create mode 100644 docs/media/Barcode_Checkout_Patron_Barcode.png create mode 100644 docs/media/Barcode_Item_Status.png create mode 100644 docs/media/Barcode_OPAC_Staff_Place_Hold.png create mode 100644 docs/media/SMS_Text_Messaging1.png create mode 100644 docs/media/SMS_Text_Messaging2.png create mode 100644 docs/media/SMS_Text_Messaging5.png create mode 100644 docs/media/SMS_Text_Messaging6.png create mode 100644 docs/media/permissions_1a.png commit 591afad0e7ae078bb9efc566f8e6812bd29c1d44 Author: Dan Wells Date: Thu Apr 19 09:49:54 2018 -0400 Forward-port 3.0.7 upgrade script Signed-off-by: Dan Wells 5 0 Open-ILS/src/sql/Pg/version-upgrade/3.0.6-3.0.7-upgrade-db.sql create mode 100644 Open-ILS/src/sql/Pg/version-upgrade/3.0.6-3.0.7-upgrade-db.sql