2012-05-10 Jason Stephenson * Open-ILS/src/sql/Pg/2.0.10-2.0.11-upgrade-db.sql: Add the 2.0.10-2.0.11 upgrade script. Signed-off-by: Jason Stephenson 2012-03-26 Dan Wells * Open-ILS/web/js/ui/default/serial/subscription/issuance.js: Small fix to Holding Code wizard widget The issuance editor has a wizard widget for the holding code field which expected a 'grid' as an argument, but then referenced a global 'iss_grid' variable. This hurt reusability of this widget. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2012-03-26 Dan Wells * Open-ILS/xul/staff_client/server/serial/manage_subs.js: Serial Control: Refresh node map on edit While it would be nice to redraw any affected tree nodes when editing, we should at least replace the map data in case it is used in other functions. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2012-02-14 Lebbeous Fogle-Weekley * Open-ILS/examples/fm_IDL.xml, Open-ILS/src/perlmods/OpenILS/Application/Acq/Search.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/200.schema.acq.sql, Open-ILS/src/sql/Pg/upgrade/0691.schema.acq_fk_indices.sql: Acq: General Search refactor This is a combination of the following three commits from master: 3149433d354889fb 56121886c72b2d41 35fe5b9cbe10b132 The first two were meant for backport to rel_2_0 and rel_2_1 at the time, but the backport wasn't done. They were buggy anyway, and now it makes the most sense (I hope) to backport them together with the corrective commit all at once. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Jason Stephenson 2012-04-28 Jason Stephenson * Open-ILS/web/opac/skin/default/js/search_bar.js: Revert "Use getItemType() instead of getForm() in searchBarInit()." This reverts commit 47309fd18aad422b06fad51e5588400fd38cf71b. The reverted commit caused a problem with basic search, and fixing the problem with basic search was deemed more important than fixing this issue with Advanced seach. See Launchpad bugs: https://bugs.launchpad.net/evergreen/+bug/979158 https://bugs.launchpad.net/evergreen/+bug/788629 Signed-off-by: Jason Stephenson 2012-01-23 Jason Stephenson * Open-ILS/src/extras/Makefile.install: Install RPC::XML::Function on Ubuntu Lucid. Change the LUCID_CPAN target to install RPC::XML::Function instead of XML::RPC. Base on public bug report by Ben Shum (LP 920535). Signed-off-by: Jason Stephenson 2011-08-12 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/0599.data.fix_author_other_index.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_author_other_index.sql: Stamped upgrade script for "lp 823496: do not fail to index personal names that have relators" Signed-off-by: Mike Rylander Conflicts: Open-ILS/src/sql/Pg/002.schema.config.sql Signed-off-by: Jason Stephenson 2011-08-09 Galen Charlton * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.fix_author_other_index.sql: lp 823496: don't fail to index personal names that have relators The default definition for the author|other index inadvertantly excluded names from 600, 700, 720, and 800 fields that have relator values ($e) or codes ($4). Signed-off-by: Galen Charlton Signed-off-by: Jason Stephenson 2012-05-04 Bill Erickson * Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm: This addresses the issue where issuing refunds results in a negative ballance and it is then impossible to close the transaction by creating new billings. https://bugs.launchpad.net/evergreen/+bug/758982 Signed-off-by: Bill Erickson Signed-off-by: Jason Stephenson 2012-04-25 Dan Wells * Open-ILS/xul/staff_client/server/serial/manage_dists.js, Open-ILS/xul/staff_client/server/serial/manage_items.js, Open-ILS/xul/staff_client/server/serial/manage_subs.js, Open-ILS/xul/staff_client/server/serial/ssub_editor.js: Allow subscriptions at org units without volumes Subscriptions are sometimes owned at the consortium or system level, so forcing can_have_vols() to be true was incorrect. This commit removes those checks. In addition, we also remove some dead code and make the subscription org unit selector consistent with the distribution org unit selector. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2012-04-17 Jeff Godin * Open-ILS/src/perlmods/OpenILS/WWW/AddedContent/Syndetic.pm: Fix LP 984039: correct Syndetic Kirkus Reviews Use correct "filename" component of URL for retrieving Kirkus Reviews content from Syndetic Solutions. Correct filename confirmed by Bowker technical support, and by empirical tests. Signed-off-by: Jeff Godin Signed-off-by: Michael Peters 2012-04-03 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/holds.js, Open-ILS/web/opac/skin/default/js/myopac.js: Fix some "null" instead of blank values in JSPac Signed-off-by: Thomas Berezansky Signed-off-by: Michael Peters Signed-off-by: Lebbeous Fogle-Weekley 2012-04-13 Dan Wells * Open-ILS/src/perlmods/OpenILS/Application/Serial.pm: Better Prediction for Incomplete Chronologies While relatively rare, some journals record only the year on the cover, even if they come out monthly or weekly. This commit expands our previous support for serials with no chronology at all to cover serials with partial chronology. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2012-03-21 Mike Rylander * Open-ILS/src/c-apps/oils_sql.c: Shooting 2 obvious thinkos d-e-d dead. Pardon the rogueness. Signed-off-by: Mike Rylander 2012-02-02 Jason Stephenson * Open-ILS/web/opac/skin/default/js/search_bar.js: Use getItemType() instead of getForm() in searchBarInit(). This seems to actually fix the problem with the item type limiter being lost when going from advanced search to the results page. Looks like the wrong method was being used to set the form_selector value in search_bar.js. It was being set to the web form itself and not to the value of the it (item type) parameter. Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-11-01 Liam Whalen * Open-ILS/web/opac/skin/default/js/search_bar.js: When sorting a search results set the isFilterSort variable is passed to searchBarSubmit. In side searchBarSumbit there is a call to the opac_utils.js function clearSearchParams function. This removes all search paramaters when sorting a result set, which is not the desired effect. I have wraped clearSearchParams in a check to make sure isFilterSort is not set before calling the clearSearchParams function, and this check ensures that the current search's paramaters are passed to sort operations. Signed-off-by: Liam Whalen Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2012-02-24 Lebbeous Fogle-Weekley * Open-ILS/web/opac/skin/default/js/holds.js: Avoid JSPAC hold placement interface problems when no holdable copies This addresses a bug brought to my attention by John Jones. When you're trying to place certain holds (at least title level holds) on records for which there are no holdable formats (no descriptors as returned by open-ils.search.metabib.record_to_descriptors), then holdArgs.recordDescriptors in holds.js can be an empty array. There is a line of code that assumes this will never happen. The end user-visible result of the javascript failing here is an alert() dialog about phone number format, but this is a red herring. That only happens because the problem code is in one big function that has too many responsibilites. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Michael Peters Signed-off-by: Mike Rylander 2012-02-01 Bill Erickson * Open-ILS/web/js/ui/default/conify/global/action_trigger/event_defin ition.js: Paging repairs for Event definition admin UI If there are multiple event definitions with the same name that lie along the page boundaries, it's possible to page through event definitions seeing some def's multiple times and others never. This is a result of sorting solely on event def. name when fetching event def's for display. This patch adds secondary (and tertiary, and quaternary, and quinary) sort columns as tie breakers to guarantee a unique set of defs across pages. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2012-02-24 Mike Rylander * Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryPa rser.pm: Correctly quote regexp-y characters in phrase quoting helper There was one extra character that caused the use of quotemeta() to not actually happen. This broke two things: 1) phrase searching when the phrase had certain special characters in it -- test case: "c++" 2) use of relevance bumps in the same situation Signed-off-by: Mike Rylander 2012-01-30 Thomas Berezansky * Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action. pm: Stop targeter crash on empty metarecord with holds By checking for 1 or more records before looking them up. Signed-off-by: Thomas Berezansky Signed-off-by: Ben Shum Signed-off-by: Mike Rylander 2012-02-14 Dan Wells * Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm, Open-ILS/src/perlmods/OpenILS/Utils/MFHD/test/mfhddata.txt: Correct special winter handling in predictions The current serials prediction code has an exception for handling cases where 'Winter 2010' is followed by 'Spring 2010' rather than 'Spring 2011'. This exception assumed the more common case of a combined subfield $y, e.g.: $yps21,22,23,24 In doing so, it incorrectly handled less common cases where the $y is listed separately: $yps21$yps22$yps23$yps24 This change (with test data) ensures we only check the first $y for our 'early winter' exception. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2012-02-01 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/OpenILS/Application/Booking.pm: Booking: make pick up interface show resources captured for reservation ... ... even beyond the first day of the reservation. I can think of no reason why this limitation existed in the first place. Also, just replace naive_start_of_day() with "today" Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2012-01-19 Jason Etheridge * Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm: Handle search timeouts more gracefully Another tweak courtesy of berick Returns 0 results if open-ils.storage timeouts instead of a nasty uncaught undefined ARRAY exception resulting in an OPAC "spinning wheel of death" (formerly the "green knight rider bar of death". Note that in the event of storage timeouts, you should tune and/or beef-up your database. Signed-off-by: Jason Etheridge Signed-off-by: Lebbeous Fogle-Weekley 2012-01-22 Dan Scott * Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/metabib .pm: Fix "prefered_language" typo that blocked preferred language "preferred_language" is used everywhere else, but in the crucial core of metabib.pm the "prefered_language" variant is used to check on the value - hence, nothing other than the default "eng" is being used. Fix that. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-12-07 James Fournie * Open-ILS/src/perlmods/OpenILS/Application/Acq/Invoice.pm: Acq fix for LP#901378 Proratable invoice charges do not have a fund_debit, we need to check for this before attempting to delete the charge. If there's no fund_debit we can generally assume that there's no corresponding debit to this charge and skip trying to delete it. Signed-off-by: James Fournie Signed-off-by: Bill Erickson 2012-01-17 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/myopac.js: Don't show estimated wait for negative estimates JSPac code was just checking for the truth of the estimated_wait return, but the estimated_wait return can be -1 under some circumstances. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2012-01-10 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/hold_details.js: Remove 'boo' alert in hold details interface Willing to let any surprises here be natural. :-) We can re-bug if there are issues. Signed-off-by: Jason Etheridge Signed-off-by: Bill Erickson 2012-01-10 Dan Scott * Open-ILS/xul/staff_client/server/skin/print.css, Open-ILS/xul/staff_client/server/skin/serial.css: Add customization to staff client serial and print CSS files The *_custom.css variants of these are created automatically at install time, so give the parents the ability to actually use them. Signed-off-by: Dan Scott Signed-off-by: Jason Etheridge 2012-01-09 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0665.schema.renewal_checkout_counting.s ql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.renewal_checkout_counting.s ql: Stamping upgrade script for the backport of the renewal counting fix Signed-off-by: Mike Rylander 2011-12-16 Jason Etheridge * Open-ILS/src/sql/Pg/100.circ_matrix.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.renewal_checkout_counting.s ql: LP822918 fix adapted for rel_2_0 Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-09-26 Jason Etheridge * Open-ILS/src/perlmods/OpenILS/WWW/AddedContent.pm: LP#845763 remote added content breaks remote added content breaks when using locally served content Signed-off-by: Jason Etheridge Signed-off-by: Dan Scott 2011-12-08 Thomas Berezansky * Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm, Open-ILS/web/opac/locale/en-US/opac.dtd, Open-ILS/web/opac/skin/default/js/myopac.js, Open-ILS/web/opac/skin/default/xml/myopac/myopac_holds.xml, Open-ILS/xul/staff_client/server/circ/util.js, Open-ILS/xul/staff_client/server/locale/en-US/circ.properties: Show Suspended holds as Suspended In the staff client and JSPac show the status of a suspended hold as Suspended rather than something like "Waiting for copy". Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-12-16 Dan Scott * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0658.schema.acn_dewey_sort_fix.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.dewey-sort-fix.sql: LP# 902667 - Wrap upgrade script for Dewey sorting Signed-off-by: Dan Scott 2011-12-10 James Fournie * Open-ILS/src/sql/Pg/040.schema.asset.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.dewey-sort-fix.sql: Fix Dewey call number sorting Ported over Koha commit aef8358c - fix for Koha Bug 4265. Further documented in Evergreen LP # 902667 Here's the description from the commit message by Magnus Enger: C4::ClassSortRoutine::Dewey turns "306 Les" into "306_Les" for items.cn_sort and MARC-field 952$6, which results in "306.46 Les" being sorted before "306 Les" in the OPAC. With this patch, "306 Les" is turned into "306_000000000000000_Les". Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-12-14 bott * Open-ILS/web/opac/skin/default/js/rdetail.js: Allow for the page offset when listing the "Result x of y" values. The record details page did not show the page offset correctly, so result 13 would show up as "Result 3 of ###", and result 23 would also show up as "Result 3 of ###". Signed-off-by: bott Signed-off-by: Dan Scott 2011-12-13 Bill Erickson * Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm: Clear hold shelf/shelf_expire time for pickup lib change If a hold is on the holds shelf and the pickup library changes, clear the shelf_time and shelf_expire_time, since the hold is now in transit. This is particularly important for avoiding action_trigger events for the "hold_request.shelf_expires_soon" hook for what is now an in-transit item. Signed-off-by: Bill Erickson Signed-off-by: Thomas Berezansky 2011-12-05 Dan Wells * Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: Code comments and tweaks for lost processing This commit is intended to do the following: * Fix case where MISSING status is not retained for items being sent 'home' (as it was in previous versions) * Be more explicit about when we unset the LOST status and when we do not in checkin_handle_lost() * Prevent update of the copy in checkin_handle_lost() unless we actually change the status * Restore log messages for special handling of LOST/MISSING checkins away from 'home' * Provide additional code comments to clarify intended behavior Note: Given the current restructure, MISSING item behavior is no longer affected by 'lost_immediately_available' setting. That seemed more bug than feature, and can be implemented later (perhaps as a separate setting) if required. Signed-off-by: Dan Wells Signed-off-by: Jason Stephenson 2011-11-29 Jason Stephenson * Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: Check OILS_SETTING_LOST_IMMEDIATELY_AVAILABLE in checkin_handle_lost. Check the value of OILS_SETTING_LOST_IMMEDIATELY_AVAILABLE before changing the copy status in checkin_handle_lost. This makes the setting actually do something. Add a couple of blank lines to aid in readability. Signed-off-by: Jason Stephenson Signed-off-by: Dan Wells 2011-11-17 Jason Stephenson * Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: Fix LP851000. Remove about 14 lines from OpenILS/Application/Circ/Circulate.pm in the checkin_handle_circ subroutine that check whether or not the checkin happens at the copy's circ_lib and the value of the circ.lost_immediately_available org unit setting. This change causes the handle_lost subroutine to run regardless of where the checkin takes place for a more consistent experience. Whether or not billings are voided, overdues restored, etc. is still determined by the copy's circ_lib. Given how the hold targeter and transit code works, it does not appear the the circ.lost_immediately_available setting could ever do what it was intended to do. Given these changes to the code it is now unnecessary. Signed-off-by: Jason Stephenson Signed-off-by: Dan Wells 2011-11-28 Dan Scott * Open-ILS/src/extras/Makefile.install: Revert Lucid prereq for PostgreSQL 9.0 client rel_2_0 only requires PostgreSQL 8.4; commit f87437cb1e209eba04c4719adbdf2ddc21b36f04 pushed the prereq to 9.0 but as that requires adding backport repos many sites will break when trying to just upgrade from 2.0.9 -> 2.0.10. So, revert that. Signed-off-by: Dan Scott 2011-11-23 Ben Shum * Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action. pm: Fix for LP894125 - reshelving interval Update to reshelving code to utilize actor.org_unit_ancestor_setting function and properly retrieve org settings for "circ.reshelving_complete.interval" for org unit or ancestors. Signed-off-by: Ben Shum Signed-off-by: Jason Stephenson 2011-11-22 Dan Scott * Open-ILS/xul/staff_client/server/cat/bib_brief.xul: Enable record summary to be scrollable at larger font sizes The record summary at the top of the cataloguing interfaces appears to determine its size based on the "normal" font size at load; then, when a larger font size is applied to the page, the text gets hidden by the fixed size of the groupbox. Ideally the groupbox would adjust to accomodate the larger font size, but after trying many different approaches the best short-term approach seems to be to enable overflow so that scrollbars can appear when necessary. Signed-off-by: Dan Scott Signed-off-by: Jason Etheridge 2011-11-15 James Fournie * Open-ILS/xul/staff_client/server/cat/copy_browser.js: Quasi-backport fixes a bug whereby the copy browser does not automatically refresh after adding volumes. This bug is fixed in future versions by git commit bcd6f20b but the bugfix itself is not noted in that commit message. Signed-off-by: James Fournie Signed-off-by: Jason Etheridge 2011-11-17 Dan Wells * Open-ILS/web/opac/skin/default/js/rdetail.js, Open-ILS/web/opac/skin/default/js/result_common.js: Switch to new Google Books API; make SSL friendly As implied in the title, this commit does two things. First, it switches to the new Google Books API (which is both imminent and also necessary to make SSL calls work). From what I have read and experienced, we do not need an API key to do searches and previews. I have also not hit any kind of unauthenticated limit in several days of heavy testing, so I would figure we are safe (at this point) for normal end-user OPAC browsing. Second, all Google Book requests are now done over https. This eliminates the majority of mixed content warnings when browsing securely, though you still get a warning when you actual do preview a book. In addition to possibly implementing protocol detection (rather than doing https all the time as a "lowest" common denominator), there are a few minor points where we might consider future changes. Those points are commented within the code. Signed-off-by: Dan Wells Signed-off-by: Dan Scott 2011-11-15 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0649.schema.fix_full_circ_count_view.sq l, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Stamped upgrade for full circ count view fix Signed-off-by: Mike Rylander 2011-09-29 Thomas Berezansky * Open-ILS/src/sql/Pg/extend-reporter.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Use DISTINCT in counts to avoid dupes Otherwise you get: Legacy count + 2(normal count)(aged count) Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-09-29 Dan Wells * Open-ILS/src/sql/Pg/extend-reporter.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Full Circ Count View Amplifies Legacy Circs The current extend_reported.full_circ_count sums the legacy circ count column, but this results in amplifying the count by the number of current circs in the system. This commit adds the legacy count to the GROUP BY instead of summing it. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-11-01 Liam Whalen * Open-ILS/xul/staff_client/server/cat/marcedit.js: Aligned the MARC editor subfields to 'start' fixes long subfield display When viewing a record in the MARC editor that has extremely long entries in a subfield, the output would align in the center of the subfield making the output hard to read. This patch adds an align: 'start' option to both the subfield, and the subfield code elements in the marcSubfield function to make the subfields align in a more readable manner. Signed-off-by: Liam Whalen Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * Open-ILS/web/js/ui/default/actor/user/register.js: Patch from Jeff Davis (SITKA) fixing cardless patron updates Quoth the bug report (https://bugs.launchpad.net/evergreen/+bug/851110): On our Evergreen 2.0.8 system, it sometimes arises that a patron's card gets deleted. If it was the patron's only card, it becomes impossible to add a new card to the account via the staff client. How to reproduce: 1. Retrieve a patron record for a patron who has no associated card. 2. Click the Edit button. 3. Click Replace Barcode and enter a new barcode. 4. Click Save. This does not work - the process hangs, and if you hit Reload, you will find that your changes were not saved. I believe this happens because some code in register.js assumes the patron has at least one card. I have a potential fix that this comment box is too small to contain ... uh, that is to say, I will post it momentarily. Which he did, and I applied. Signed-off-by: Mike Rylander 2011-10-19 Steven Callender * Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action. pm: Reshelving update. Update to the reshelving code to make it faster and utilize the new status change time field on asset.copy. Signed-off-by: Steven Callender Signed-off-by: Mike Rylander 2011-10-23 Dan Scott * Open-ILS/src/c-apps/Makefile.am, Open-ILS/src/c-apps/idlval.c: Make idlval build, rather than be dead code The tool "idlval" contained in Open-ILS/src/c-apps can be used to check the correctness of fieldmapper definitions in files like Open-ILS/examples/fm_IDL.xml - but currently does not have a build target, nor does it compile cleanly due to the use of unspecified OpenSRF header files. This commit adds a build target, fixes the compile problems, and installs the tool in the bin directory. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-11-08 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/cat/opac.js, Open-ILS/xul/staff_client/server/cat/util.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js: LP887822 mint_condition/Quality not set correctly during item creation. Specifically, the Javascript object for a new item (acp) does not explicitly set the mint_condition field, leaving it null. The item attribute editor treats the null as false (which it displays as "Mediocre" for that field). The database has a not null constraint the corresponding column in asset.copy, and defaults to true. So a new item in the attribute editor will show "Mediocre", but when actually created, will become "Good". This branch just sets mint_condition to true when an item is created. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-10-11 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/OpenILS/Application/Trigger/Reactor.pm, Open-ILS/src/support-scripts/edi_pusher.pl: More filtering of characters that could end up in PO JEDI template output Backslashes cause problems too. Let's JSON encode this thing and get it right once and for all. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Ben Shum Signed-off-by: Bill Erickson 2011-11-10 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/widget/HoldingCode.js, Open-ILS/web/js/ui/default/serial/subscription/issuance.js: Serials: allow freer input in holding code mini-wizard In the Subscription Details interface of the Alternate Serials Control View, under the Issuance tab, if you create a new issuance you can now enter things like "01/02" in (say) the month field to denote a combined January/February issue. All those fields are now free-form, whereas some of them used to be numeric only. Also, avoid an occasional issue where an error message about dijit.form.DateTextBox not being a constructor would appear in the JavaScript console. The problem was in a race condition among some co-dependent JavaScript files that were all being loaded at the same time. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Wells 2011-11-10 Jason Etheridge * Open-ILS/examples/apache/eg_vhost.conf, Open-ILS/web/opac/common/js/RemoteRequest.js, Open-ILS/xul/staff_client/chrome/content/util/network.js: LP88653 force SSL for requests from local XUL Modifies RemoteRequest.js to convert any http:// request URL to https:// if the requesting location has a chrome:// protocol. Modifies util/network.js such that any use of util.network.request (as opposed to util.network.simple_request) will assume "secure" for the resulting request. Adds an example to the bottom of eg_vhost.conf for forcing SSL for an entire site (OPAC and everything), courtesy of Dan Wells. Signed-off-by: Jason Etheridge Signed-off-by: Dan Wells 2011-11-09 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marcedit.js: XML.ignoreWhitespace causes syntax errors So remove it. Disabling pretty printing appears to be enough to fix the marc editor. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-11-07 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marcedit.js: Fix vanishing whitespace in marc editor XML.ignoreWhitespace and XML.prettyPrinting cause whitespace to vanish. So disable them at the top of marcedit.js. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-10-31 Galen Charlton * Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm: lp849447: trival stylistic tweaks - rename variable avoid double-negative - avoid 'Variable declared in conditional statement' perlcritic gripe Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 2011-09-14 Sarah E. Chodrow * Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm: Initial patch from Sarah Chodrow on LP bug 849447. Also check for standing penalties and expired cards when checking if it is ok for the patron to checkout, charge_ok. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Sarah E. Chodrow (sarah.chodrow@bibliotheca-itg.com) Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-11-08 Mike Rylander * Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm, Open-ILS/xul/staff_client/chrome/content/main/constants.js: Protect against slony replication lag, LP#621448 Make open-ils.circ.captured_holds.id_list.* API calls authoritative within the staff client to avoid replication-lag related stale displays. Inspired by James Fournie at SITKA. Signed-off-by: Mike Rylander 2011-09-27 Jason Etheridge * Open-ILS/web/opac/skin/default/js/holds.js: LP#860845 hold placement UI can break hold placement UI can break and give misleading error on Submit Adds some defensive coding, but since I don't quite grok everything going on here, may not be the best fix. Signed-off-by: Jason Etheridge Signed-off-by: Lebbeous Fogle-Weekley 2011-11-01 James Fournie * Open-ILS/src/perlmods/OpenILS/Application/Acq/Search.pm: This prevents the acq unified_search method from returning anything other than the objects of the expected type. This is to address LP 884991 in which Acq users get a perm error for each result of a search that they don't have access to retrieve. They shouldn't even know about the existence of anything they don't have access to retrieve. Signed-off-by: James Fournie Signed-off-by: Lebbeous Fogle-Weekley 2011-09-20 James Fournie * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/040.schema.asset.sql, Open-ILS/src/sql/Pg/upgrade/0646.schema.lp854972_copy_counts_unshad ow.sql: Previously invisible copies showed as beige in the staff client, they stopped doing this in 2.0 This is because in 2.0 the copy counts logic was moved from open-ils.storage.biblio.record_entry.copy_count.staff to an in-database function wrapped in open-ils.search.biblio.record.copy_count.staff. Both methods returned various counts including an 'unshadow' count, however the 'unshadow' in the new database function was not completed and it has only been returning a simple copy count rather than a count of opac visible copies as it should be to replicate the old behaviour. Signed-off-by: James Fournie Signed-off-by: Lebbeous Fogle-Weekley 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/acq/nls/acq.js, Open-ILS/web/js/ui/default/acq/common/li_table.js: Acq: better error message if trying to create PO without provider or agency Before now, if you leave either the provider or ordering agency fields blank in the "Create Purchase Order" dialog, you get a nonsensical warning about prepayment. This fixes that. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-11-03 Liam Whalen * Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: Modified authority.indexing_ingest_or_delete to update MARC data The authority.indexing_ingest_or_delete trigger in the update script was missing a call to authority.propagate_changes which is responsible for updating the MARC data of records affected by an auhtority merge. This patch adds the call to authority.propagate_changes as it appears in the authority.indexing_ingest_or_delete trigger from the file 999.functions.global.sql. Signed-off-by: Liam Whalen Signed-off-by: Dan Scott 2011-11-02 Mike Rylander * Open-ILS/src/perlmods/OpenILS/Application/Storage/QueryParser.pm: 2.0-ification of the phrase-search fix for LP#834042 Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/web/js/ui/default/acq/common/li_table.js, Open-ILS/web/js/ui/default/acq/search/unified.js: Acq: fix a bug that sometimes prevents the general search page from loading Within Acquisitions General Search, javascript included from one file in the relies on the variable "localeStrings" being initialized by javascript included from a file in . Sometimes the wrong javascript wins the race, you get an error about localeStrings being undefined in the Javascript console, and the page stops loading. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-11-01 Dan Scott * Open-ILS/src/perlmods/OpenILS/WWW/AddedContent/Amazon.pm: Force Amazon AC requests to use 10-digit ISBNs Inspired by a patch submitted by Ian Bays via https://bugs.launchpad.net/evergreen/+bug/870171, this patch takes the incoming key and, if it is longer than 10 characters (a 10-digit ISBN or Amazon ID), attempts to normalize it and return a 10-digit ISBN. We don't normalize all incoming keys because some sites are horribly abusing the 020 MARC field to include an Amazon ID instead of an ISBN - but that works in practice and we'd rather not break working installations if we can avoid it. Signed-off-by: Dan Scott 2011-10-19 Jason Stephenson * Open-ILS/src/perlmods/OpenILS/Application/Actor.pm: Use ne on line 631 of Actor.pm. This is so that we stop getting errors like Argument "1319057146.8881216485.4819607085" isn't numeric in numeric ne (!=) at /usr/local/share/perl/5.10.1/OpenILS/Application/Actor.pm line 630. in /openils/var/log/open-ils.actor_stderr.log Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-27 Michael Peters * Open-ILS/examples/apache/eg.conf: A tweak to eg.conf to prevent against the BEAST exploit in TLS/SSL Based on recommedation from https://community.qualys.com/blogs/securitylabs/2011/10/17/mitigating-the-beast-attack-on-tlsSigned-off-by: Michael Peters Signed-off-by: Galen Charlton 2011-10-05 Bill Erickson * Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm: Z39.50 local catalog fetch-more repairs Fixes the following problem: When paging through local catalog results in the Z39.50 interface, paging off then end of the local results would result in an unknown server error caused by trying to retrieve an empty list of records. $list->{count} in this context is the overall hit count, not the counts in the current page of results. Note also if {count} is zero, the list of IDs will be undef, so we use both. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/OpenILS/Application/Acq/Order.pm: Avoid a possible bug in selection list deletion This particularly matters for the "ephemeral," unnamed selection list that Acquisitions General Search uses to hold bib records represented as lineitems, as that list is deleted for the next run of that kind of search. It's possible to get lineitems onto that list that are in a state other than "new". Code that deletes this list first deletes the lineitems that belong to it, but that code formerly assumed that there are two types of lineitems. "new" ones (that should be deleted) and ones that belong to purchase orders (that should be deatched). That doesn't necessarily cover all possible lineitems on the picklist, so deletion ultimately fails. This fixes that. [update: now this bugfix incorporates a bugfix, the need for which was detected by Ben Shum. See LP #869581] Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-16 Dan Scott * Open-ILS/src/perlmods/OpenILS/Application/Fielder.pm: Cache open-ils.fielder results by locale The problem was particularly visible in search facets, but existed before: the cache key used for fielder results did not take locale into account, so on a multi-locale system the first locale won and populated the cache for all other locales. Use a session locale if provided, otherwise default to the locale set in opensrf.xml Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-10-04 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/adv_global.js: Add "submit on enter" to all advanced search boxes Instead of just the one with an ID specified. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-13 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0639.schema.asset_merge_record_assets.s ql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.asset_merge_record_assets.s ql: Stamping upgrade for asset.merge_record_assets fix from dbs Signed-off-by: Mike Rylander 2011-10-13 Dan Scott * Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.asset_merge_record_assets.s ql: Fix located URI merging in action.merge_record_assets() Perhaps due to the unexpected results of the XPath expression, which returns a count of nodes for subfields, etc, rather than just a count of the number of 856 datafields, NULL was being concatenated onto a string - which of course made the string NULL. Use COALESCE() to prevent the NULLness from spreading and enable action.merge_record_assets() to do the right thing. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-09-16 Jason Stephenson * Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm: Fix z39.50 import isbn and issn searches on local catalog. Make cat_search_z_style_wrapper do identifier searches for isbn and issn. Modify the_quest_for_knowledge to accept identifier searches for isbn and issn. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-11 Bill Erickson * Open-ILS/src/c-apps/oils_auth.c: Authentication block logging * Login too-many-auth-failures message at Info level instead of Internal * Log the username getting blocked Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2011-10-10 Dan Scott * Open-ILS/src/extras/Makefile.install: Fix broken Net::Z3950::SimpleServer 1.14 install Pin the install of Net::Z3950::SimpleServer to the known-to-work-with yaz 3.0.x version, 1.12. 1.14 introduced dependencies on yaz 4.1.x that can't be easily worked around. Signed-off-by: Dan Scott Signed-off-by: Galen Charlton 2011-10-06 Galen Charlton * Open-ILS/src/c-apps/oils_auth.c: fix authentication failure Ensure that the auth_limit values are read when open-ils.auth initializes, not during oilsAuthInit(). This solves a problem observed on brick-based setups where authentication could incorrectly fail because the drone that processes open-ils.auth.authenticate.complete didn't have the the block count value initialized yet. Also fixed type nit when compare the fail count to the block limit. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2011-10-04 Lebbeous Fogle-Weekley * Open-ILS/web/js/ui/default/acq/common/li_table.js, Open-ILS/web/js/ui/default/acq/common/li_table_pager.js, Open-ILS/web/js/ui/default/acq/search/unified.js: Really add *entire* selection list to a purchase order, when desired, and generally do what a user would expect when, in Acq, the user executes an operation on "all items". This addresses LaunchPad bug #810030. The fundamental issue is that an AcqLiTable, which is used in several different ways in different interfaces, may be representing items on a selection list (for example), but it doesn't necessarily know all of the items that belong to that selection list. It only knows what it has drawn. This addresses that deficiency by teaching the getSelected() method some new tricks so that it can consult the server in the various ways appropriate to getting a list of /all/ the items on a selection list, a purchase order, a virtual PO, a set of search results, etc. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-10-04 Jason Etheridge * : commit 1c85f6e9c3b97f1e71d73c41baf4b21226ffe580 Author: Thomas Berezansky Date: Fri Aug 12 09:17:46 2011 -0400 2011-10-04 Mike Rylander * Open-ILS/src/sql/Pg/2.0.9-2.0.10-upgrade-db.sql: Upgrade script for 2.0.10 Signed-off-by: Mike Rylander 2011-09-24 Thomas Berezansky * Open-ILS/src/perlmods/OpenILS/Application/Actor.pm, Open-ILS/web/opac/skin/default/js/myopac.js, Open-ILS/web/opac/skin/default/xml/myopac/myopac_summary.xml: Require password to change email/username Alter backend to check password period, not just for password changes. Add form elements for asking for current password to JSPac. Add handling for said form elements where needed. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-12 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/auth/session.js: When workstation is invalid request a new seed The original one may no longer be valid Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-01 Thomas Berezansky * Open-ILS/examples/opensrf.xml.example, Open-ILS/src/c-apps/oils_auth.c: Make more auth values configurable Amount of time seed is valid Amount of time to keep failure count in memcache since last auth event Number of failures before locking out auth attempts Also, remove seed from memcache once it has been used once. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-08-30 Thomas Berezansky * Open-ILS/src/c-apps/oils_auth.c: Brute Force protection for authentication Count auth failures in memcache. If 10+ have occurred cause failure. After 90 seconds of no activity counter resets. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-30 Lebbeous Fogle-Weekley * Open-ILS/examples/fm_IDL.xml: link asset.copy_template.status to config.copy_status in the IDL If nothing else, this provides a dropdown for status in the copy template editor (the one for Serials, under the admin menus, not the one on the copy editing interface). Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Wells 2011-10-03 Lebbeous Fogle-Weekley * Open-ILS/web/opac/common/js/org_utils.js, Open-ILS/web/opac/skin/default/js/rdetail.js: JSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ... ... when search scope would have it so. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Scott 2011-09-10 Dan Scott * Open-ILS/src/extras/Makefile.install: Refresh dynamic link cache after libjs install The build of SpiderMonkey can fail if it can't find the freshly installed libjs library, so run ldconfig after building libjs to avoid that bit o' fun. Signed-off-by: Dan Scott 2011-09-29 Dan Scott * Open-ILS/web/opac/skin/default/js/rdetail.js: LP740320: Make submit the new bookbag dialog For the keyboard jockeys out there - if the enter key doesn't submit, the UI reviewer will not commit. Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Initial dialog isn't quite wide enough, here's a hackish way to fix it Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Should probably use a more common button rather than the one for the advanced search Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/js/rdetail.js: This makes more sense as an alert; the Dojo dialog has no button which is not user-friendly. Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-02 Mike Rylander * Open-ILS/web/opac/skin/default/js/rdetail.js, Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Markup-based dijit.Dialog implementation, inspired by and based on a patch from Joseph Lewis in https://bugs.launchpad.net/evergreen/+bug/787162 Signed-off-by: Mike Rylander Signed-off-by: Dan Scott 2011-09-16 Liam Whalen * Open-ILS/xul/staff_client/server/cat/spine_labels.js: Modified spine_labels.js to retain UTF-8 encoding Dan Wells posted a fix to the DEV list for receipt printing that allowed the receipt printer to print UTF-8 characters. I used the ideas in that fix to modify spine_labels.js. In spine_labels.js, the url passed to the preview in preview_xul_192 was encoding the url with the javascript encode() function. This function does not preserve UTF-8 encodings. I changed the function to encodeURIComponent, and UTF-8 characters are now displayed properly by the spine label printer code. Signed-off-by: Liam Whalen Signed-off-by: Dan Scott 2011-09-28 Michael Peters * Open-ILS/web/templates/default/conify/global/acq/edi_account.tt2: A slight modification to prevent clipping in the EDI Accounts interface Just a few tweaks via CSS to make sure the footer notes don't clip off part of the main grid. Signed-off-by: Michael Peters Signed-off-by: Mike Rylander 2011-09-28 Mike Rylander * Open-ILS/src/reporter/clark-kent.pl: Provide proper hrefs for links back from report debugging pages Reimplementation of a fix provided by Michael Peters. The originally submitted patch included several fixes provided by an unrelated patch, and a regression in build-time embedded tokens. Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_linksSigned-off-by: Mike Rylander 2011-09-22 Dan Scott * Open-ILS/src/reporter/clark-kent.pl: LP856567: Mark HTML report output as Unicode-encoded Non-ASCII characters in report ouput that has been generated in HTML format appears to be corrupted when viewed in a browser. This can be manually corrected by switching the "Encoding" browser option, but it would be better to include in the output HTML to tell the browser directly. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-09-27 Dan Wells * Open-ILS/src/perlmods/OpenILS/Utils/MFHD.pm, Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm: MFHD compression fails with pattern-less captions The current code assumes that if you try to compress a range of MFHD holdings, you actually have the necessary pattern information. This commit introduces a very basic check to avoid the most common failure case. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-09-26 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/0629.data.jedi-template.sql: 2.1-ish upgrade script preamble Signed-off-by: Mike Rylander 2011-09-26 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0629.data.jedi-template.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.jedi-template.sql: Stamping upgrade script for EDI cleanup Signed-off-by: Mike Rylander 2011-09-19 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/OpenILS/Application/Trigger/Reactor.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.jedi-template.sql, Open-ILS/src/support-scripts/edi_pusher.pl: Some EDI translation fixes for troublesome input characters This attempts to address enough of the issues in https://bugs.launchpad.net/evergreen/+bug/812593 to move forward. When the ? character appears in lineitem attributes for a PO that we send off for EDI translation, the translator fails if that ? is the last character of the string. This commit avoids that situation. This commit also removes any Unicode characters from the JEDI (the input to the translator process), as they're not going to make it to the EDIFACT output anyhow, and will just confound the translator. This commit also pre-escapes quotation marks in lineitem attributes so that we don't produce invalid JSON for our JEDI. This commit also destroys the death star. Seriously, the right way to fix some of the issues people have had is for somebody to learn Ruby and to address them either in edi_webrick.rb, in edi4r, or in openils-mapper (wherever the issues may be). Working on that. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-09-25 Galen Charlton * Open-ILS/src/support-scripts/marc_stream_importer.pl: lp859190: make marc_stream_import always import non-matches Fixes regression of (implicit, undocumented) functionality introduced in commit da3a45344205. Current use case for the streaming MARC importer for OCLC Connexion exports assumes that non-matching records should always be added. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2011-09-21 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/main/bindings.xml: properties in chrome:// return XHR status 0 Signed-off-by: Jason Etheridge 2011-09-20 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/main/bindings.xml: LP#854760 messagecat fails with certain 404 pages We were failing to check the HTTP status on the underlying XHR requests. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-09-16 Dan Scott * Open-ILS/src/templates/password-reset/request-form.tt2: Can't have two identical IDs on the same page Nobody who cares about the pure Web experience ever noticed that this page has two identical IDs. Chromium and other browsers complain, though, so make them happy. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-08-25 Bill Erickson * Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: Clear hold shelf [expire] time at checkout to alternate patron When an item on the holds shelf is checked out to an alternate patron (i.e. not the hold user), clear the shelf_time and shelf_expire_time along with capture_time, current_copy, etc. on the hold. tsbere++ for isolating the problem. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-09-14 Jason Etheridge * : commit 572607f08126548c30075439e2983b9029fd205b Author: Jason Etheridge Date: Wed Aug 3 00:44:41 2011 -0400 2011-09-13 Mike Rylander * Open-ILS/xul/staff_client/server/cat/marcedit.js, Open-ILS/xul/staff_client/server/cat/marcedit.xul: Provide a default value for, and explicitly change, the record type so the type dropdown works as intended Signed-off-by: Mike Rylander 2011-09-09 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/print.js: Fix dos_print when NSPrint interface is used By adding params.dos_print = true where needed. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-09-07 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/OpenILS/Application/Trigger/Reactor/AstCall.p m: A/T reactor 'AstCall' can't have global CStoreEditor It's not good for any Evergreen service to try to have a global cstoreeditor instance. Scope it to the handler() sub that needs it, and comment out the thus-far unused/unfinished retrieve() sub. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-08-30 Jason Stephenson * Open-ILS/examples/oils_sip.xml.example, Open-ILS/src/Makefile.am: Fix for LP bug #702422. Add @libdir@/javascript/ path in legacy script section of oils_sip.xml.example so that legacy scripts work with SIP2. Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-08-31 James Fournie * Open-ILS/web/js/ui/default/conify/global/acq/provider.js, Open-ILS/web/templates/default/conify/global/acq/provider.tt2: Adding org unit context selector to providers screen This helps alleviate the bug reported in LP 731510 and generally improves usability. Signed-off-by: James Fournie Signed-off-by: Mike Rylander 2011-09-06 Dan Wells * Open-ILS/src/extras/org_tree_js.pl: Clear org_unit cache fix for autogen.sh autogen.sh is not properly clearing the org_tree cache. It is unclear how this hasn't caused a problem before, but this fix works for me and should be at least harmless in other enviroments. Signed-off-by: Dan Wells Signed-off-by: Lebbeous Fogle-Weekley 2011-07-20 Jason Etheridge * Open-ILS/xul/staff_client/server/circ/util.js, Open-ILS/xul/staff_client/server/patron/util.js: adjust legacy xul column definitions for dates/timestamps to ensure correct sorting Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-07-18 Jason Etheridge * Open-ILS/xul/staff_client/server/admin/transit_list.js, Open-ILS/xul/staff_client/server/admin/work_log.js, Open-ILS/xul/staff_client/server/cat/copy_browser.js, Open-ILS/xul/staff_client/server/cat/copy_buckets.js, Open-ILS/xul/staff_client/server/cat/copy_summary.xul, Open-ILS/xul/staff_client/server/cat/record_buckets.js, Open-ILS/xul/staff_client/server/cat/z3950.js, Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.js, Open-ILS/xul/staff_client/server/circ/checkin.js, Open-ILS/xul/staff_client/server/circ/checkout.js, Open-ILS/xul/staff_client/server/circ/copy_details.xul, Open-ILS/xul/staff_client/server/circ/copy_status.js, Open-ILS/xul/staff_client/server/circ/in_house_use.js, Open-ILS/xul/staff_client/server/circ/renew.js, Open-ILS/xul/staff_client/server/circ/util.js, Open-ILS/xul/staff_client/server/patron/hold_details.js, Open-ILS/xul/staff_client/server/patron/holds.js, Open-ILS/xul/staff_client/server/patron/items.js, Open-ILS/xul/staff_client/server/serial/manage_dists.js, Open-ILS/xul/staff_client/server/serial/manage_items.js, Open-ILS/xul/staff_client/server/serial/manage_subs.js: remove circ.util.std_map_row_to_columns; default to the one provided by list.js Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-07-18 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/util/list.js, Open-ILS/xul/staff_client/server/circ/util.js: Better sort support for xul lists (see launchpad bug ://bugs.launchpad.net/evergreen/+bug/751745) Example of supplying a sort_value function for item Create Date, and automatic sort_value for fm_columns-generated timestamp and money column definitions. Need to provide more such functions, and eventually move everything over to fm_columns Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-09-01 Dan Wells * Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action. pm: Hourly fine periods do not charge enough Hourly fine periods are not charging for the first period of overdue-ness. If an item is due at 2:00pm and has a fine of $.50 per hour, the first fine should be eligible for generation at 2:01pm. As it stands, the first fine does not generate until an entire fine period has elapsed, so in this case, 3:00pm. The previous version of the code had a special case for day- granular fine periods, so a majority of fines were not affected. This commit expands the same idea (charging for the fine period you are currently "in") to all fine periods. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-05-18 Galen Charlton * Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: avoid error when generating fines on checkin Prevents "No active transaction to commit" error when checking in overdue loans. Signed-off-by: Galen Charlton Signed-off-by: Dan Wells 2011-08-10 Michael Peters * Open-ILS/xul/staff_client/server/patron/info_notes.xul: LP#824257 Fix nasty overlapping when patron has more than 6 notes Signed-off-by: Michael Peters Signed-off-by: Jason Etheridge 2011-08-24 Mike Rylander * Open-ILS/src/extras/Makefile.install: Correct make target for lucid Signed-off-by: Mike Rylander 2011-08-24 Mike Rylander * Open-ILS/src/sql/Pg/2.0.8-2.0.9-upgrade-db.sql: Put the actual release number into the upgrade script Signed-off-by: Mike Rylander 2011-08-24 Mike Rylander * Open-ILS/src/sql/Pg/2.0.8-2.0.9-upgrade-db.sql: 2.0.9 upgrade script Signed-off-by: Mike Rylander 2011-08-24 Mike Rylander * Open-ILS/src/sql/Pg/2.0.7-2.0.8-upgrade-db.sql: Adding tag upgrade script to parent branch Signed-off-by: Mike Rylander 2011-08-23 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0607.schema.oua_force_order.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.oua_force_order.sql: 2.[01]-stamped upgrade script for LP#816131 Signed-off-by: Mike Rylander 2011-08-22 Thomas Berezansky * Open-ILS/src/sql/Pg/020.schema.functions.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.oua_force_order.sql: Reverse direction of org_unit_ancestors Apparently callers expect it to start at the top of the org tree. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-08-11 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.oua_force_order.sql: Unwrapped upgrade script for oua_force_order Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-08-11 Thomas Berezansky * Open-ILS/src/sql/Pg/020.schema.functions.sql: New version of actor.org_unit_ancestors Preserves order through joins Basically actor.org_unit_ancestors_distance with a join to get the entire org units, rather than just IDs and a distance. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-08-11 Liam Whalen * Open-ILS/src/perlmods/OpenILS/Application/Storage/QueryParser.pm: Fixed seaching for a colon (:) surrounded by white space When searching for a colon surrounded by white space the search would freeze. An example of such a search would be: Climate change economics and policy : an RFF anthology This was happening because the decompose function within QueryParser.pm Would build a regular expression that would search the query for both classes and class aliases e.g (keyword and kw). However, when buliding the regex for aliases QueryParser would add extraneous or symbols (|) to the end of the regex without adding the accompanying alias. This was happening because there was a check to see if the corresponding class to each alias had already been added to the regex. But, the check to see if the alias had already been appened to the regex happened too late. I have moved the check to encopase the appending of the or symbols and the class. Signed-off-by: Liam Whalen Signed-off-by: Mike Rylander 2011-08-09 Jason Stephenson * Open-ILS/src/extras/Makefile.install: Branchify patch from LP bug #802523 and backport to rel_2_0. Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-08-23 Dan Scott * Open-ILS/src/extras/Makefile.install: Add pgsql 9.0 target for Debian / Ubuntu, and a Fedora 15 target People are starting to adopt PostgreSQL 9.0 in Evergreen 2.0 as a stepping stone towards Evergreen 2.1; make it easier for them by providing a target in the 2.0 Makefile.install. Also, while we're in here, remove the Fedora 13 reference and replace it with Fedora 15, as Fedora 13 is no longer supported and Fedora 15 comes with the power of PostgreSQL 9.0. OH YEAH! Signed-off-by: Dan Scott 2011-08-23 Mike Rylander * Open-ILS/src/sql/Pg/000.english.pg90.fts-config.sql: Support Evergreen 2.0 on Pg 9.0 Signed-off-by: Mike Rylander 2011-08-19 Jason Etheridge * Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm: Fix penalty generation during billing creation by passing the editor object referencing the database transaction to xact_org Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-08-22 Lebbeous Fogle-Weekley * Open-ILS/web/opac/skin/default/js/holds.js: Display only available formats for metarecord holds in IE The OPAC's usual hideMe()/unHideMe() tricks don't work for