3 # A Class for hiding the ILS's concept of the patron from the OpenSIP
7 package OpenILS::SIP::Patron;
13 use Sys::Syslog qw(syslog);
15 use Digest::MD5 qw(md5_hex);
18 use OpenILS::Application::AppUtils;
19 use OpenILS::Application::Actor;
20 use OpenILS::Const qw/:const/;
21 use OpenSRF::Utils qw/:datetime/;
22 use DateTime::Format::ISO8601;
23 my $U = 'OpenILS::Application::AppUtils';
25 our (@ISA, @EXPORT_OK);
29 @EXPORT_OK = qw(invalid_patron);
36 my $patron_id = shift;
39 if ($key ne 'usr' and $key ne 'barcode') {
40 syslog("LOG_ERROR", "Patron (card) lookup requested by illegeal key '$key'");
44 unless(defined $patron_id) {
45 syslog("LOG_WARNING", "No patron ID provided to ILS::Patron->new");
49 my $type = ref($class) || $class;
50 my $self = bless({}, $type);
52 syslog("LOG_DEBUG", "OILS: new OpenILS Patron(%s => %s): searching...", $key, $patron_id);
54 my $e = OpenILS::SIP->editor();
55 # Pass the authtoken, if any, to the editor so that we can use it
56 # to fake a context org_unit for the csp.ignore_proximity in
57 # flesh_user_penalties, below.
58 unless ($e->authtoken()) {
59 $e->authtoken($args{authtoken}) if ($args{authtoken});
79 # in some cases, we don't need all of this data. Only fetch the user + barcode
80 $usr_flesh = {flesh => 1, flesh_fields => {au => ['card']}} if $args{slim_user};
83 if($key eq 'barcode') { # retrieve user by barcode
85 $$usr_flesh{flesh} += 1;
86 $$usr_flesh{flesh_fields}{ac} = ['usr'];
88 my $card = $e->search_actor_card([{barcode => $patron_id}, $usr_flesh])->[0];
90 if(!$card or !$U->is_true($card->active)) {
91 syslog("LOG_WARNING", "No such patron barcode: $patron_id");
98 $user = $e->retrieve_actor_user([$patron_id, $usr_flesh]);
101 if(!$user or $U->is_true($user->deleted)) {
102 syslog("LOG_WARNING", "OILS: Unable to find patron %s => %s", $key, $patron_id);
106 if(!$U->is_true($user->active)) {
107 syslog("LOG_WARNING", "OILS: Patron is inactive %s => %s", $key, $patron_id);
111 # now grab the user's penalties
113 $self->flesh_user_penalties($user, $e) unless $args{slim_user};
115 $self->{authtoken} = $args{authtoken} if $args{authtoken};
116 $self->{editor} = $e;
117 $self->{user} = $user;
118 $self->{id} = ($key eq 'barcode') ? $patron_id : $user->card->barcode; # The barcode IS the ID to SIP.
119 # We give back the passed barcode if the key was indeed a barcode, just to be safe. Otherwise pull it from the card.
121 syslog("LOG_DEBUG", "OILS: new OpenILS Patron(%s => %s): found patron : barred=%s, card:active=%s",
122 $key, $patron_id, $user->barred, $user->card->active );
124 $U->log_user_activity($user->id, $self->get_act_who, 'verify');
131 my $config = OpenILS::SIP->config();
132 my $login = OpenILS::SIP->login_account();
134 my $act_who = $config->{implementation_config}->{default_activity_who};
135 my $force_who = $config->{implementation_config}->{force_activity_who};
137 # 1. future: test sip extension for caller-provided ewho and !$force_who
139 # 2. See if the login is tagged with an ewho
140 return $login->{activity_who} if $login->{activity_who};
142 # 3. if all else fails, see if there is an institution-wide ewho
143 return $config->{activity_who} if $config->{activity_who};
148 # grab patron penalties. Only grab non-archived penalties that are for fines,
149 # excessive overdues, or otherwise block circluation activity
150 sub flesh_user_penalties {
151 my ($self, $user, $e) = @_;
153 # Use the ws_ou or home_ou of the authsession user, if any, as a
154 # context org_unit for the penalties and the csp.ignore_proximity.
156 if ($e->authtoken()) {
157 my $auth_usr = $e->checkauth();
159 $here = $auth_usr->ws_ou() || $auth_usr->home_ou();
163 # Get the "raw" list of user's penalties and flesh the
164 # standing_penalty field, so we can filter them based on
165 # csp.ignore_proximity.
167 $e->search_actor_user_standing_penalty([
172 # ignore "archived" penalties
173 {stop_date => undef},
174 {stop_date => {'>' => 'now'}}
182 transform => 'actor.org_unit_ancestors',
188 # Use "here" or user's home_ou.
189 where => {id => ($here) ? $here : $user->home_ou},
194 # in addition to fines and excessive overdue penalties,
195 # we only care about penalties that result in blocks
196 standing_penalty => {
198 select => {csp => ['id']},
202 {id => [1,2]}, # fines / overdues
203 {block_list => {'!=' => undef}}
211 flesh_fields => {ausp => ['standing_penalty']}
214 # We filter the raw penalties that apply into this array.
215 my $applied_penalties = [];
216 if (ref($raw_penalties) eq 'ARRAY' && @$raw_penalties) {
217 my $here_prox = ($here) ? $U->get_org_unit_proximity($e, $here, $user->home_ou())
219 # Filter out those that do not apply and deflesh the standing_penalty.
220 $applied_penalties = [map
221 { $_->standing_penalty($_->standing_penalty->id()) }
223 !defined($_->standing_penalty->ignore_proximity())
224 || ((defined($here_prox))
225 ? $_->standing_penalty->ignore_proximity() < $here_prox
226 : $_->standing_penalty->ignore_proximity() <
227 $U->get_org_unit_proximity($e, $_->org_unit(), $user->home_ou()))
230 $user->standing_penalties($applied_penalties);
240 return format_name($self->{user});
245 return OpenILS::SIP::clean_text(
247 ($u->first_given_name || ''),
248 ($u->second_given_name || ''),
249 ($u->family_name || '')));
254 my $lib = OpenILS::SIP::shortname_from_id($self->{user}->home_ou);
255 syslog('LOG_DEBUG', "OILS: Patron->home_library() = $lib");
261 return "" unless $addr;
262 my $return = OpenILS::SIP::clean_text(
263 join( ' ', map {$_ || ''} (
274 $return =~ s/\s+/ /sg; # Compress any run of of whitespace to one space
280 return $self->{user}->id;
285 my $u = $self->{user};
286 my $str = __addr_string($u->billing_address || $u->mailing_address);
287 syslog('LOG_DEBUG', "OILS: Patron address: $str");
293 return OpenILS::SIP::clean_text($self->{user}->email);
298 return $self->{user}->day_phone;
303 my $dob = OpenILS::SIP->format_date($self->{user}->dob, 'dob');
304 syslog('LOG_DEBUG', "OILS: Patron DOB = $dob");
310 my $expire = OpenILS::SIP->format_date($self->{user}->expire_date);
311 syslog('LOG_DEBUG', "OILS: Patron Expire = $expire");
318 my $use_code = OpenILS::SIP->get_option_value('patron_type_uses_code') || '';
320 # should we use the no_i18n version of patron profile name (as a 'code')?
321 return $self->{editor}->retrieve_permission_grp_tree(
322 [$self->{user}->profile->id, {no_i18n => 1}])->name
323 if $use_code =~ /true/io;
325 return OpenILS::SIP::clean_text($self->{user}->profile->name);
330 return '000'; # Unspecified
333 # How much more detail do we need to check here?
334 # sec: adding logic to return false if user is barred, has a circulation block
338 my $u = $self->{user};
340 # compute expiration date for borrowing privileges
341 my $expire = DateTime::Format::ISO8601->new->parse_datetime(cleanse_ISO8601($u->expire_date));
343 # determine whether patron should be allowed to circulate materials:
344 # not barred, doesn't owe too much wrt fines/fees, privileges haven't
346 my $circ_is_blocked =
347 (($u->barred eq 't') or
348 ($u->standing_penalties and @{$u->standing_penalties}) or
349 (CORE::time > $expire->epoch));
352 !$circ_is_blocked and
353 $u->active eq 't' and
354 $u->card->active eq 't';
359 # How much more detail do we need to check here?
362 return $self->charge_ok;
367 return $self->charge_ok if
368 OpenILS::SIP->get_option_value('patron_calculate_recal_ok');
374 return $self->charge_ok;
377 # return true if the card provided is marked as lost
380 return $self->{user}->card->active eq 'f';
383 sub recall_overdue { # not implemented
389 my ($self, $pwd) = @_;
390 syslog('LOG_DEBUG', 'OILS: Patron->check_password()');
391 return 0 unless (defined $pwd and $self->{user});
392 return $U->verify_migrated_user_password(
393 $self->{editor},$self->{user}->id, $pwd);
396 sub currency { # not really implemented
398 syslog('LOG_DEBUG', 'OILS: Patron->currency()');
404 syslog('LOG_DEBUG', 'OILS: Patron->fee_amount()');
405 my $user_id = $self->{user}->id;
407 my $e = $self->{editor};
409 my $summary = $e->retrieve_money_open_user_summary($user_id);
410 $e->rollback; # xact_rollback + disconnect
412 my $total = ($summary) ? $summary->balance_owed : 0;
413 syslog('LOG_INFO', "User ".$self->{id} .":$user_id has a fee amount of \$$total");
419 my $u = $self->{user};
421 return 'barred' if $u->barred eq 't';
425 return $b if $u->active eq 'f';
426 return $b if $u->card->active eq 'f';
428 # if we have any penalties at this point, they are blocking penalties
429 return $b if $u->standing_penalties and @{$u->standing_penalties};
431 # has the patron account expired?
432 my $expire = DateTime::Format::ISO8601->new->parse_datetime(cleanse_ISO8601($u->expire_date));
433 return $b if CORE::time > $expire->epoch;
438 sub print_line { # not implemented
443 sub too_many_charged { # not implemented
448 sub too_many_overdue {
450 return scalar( # PATRON_EXCEEDS_OVERDUE_COUNT
451 grep { $_ == OILS_PENALTY_PATRON_EXCEEDS_OVERDUE_COUNT } @{$self->{user}->standing_penalties}
455 # not completely sure what this means
456 sub too_many_renewal {
461 # not relevant, handled by fines/fees
462 sub too_many_claim_return {
467 # not relevant, handled by fines/fees
473 sub excessive_fines {
475 return scalar( # PATRON_EXCEEDS_FINES
476 grep { $_ == OILS_PENALTY_PATRON_EXCEEDS_FINES } @{$self->{user}->standing_penalties}
480 # Until someone suggests otherwise, fees and fines are the same
484 return $self->excessive_fines;
487 # not relevant, handled by fines/fees
488 sub too_many_billed {
496 # List of outstanding holds placed
499 my ($self, $start, $end, $ids_only) = @_;
500 syslog('LOG_DEBUG', 'OILS: Patron->hold_items()');
503 # all of my open holds
504 my $holds = $self->{editor}->search_action_hold_request({
505 usr => $self->{user}->id,
506 fulfillment_time => undef,
510 return $holds if $ids_only;
511 return $self->__format_holds($holds, $start, $end);
515 my ($self, $start, $end, $ids_only) = @_;
516 syslog('LOG_DEBUG', 'OILS: Patron->unavail_holds()');
518 my $holds = $self->{editor}->search_action_hold_request({
519 usr => $self->{user}->id,
520 fulfillment_time => undef,
521 cancel_time => undef,
523 {current_shelf_lib => undef},
524 {current_shelf_lib => {'!=' => {'+ahr' => 'pickup_lib'}}}
528 return $holds if $ids_only;
529 return $self->__format_holds($holds, $start, $end);
535 my ($self, $holds, $start, $end) = @_;
537 return [] unless @$holds;
539 my $return_datatype =
540 OpenILS::SIP->get_option_value('msg64_hold_datatype') || '';
544 for my $hold (@$holds) {
546 if ($return_datatype eq 'barcode') {
548 if (my $copy = $self->find_copy_for_hold($hold)) {
549 push(@response, $copy->barcode);
552 syslog('LOG_WARNING',
553 'OILS: No representative copy found for hold ' . $hold->id);
558 OpenILS::SIP::clean_text($self->__hold_to_title($hold)));
562 return (defined $start and defined $end) ?
563 [ @response[($start-1)..($end-1)] ] :
567 # Finds a representative copy for the given hold.
568 # If no copy exists at all, undef is returned.
569 # The only limit placed on what constitutes a
570 # "representative" copy is that it cannot be deleted.
571 # Otherwise, any copy that allows us to find the hold
572 # later is good enough.
573 sub find_copy_for_hold {
574 my ($self, $hold) = @_;
575 my $e = $self->{editor};
577 return $e->retrieve_asset_copy($hold->current_copy)
578 if $hold->current_copy;
580 return $e->retrieve_asset_copy($hold->target)
581 if $hold->hold_type =~ /C|R|F/;
583 return $e->search_asset_copy([
584 {call_number => $hold->target, deleted => 'f'},
585 {limit => 1}])->[0] if $hold->hold_type eq 'V';
587 my $bre_ids = [$hold->target];
589 if ($hold->hold_type eq 'M') {
590 # find all of the bibs that link to the target metarecord
591 my $maps = $e->search_metabib_metarecord_source_map(
592 {metarecord => $hold->target});
593 $bre_ids = [map {$_->record} @$maps];
596 my $vol_ids = $e->search_asset_call_number(
597 {record => $bre_ids, deleted => 'f'},
601 return $e->search_asset_copy([
602 {call_number => $vol_ids, deleted => 'f'},
607 # Given a "representative" copy, finds a matching hold
608 sub find_hold_from_copy {
609 my ($self, $barcode) = @_;
610 my $e = $self->{editor};
613 my $copy = $e->search_asset_copy([
614 {barcode => $barcode, deleted => 'f'},
615 {flesh => 1, flesh_fields => {acp => ['call_number']}}
618 return undef unless $copy;
620 my $run_hold_query = sub {
622 return $e->search_action_hold_request([
623 { usr => $self->{user}->id,
624 cancel_time => undef,
625 fulfillment_time => undef,
629 order_by => {ahr => 'request_time DESC'}
634 # first see if there is a match on current_copy
635 return $hold if $hold =
636 $run_hold_query->(current_copy => $copy->id);
638 # next, assume bib-level holds are the most common
639 return $hold if $hold = $run_hold_query->(
640 target => $copy->call_number->record, hold_type => 'T');
642 # next try metarecord holds
643 my $map = $e->search_metabib_metarecord_source_map(
644 {source => $copy->call_number->record})->[0];
646 return $hold if $hold = $run_hold_query->(
647 target => $map->metarecord, hold_type => 'M');
650 return $hold if $hold = $run_hold_query->(
651 target => $copy->call_number->id, hold_type => 'V');
654 return $run_hold_query->(
655 target => $copy->id, hold_type => ['C', 'F', 'R']);
658 sub __hold_to_title {
661 my $e = $self->{editor};
663 my( $id, $mods, $title, $volume, $copy );
665 return __copy_to_title($e,
666 $e->retrieve_asset_copy($hold->target))
667 if $hold->hold_type eq 'C' or $hold->hold_type eq 'F' or $hold->hold_type eq 'R';
669 return __volume_to_title($e,
670 $e->retrieve_asset_call_number($hold->target))
671 if $hold->hold_type eq 'V';
673 return __record_to_title(
674 $e, $hold->target) if $hold->hold_type eq 'T';
676 return __metarecord_to_title(
677 $e, $hold->target) if $hold->hold_type eq 'M';
680 sub __copy_to_title {
681 my( $e, $copy ) = @_;
682 #syslog('LOG_DEBUG', "OILS: copy_to_title(%s)", $copy->id);
683 return $copy->dummy_title if $copy->call_number == -1;
685 my $vol = (ref $copy->call_number) ?
687 $e->retrieve_asset_call_number($copy->call_number);
689 return __volume_to_title($e, $vol);
693 sub __volume_to_title {
694 my( $e, $volume ) = @_;
695 #syslog('LOG_DEBUG', "OILS: volume_to_title(%s)", $volume->id);
696 return __record_to_title($e, $volume->record);
700 sub __record_to_title {
701 my( $e, $title_id ) = @_;
702 #syslog('LOG_DEBUG', "OILS: record_to_title($title_id)");
703 my $mods = $U->simplereq(
705 'open-ils.search.biblio.record.mods_slim.retrieve', $title_id );
706 return ($mods) ? $mods->title : "";
709 sub __metarecord_to_title {
710 my( $e, $m_id ) = @_;
711 #syslog('LOG_DEBUG', "OILS: metarecord_to_title($m_id)");
712 my $mods = $U->simplereq(
714 'open-ils.search.biblio.metarecord.mods_slim.retrieve', $m_id);
715 return ($U->event_code($mods)) ? "<unknown>" : $mods->title;
720 # remove the hold on item item_id from my hold queue.
721 # return true if I was holding the item, false otherwise.
724 my ($self, $item_id) = @_;
728 sub __patron_items_info {
730 return if $self->{item_info};
732 OpenILS::Application::Actor::_checked_out(
733 0, $self->{editor}, $self->{user}->id);;
739 my ($self, $start, $end, $ids_only) = @_;
741 $self->__patron_items_info();
742 my @overdues = @{$self->{item_info}->{overdue}};
743 #$overdues[$_] = __circ_to_title($self->{editor}, $overdues[$_]) for @overdues;
745 return \@overdues if $ids_only;
748 syslog('LOG_DEBUG', "OILS: overdue_items() fleshing circs @overdues");
750 my $return_datatype = OpenILS::SIP->get_option_value('msg64_summary_datatype') || '';
752 for my $circid (@overdues) {
754 if($return_datatype eq 'barcode') {
755 push( @o, __circ_to_barcode($self->{editor}, $circid));
757 push( @o, OpenILS::SIP::clean_text(__circ_to_title($self->{editor}, $circid)));
762 return (defined $start and defined $end) ?
763 [ @overdues[($start-1)..($end-1)] ] : \@overdues;
766 sub __circ_to_barcode {
769 $circ = $e->retrieve_action_circulation($circ);
770 my $copy = $e->retrieve_asset_copy($circ->target_copy);
771 return $copy->barcode;
774 sub __circ_to_title {
775 my( $e, $circ ) = @_;
777 $circ = $e->retrieve_action_circulation($circ);
778 return __copy_to_title( $e,
779 $e->retrieve_asset_copy($circ->target_copy) );
783 my ($self, $start, $end, $ids_only) = shift;
784 return $self->charged_items_impl($start, $end, undef, $ids_only);
787 # implementation method
788 # force_bc -- return barcode data regardless of msg64_summary_datatype;
789 # this is used by the renew-all code
790 sub charged_items_impl {
791 my ($self, $start, $end, $force_bc, $ids_only) = shift;
793 $self->__patron_items_info();
796 @{$self->{item_info}->{out}},
797 @{$self->{item_info}->{overdue}}
800 #$charges[$_] = __circ_to_title($self->{editor}, $charges[$_]) for @charges;
802 return \@charges if $ids_only;
805 syslog('LOG_DEBUG', "OILS: charged_items() fleshing circs @charges");
807 my $return_datatype = OpenILS::SIP->get_option_value('msg64_summary_datatype') || '';
809 for my $circid (@charges) {
811 if($return_datatype eq 'barcode' or $force_bc) {
812 push( @c, __circ_to_barcode($self->{editor}, $circid));
814 push( @c, OpenILS::SIP::clean_text(__circ_to_title($self->{editor}, $circid)));
820 return (defined $start and defined $end) ?
821 [ @charges[($start-1)..($end-1)] ] :
826 my ($self, $start, $end, $ids_only) = @_;
829 my $xacts = $U->simplereq('open-ils.actor', 'open-ils.actor.user.transactions.history.have_balance', $self->{authtoken}, $self->{user}->id);
830 foreach my $xact (@{$xacts}) {
835 my $line = $xact->balance_owed . " " . $xact->last_billing_type . " ";
836 if ($xact->xact_type eq 'circulation') {
837 my $mods = $U->simplereq('open-ils.circ', 'open-ils.circ.circ_transaction.find_title', $self->{authtoken}, $xact->id);
838 $line .= $mods->title . ' / ' . $mods->author;
840 $line .= $xact->last_billing_note;
842 push @fines, OpenILS::SIP::clean_text($line);
845 my $log_status = $@ ? 'ERROR: ' . $@ : 'OK';
846 syslog('LOG_DEBUG', 'OILS: Patron->fine_items() ' . $log_status);
847 return (defined $start and defined $end) ?
848 [ @fines[($start-1)..($end-1)] ] : \@fines;
851 # not currently supported
853 my ($self, $start, $end, $ids_only) = @_;
858 my ($self, $card_retained, $blocked_card_msg) = @_;
859 $blocked_card_msg ||= '';
861 my $e = $self->{editor};
862 my $u = $self->{user};
864 syslog('LOG_INFO', "OILS: Blocking user %s", $u->card->barcode );
866 return $self if $u->card->active eq 'f';
868 $e->xact_begin; # connect and start a new transaction
870 $u->card->active('f');
871 if( ! $e->update_actor_card($u->card) ) {
872 syslog('LOG_ERR', "OILS: Block card update failed: %s", $e->event->{textcode});
873 $e->rollback; # rollback + disconnect
877 # retrieve the un-fleshed user object for update
878 $u = $e->retrieve_actor_user($u->id);
879 my $note = OpenILS::SIP::clean_text($u->alert_message) || "";
880 $note = "<sip> CARD BLOCKED BY SELF-CHECK MACHINE. $blocked_card_msg</sip>\n$note"; # XXX Config option
881 $note =~ s/\s*$//; # kill trailng whitespace
882 $u->alert_message($note);
884 if( ! $e->update_actor_user($u) ) {
885 syslog('LOG_ERR', "OILS: Block: patron alert update failed: %s", $e->event->{textcode});
886 $e->rollback; # rollback + disconnect
891 $self->{user}->alert_message( $note );
893 $e->commit; # commits and disconnects
897 # Testing purposes only
899 my ($self, $card_retained) = @_;
900 $self->{screen_msg} = "All privileges restored.";
902 # Un-mark card as inactive, grep out the patron alert
903 my $e = $self->{editor};
904 my $u = $self->{user};
906 syslog('LOG_INFO', "OILS: Unblocking user %s", $u->card->barcode );
908 return $self if $u->card->active eq 't';
910 $e->xact_begin; # connect and start a new transaction
912 $u->card->active('t');
913 if( ! $e->update_actor_card($u->card) ) {
914 syslog('LOG_ERR', "OILS: Unblock card update failed: %s", $e->event->{textcode});
915 $e->rollback; # rollback + disconnect
919 # retrieve the un-fleshed user object for update
920 $u = $e->retrieve_actor_user($u->id);
921 my $note = OpenILS::SIP::clean_text($u->alert_message) || "";
922 $note =~ s#<sip>.*</sip>##;
923 $note =~ s/^\s*//; # kill leading whitespace
924 $note =~ s/\s*$//; # kill trailng whitespace
925 $u->alert_message($note);
927 if( ! $e->update_actor_user($u) ) {
928 syslog('LOG_ERR', "OILS: Unblock: patron alert update failed: %s", $e->event->{textcode});
929 $e->rollback; # rollback + disconnect
934 $self->{user}->alert_message( $note );
936 $e->commit; # commits and disconnects
945 return "Please contact library staff";
949 return "Please contact library staff";
952 sub inet_privileges {
954 my $e = OpenILS::SIP->editor();
955 $INET_PRIVS = $e->retrieve_all_config_net_access_level() unless $INET_PRIVS;
956 my ($level) = grep { $_->id eq $self->{user}->net_access_level } @$INET_PRIVS;
957 my $name = OpenILS::SIP::clean_text($level->name);
958 syslog('LOG_DEBUG', "OILS: Patron inet_privs = $name");
964 my $extra_fields = {};
965 my $u = $self->{user};
966 foreach my $stat_cat_entry (@{$u->stat_cat_entries}) {
967 my $stat_cat = $stat_cat_entry->stat_cat;
968 next unless ($stat_cat->sip_field);
969 my $value = $stat_cat_entry->stat_cat_entry;
970 if(defined $stat_cat->sip_format && length($stat_cat->sip_format) > 0) { # Has a format string?
971 if($stat_cat->sip_format =~ /^\|(.*)\|$/) { # Regex match?
972 if($value =~ /($1)/) { # If we have a match
973 if(defined $2) { # Check to see if they embedded a capture group
974 $value = $2; # If so, use it
976 else { # No embedded capture group?
977 $value = $1; # Use our outer one
981 $value = ''; # Empty string. Will be checked for below.
984 else { # Not a regex match - Try sprintf match (looking for a %s, if any)
985 $value = sprintf($stat_cat->sip_format, $value);
988 next unless length($value) > 0; # No value = no export
989 $value =~ s/\|//g; # Remove all lingering pipe chars for sane output purposes
990 $extra_fields->{ $stat_cat->sip_field } = [] unless (defined $extra_fields->{$stat_cat->sip_field});
991 push(@{$extra_fields->{ $stat_cat->sip_field}}, $value);
993 return $extra_fields;