LP#1612752 - Add cancel_time to action.transit_copy and friends. It is useful to have keep action.transit_copy rows intact when doing forensics on what happens after a staff member cancels a transit. Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1613374 - Check stored copy status before clobbering it. Some transit.copy_statuses would result in some other behavior upon checkin, so we check all that would go into 'Reshelving' status, otherwise, restore the stored status. Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1613374 - Set item status to 'Canceled Transit' when transit is canceled. I opened a separate bug report on this issue (bug 1613374) before realizing bug 1306666 was reported. This commit creates a new 'Canceled Transit' status that signals to staff what happened to an item when a transit is aborted/canceled. Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Conflicts: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Transit.pm Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP 1306666: Abort Transit Only Change Copy Status if In Transit When aborting a transit, the copy status is presently changed, either to the status stored in action.transit_copy or to Reshelving if the transit was for a hold. This causes problems with "hanging" transits where something was not handled properly before. We've had cases where a transit sticks around on a copy that is later checked out, and while that copy is checked out, the transit is aborted, thus setting the copy status to Reshelving when it should be Checked Out. The code change in this branch only changes the copy's status if it is In Transit. A copy in any other status has its status left untouched. Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP 1503867: Use ws_ou in open-ils.circ.copy_transit.receive. After putting NCIPServer into production, we discovered that a staff user cannot receive a transit destined for their work org. unit if the actor.usr.home_ou is not the same as their current work_ou. This occurred because transit_receive in OpenILS::Application:: Circ::Transit uses the requestor's home_ou and not the ws_ou. If you want to trigger this bug, write a little script to receive transits, then login with a staff account at a location other than their home_ou and try to receive a transit destined for the work_ou. It will fail. This small commit replaces home_ou in two places with ws_ou in order to make the above work. NOTE: This bug affects an API call not used in Evergreen except in one test script. It used in two ILL add-ons for Evergreen: issa and NCIPServer. Receiving transits by checking copies in via the staff client, the typical workflow, is not affected by this bug or its fix. Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP1198475: Add a new, optional, Lost and Paid copy status. Add the Lost and Paid status to config.copy_status. Add org_unit_settig to control if the copy status is used. Add checks to O::A::Circ::Money::make_payments to check for LOST status and org_unit setting and change the copy status to Lost and Paid as appropriate. Also add checks for Lost and Paid copy status wherever LOST copy status is used. Add the COPY_STATUS_LOST_AND_PAID event. Add the event to ils_events.xml with id 7026. Check for the event in circ/util.js in the staff client. Add pgTAP tests for the existence of the Lost and Paid copy status and the new org_unit setting to control if it isused. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Post-2.5-m1 whitespace fixup This is an attempt at an automated whitespace cleanup for the m1 milestone of version 2.5. It was created using the following commands (run from Open-ILS/src/perlmods/lib): find . -name "*.pm" \ -exec sh -c 'sed "/<</s/\t/ /g" < {} \ | expand -t 4 > {}.fixed ; \ cp --no-preserve=mode,ownership {}.fixed {}; \ rm {}.fixed' \; Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Fix in-transit hold retarget Tell the abort transit function to not commit our editor on us, basically. Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Add the session to Circ set_audit_info calls Because I apparently wasn't thinking about how I wrote the apputils piece when I added them. Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Call set_audit_info and clear_audit_info DB funcs Set whenever we can (including automatically via pcrud) Clear whenever we disconnect (hopefully) from a location we set from. Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Permission to allow transit abort on lost/missing This patch introduces a permission that allows staff to abort transits for items in the lost/missing status. Previous, this was disallowed by a hard-coded block. Signed-off-by: Bill Erickson <berick@esilibrary.com>
Make Evergreen Perl modules installable via Module::Build to match OpenSRF Build.PL gives us an install-time check on dependencies; right now the required versions are not set, but we can update these easily to start catching some of the problematic modules that have tripped sites up in the past. Build.PL really seems to want a top-level "OpenILS.pm" so add a placeholder accordingly. Adjust references to /src/perlmods/ to /src/perlmods/lib/ even though a number of the affected scripts are probably cruft. Use autoconf to provide the default paths in O:WWW:Web and O:WWW:Method; next step is probably to teach autoconf to ask Build.PL to do that for us to make the OpenILS Perl modules more independent. git-svn-id: svn://svn.open-ils.org/ILS/trunk@19340 dcc99617-32d9-48b4-a31d-7c20da2025e4