Make Evergreen Perl modules installable via Module::Build to match OpenSRF Build.PL gives us an install-time check on dependencies; right now the required versions are not set, but we can update these easily to start catching some of the problematic modules that have tripped sites up in the past. Build.PL really seems to want a top-level "OpenILS.pm" so add a placeholder accordingly. Adjust references to /src/perlmods/ to /src/perlmods/lib/ even though a number of the affected scripts are probably cruft. Use autoconf to provide the default paths in O:WWW:Web and O:WWW:Method; next step is probably to teach autoconf to ask Build.PL to do that for us to make the OpenILS Perl modules more independent. git-svn-id: svn://svn.open-ils.org/ILS/trunk@19340 dcc99617-32d9-48b4-a31d-7c20da2025e4
If an item is captured for a hold, but not in transit (i.e. on holds shelf), set the destination_location equal to the pickup library (i.e where it's supposedly on the shelf). This is useful for autmated sorting so that the item will return to the branch whose shelf where it belongs. git-svn-id: svn://svn.open-ils.org/ILS/trunk@18351 dcc99617-32d9-48b4-a31d-7c20da2025e4
added support for returning hold shelf expire time (CM field) in item info response when an item has been captured for a hold. value is populated if item is on holds shelf or in transit to holds shelf git-svn-id: svn://svn.open-ils.org/ILS/trunk@17354 dcc99617-32d9-48b4-a31d-7c20da2025e4
combine circ and user fetch into 1 cstore call for SIP items. minor cleanup git-svn-id: svn://svn.open-ils.org/ILS/trunk@17137 dcc99617-32d9-48b4-a31d-7c20da2025e4
repaired circ-mod retrieval call to use retrieve instead of search git-svn-id: svn://svn.open-ils.org/ILS/trunk@17121 dcc99617-32d9-48b4-a31d-7c20da2025e4
add collection code as non-i18n version of shelving location git-svn-id: svn://svn.open-ils.org/ILS/trunk@17005 dcc99617-32d9-48b4-a31d-7c20da2025e4
SIP Callnumber extensions, POD Use org_unit shortname everywhere, no owning_lib. Checkin response and Item Info response now return callnumber w/ current SIP code. git-svn-id: svn://svn.open-ils.org/ILS/trunk@16789 dcc99617-32d9-48b4-a31d-7c20da2025e4
Bugfixes: undef handling and legacy script support setting. The legacy setting was a major bug. It was not possible to disable legacy scripts except by *removing* the setting. That is, if you set it to 'false', we failed to interpret that here in SIP to mean FALSE. Instead we looked at it as a non-zero-length string and therefore TRUE! This patch also prevents warnings from unitialized values (undef concatenation), like: Use of uninitialized value in concatenation (.) or string at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 110. Added a little formatting and whitespace cleanup to address display along w/ undef handling. Corrected an error screen message also. git-svn-id: svn://svn.open-ils.org/ILS/trunk@16600 dcc99617-32d9-48b4-a31d-7c20da2025e4
Checkin overhual for extensions, including item, patron and checkin underpinnings. Extensions fields added to AUTOLOADable content. Also fix checkin logic to check for NO_CHANGE and SUCCESS at necessary moments. Update new code to match berick's #16544. Add AUTOLOAD to Item and provide a slot to store the raw EG hold object. Store the hold data down on the item (not the Checkin transaction level). Allow SIP Patron lookup by usr ID (not barcode). This is important because we need supplemental data when we find holds info at checkin. The change is backwards compatible (w/ just 1 arg it will still be treated as a barcode). Propagate $inst_id down into checkout core, needed for hold routing logic. Remove old accessor methods, also make some of the settings checks more flexible w/ regex. git-svn-id: svn://svn.open-ils.org/ILS/trunk@16599 dcc99617-32d9-48b4-a31d-7c20da2025e4
Lots of cleanup, logging improvements, and comments. One arrayref accessor updated to recommended style Removed unused dependency. Removed never-possible return statement. Trying to use an arrayref in the log message results in a string like "ARRAY(0x2541870)". I added a prebuilt string representation of the array for use in those messages. More whitespace cleanup. More flexible to_bool, extra comments; Also added institution_id method. Note: OpenILS::Event->new returns a hash, not a true object. script_x_check.sh is executable. Irony: this script could have been used to detect itself. Typo in Cronscript POD. Signed-off-by: Joe Atzberger <atz@esilibrary.com> git-svn-id: svn://svn.open-ils.org/ILS/trunk@16597 dcc99617-32d9-48b4-a31d-7c20da2025e4
patch from James Fournie to repair some faulty assumptions in the previous legacy script SIP fix; additionally, I added legacy_script_support override option to oils_sip.xml.exmple to allow use of in-db circ-mod configs even if the circ code is still using circ scritps git-svn-id: svn://svn.open-ils.org/ILS/trunk@16404 dcc99617-32d9-48b4-a31d-7c20da2025e4
updated SIP server to pull item config info from the new circ_modifier table when legacy script support is disabled git-svn-id: svn://svn.open-ils.org/ILS/trunk@16381 dcc99617-32d9-48b4-a31d-7c20da2025e4
Enable the SIP server to speak UTF8 or ASCII, defaulting to ASCII Some SIP clients have implemented UTF8 support, and it is desirable to avoid mangling non-ASCII characters when possible, so a new <encoding> option in the SIPServer config file enables sites to specify an alternate encoding (such as "utf8"). The example oils_sip.xml file will continue to default to ASCII, and if no <encoding> option is supplied in the config file, ASCII will be the default. In addition, this patch improves the ASCII option by applying the ASCII mangling to all text fields, as well as ensuring that the incoming data is in Normalization Form D mode to make the mangling work cleanly. Other encodings such as iso-8859-1 can be specified, but to properly handle other encodings a transliteration phase would have to be added to the OpenILS::SIP::clean_text()... git-svn-id: svn://svn.open-ils.org/ILS/trunk@15260 dcc99617-32d9-48b4-a31d-7c20da2025e4
we've seen sip clients in the field that do not handle unicode very well. until we track down the problem, strip the 'wide characters' from the title string git-svn-id: svn://svn.open-ils.org/ILS/trunk@11975 dcc99617-32d9-48b4-a31d-7c20da2025e4
copying the item-config into the result object. fixed bug in capturing item config info in SIP msg git-svn-id: svn://svn.open-ils.org/ILS/trunk@9853 dcc99617-32d9-48b4-a31d-7c20da2025e4
updated due-dates format to conform with vendors - still need to decide if the hour/min/second part should be pushed to the end of the day (23:59:59) since that is more accurate git-svn-id: svn://svn.open-ils.org/ILS/trunk@6419 dcc99617-32d9-48b4-a31d-7c20da2025e4
disconnecting cstore handle in due_date method after forcing transaction git-svn-id: svn://svn.open-ils.org/ILS/trunk@6175 dcc99617-32d9-48b4-a31d-7c20da2025e4
forcing connected cstore editor since sane attempts failed git-svn-id: svn://svn.open-ils.org/ILS/trunk@6157 dcc99617-32d9-48b4-a31d-7c20da2025e4
fixed the due_date method to always return due date if any open circ exists added some logging git-svn-id: svn://svn.open-ils.org/ILS/trunk@6125 dcc99617-32d9-48b4-a31d-7c20da2025e4
making path an array.. git-svn-id: svn://svn.open-ils.org/ILS/trunk@5997 dcc99617-32d9-48b4-a31d-7c20da2025e4