LP2023803 Use gray buttons for modal Cancel actions Changes .btn-warning to .btn-normal for all modal dialog Cancel actions. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1991103: incorporate feedback from review, address failing test * Remove icon from tab * Don't use warning styling * Add spacing between the tab title and its number * Make the test amenable to any number of spaces between the tab title and number; it doesn't really matter how many there are, but there needs to be at least one. Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1991103: Display a count of record notes in the staff catalog tab To test: 1. Apply this patch. 2. Open a record in the staff catalog. 3. Add some record notes. Note that the tab updates with the number of record notes on the record. 4. Delete some record notes. Note that the tab still updates accordingly. 5. Leave and come back to the record. Note that the number still persists in that tab. Release-Note: Show the total number of record notes in the Record Note tab in the staff catalog. Sponsored-by: PaILS Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2052960 Remove button markup from record actions Removes errant <button> elements that were nested inside the Patron View and Place Hold links (in the bib record actions row of buttons below the summary box). Buttons inside links are unnecessary and created an extra tab stop when navigating the page via keyboard. Classes have been moved to the <a> element to retain styling. Release-note: Remove extra tab stops when navigating bib record actions in staff client using keyboard Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1939162: add option to clear added content cache to Angular staff catalog This patch restores the ability to clear the added content cache to the staff catalog by adding a "Clear Added Content Cache" item to the Other Actions menu on the Angular staff catalog record page. As with the former embedded staff catalog, clearing the added content cache does not result in the staff catalog attempting to automaticaly reload the cover image; the user will still need to reload the page to see if the change has taken effect. Improving that behavior would be for a separate bug. This patch also includes a fix to tag an unrelated string for localization. To test ------- [1] Ensure that at an added content handler is active. [2] Install the patch. [3] Navigate to a bib record in the Angular staff catalog. [4] Observe that there is a Clear Added Content Cache item in the Other Actions menu. [5] Click it and note that a toast stating that the cache was cleared is displayed. [6] (extra credit) Test while making changes to the record (say to the ISBN) that would result in a different cover image being provided by the added content source. [7] (extra credit) Update opensrf.xml to remove the added content handler, restart services and Apache, then try the cache-clearing action. This time, toast should be displayed stating that the action failed. Release-note: Adds a "Clear Added Content Cache" item to the Other Actions menu in the staff catalog record page. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2019207 Patron View Discovery Layer URL A new org unit setting configures the discovery layer URL opened by the Patron View button on a staff catalog record. The placeholder to include for the record ID is {eg_record_id}. Example format: https://example.com/Record/{eg_record_id} Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1850473 Fix button type lint errors Sets the type attribute on buttons where it was previously missing. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473: manual and automated eslint fixes Automatic fixes from `npm run lint -- --fix` Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2044004 Button styles for holdings view locations Corrects the link-button styles in the Locations/Barcode column of the Holdings View tab in the staff catalog. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2043899 Revised org select field labels Reverses course on the new label strategy introduced in bug 1999158, which proved incompatible with some components with user-configurable labels (e.g. patron edit). Rather than introducing a <label> tag by default, we now use the more familiar ARIA label strategy in places where the field does not have a visible label. We will need to revisit these, as all form fields should have visible labels per WCAG, but the ARIA label serves to resolve the immediate problem for screen reader users. Affects all uses of <eg-org-select> and <eg-org-family-select>. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2042358 Restore result pagination link padding Restores the record search result pagination link button padding lost in the changes for bug 1615714. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2039483 Subheadings for staff catalog record page Adds headings level 2, 3, and 4 to the staff catalog's individual record page to facilitate better in-page navigation for screen reader users. Styles have been added to negate the font styles usually applied to headings, so the page is visually unchanged. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Ruth Davis <rfrasur@library.in.gov> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2017673: Default item alert types Also, fix two accessibility issues that nightwatch/axe found To test: 1. Open your favorite bib record in the angular staff catalog 2. In the item table, choose an item and press Edit 3. Open the Preferences Tab 4. Under the Item Attribute Settings heading, select your favorite item alert type as the default 5. Open the Item Attributes tab. 6. Press the Item Alerts button. 7. Note that your favorite item alert type is now the default. 8. Add various alerts, with a variety of alert types. 9. Press the Apply Changes button. 10. Press the "Apply All, Save & Exit" button 11. Press Edit again 12. Press the Item Alerts button again. 13. Confirm that the correct item alert types are listed. Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1999158 Form labels for eg-org-select component Adds input directives to <eg-org-select> to support <label> tags with various options. Label tags are included alongside inputs unless explicitly suppressed. Where a visible label would disrupt the current layout, the "visually-hidden" CSS class may be used to hide the label visually while leaving it available to screen readers. All current instances of <eg-org-select> have been updated. Where labels already existed, those with specific layout requirements have been adjusted only to add missing "for" attributes, and the component's automatic output is suppressed with "visually-hidden". While this sometimes results in two <label> tags being present in the DOM, this is valid and doesn't cause any issues. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2016343 Updated aria-describedby for item table Adds an aria-describedby for the View link; changes the Edit Call Number link to use the call number label instead of the barcode. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2016343 aria-describedby for item table links Adds aria-describedby attributes to repetitive links in the staff catalog items table. This appends the barcode to the text of the link for screen readers, to help disambiguate links for different items. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1991294 Staff NoveList Select Added Content tab Adds a new tab, Added Content, to the staff catalog record view to display content from NoveList Select. If added content is available for the current record, the tab name will include a gold star; otherwise the tab indicates "No Added Content" with an empty star outline. This general framework can be used to support other added content services in the future. Because NoveList Select depends on an external JavaScript file to load its data, this update includes a new script loading service and a script store containing the names and paths of scripts that may be loaded into the Angular interfaces. In addition to the NoveList Select script provided by EBSCO, there is a helper script to insert it into the Added Content tab panel and adjust the progress, success, and error messages (both visible and ARIA live regions). New OU settings are provided for the NoveList Select staff credentials (which are passed as URL parameters to the external script) and and a new Library Setting that can be used to override the script store's URL in case of future breaking changes to the service. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1615714 Accessible names for Material Icons Adds ARIA labels or hidden text, as appropriate, to ensure that Material Icons are announced to screen reader users in a sensible way rather than having the icon keyword read as if it were normal text. In buttons containing an icon with no text, both ARIA labels and title attributes are used so that the tooltip matches the button's accessible name. This helps sighted users of dictation software identify the button's name. The icon keyword is hidden from screen readers with the aria-hidden attribute. In buttons with both an icon and text, the icon keyword is hidden from screen readers. Where icons appeared in inline text rather than a button or link, a visually-hidden span has been added to mirror the existing title attribute (tooltip), unless the icon was purely decorative. As part of this cleanup, several <a click()> elements were identified that had not already been addressed in other bug reports related to keyboard navigation support. These have been changed to <button>, and button types have been specified throughout. Other small role and alt text errors identified by the Axe linter have also been corrected. Note that this branch does not include labels for the grid flair icons (bug 1818086) or the grid actions toolbar (bug 1833726), which are being addressed separately. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
LP2008918: use new default colors for modal headers Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>