git.evergreen-ils.org Git - Evergreen.git/atom - Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html history Evergreen ILS https://git.evergreen-ils.org/?p=Evergreen.git Evergreen Project static/git-favicon.png static/git-logo.png 2023-12-04T19:41:19Z gitweb LP1850473 Fix button type lint errors 2023-11-15T17:58:57Z Stephanie Leary stephanie.leary@equinoxoli.org Terran McCanna tmccanna@georgialibraries.org 2023-11-15T17:58:57Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a5cd7fe3dfa59a9d017d06f8c2b77515f3b340fa
LP1850473 Fix button type lint errors

Sets the type attribute on buttons where it was previously missing.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP2000482 Angular 15 and Bootstrap 5 upgrade 2022-12-26T17:06:09Z Bill Erickson berickxx@gmail.com Galen Charlton gmc@equinoxOLI.org 2022-12-26T17:06:09Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c76e4ad6c2aba1a918992659686bb6b50bfea79c
LP2000482 Angular 15 and Bootstrap 5 upgrade

Includes numerous markup and CSS adjustments to cope with Bootstrap 5.

This patch is a squash of patches authored by Bill Erickson
and Stephanie Leary.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP1948693 Migrate from NgbTabset to ngbNav 2022-10-19T20:49:41Z Stephanie Leary stephanie.leary@equinoxOLI.org Bill Erickson berickxx@gmail.com 2022-10-19T20:49:41Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=365e6c38f52029e9c4464c277f81d1747b9cf9c5
LP1948693 Migrate from NgbTabset to ngbNav

Updates the deprecated NgbTabset components to ngbNav and adds directive
for keyboard navigation.

See https://gist.github.com/stephanieleary/800b9f2b1d9c08cc66d694daaa1788b9 for
a quick guide to the markup changes involved.

Screens to test:

1. /staff/acq/provider, right click an existing provider to show details tabs
2. /staff/admin/local/negative-balances
3. /staff/admin/local/action/survey, edit an existing survey, test Edit Survey
and Q&A tabs
4. /staff/admin/server/actor/org_unit, note that Addresses tab has a second set
of tabs underneath
5. /staff/admin/server/actor/org_unit_type, note that eg-tree has also changed
here
6. /staff/admin/server/permission/grp_tree, choose a group to see tabs
7. /staff/admin/server/config/print_template
8. /staff/booking/create_reservation
9. /staff/booking/manage_reservations, filter reservations section
10. /staff/booking/return
11. /staff/cat/authority/browse
12. /staff/cat/vandelay/import and all import/export tabs
13. /staff/cat/bucket/record/view
14. /staff/catalog/search
15. /staff/circ/holds/pull-list, right click a hold, choose Show Hold Details,
the tabs are at the bottom of the screen

Test plan:

Note that you cannot navigate tabbed interfaces using the tab key on your
keyboard.

Apply the patch, then visit the screens listed above.

You should be able to use the tab key to move sequentially through all the tabs.
Pressing Enter on an inactive tab should make it active, just as clicking it
would. You should not be able to click or press Enter to activate a disabled
tab.

You should be able to move from the last tab in the list into the first
focusable element in the active tab's content panel. If you spot a tab content
panel that doesn't contain a focusable element (i.e. links or inputs), let me
know; we have to set its tabindex attribute manually.

If a tab panel contains a second set of tabs, these should work as well.

Note on ARIA and roles:

Note that neither Bootstrap 5 nor ng-bootstrap are currently following the ARIA
Authoring Practices Guide for tabs with manual activation (the recommended
pattern for tab panels with complicated content, like form inputs or data
tables), which does not recommend sequential movement:
https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-manual.html. Therefore,
we aren't following this pattern either. We can revisit this and/or take it up
with Bootstrap.

For now, running axe DevTools on any screen with navs will show ARIA role errors
on role="tab" attributes. We are using ng-bootstrap's default ARIA roles for
tabs, but they are incorrect. I am trying to get traction on a pull request to
change the problem in ng-bootstrap, but in the meantime, we are not using the
automatic [roles] directive. Role attributes have been set explicitly on all
tabs and their containing elements.

Note on eg-tree CSS:

In the Org Unit Type screens, there was previously some inline CSS related to
eg-tree that was causing compiler errors. I have moved this to a separate CSS
file, and will revisit eg-tree styles more generally in another upcoming
project.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
This feature supplies the ability to create alternate templates for Action Triggers 2022-02-23T18:55:01Z Rogan Hamby rogan.hamby@gmail.com Jane Sandberg sandbergja@gmail.com 2022-02-23T18:55:01Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c318a31d41ab2c9dedc05cc18e64c1d9f7c6ca89
This feature supplies the ability to create alternate templates for Action Triggers
that will generate locale specific out for Action Triggers.  If you send notices in
multiple languages, we recommend putting some words to that effect in your notice
templates.  The template, message and message title can all be localized.  To use the
feature the following new UI elements have been added:

- When you double-click on an Event Definition under Notifications / Action Triggers
  to edit it there will be a tab option for Edit Alternate Template if the reactor is
  ProcessTemplate, SendEmail or SendSMS.
- In the Patron Registration and Patron Editor screens staff members may now select a
  locale for a patron and edit it in the Patron Preferred Language field.
- Patrons may set their own locale in the My Account interface off the OPAC by going to
  Preferences -> Personal Information and setting the Preferred Language field.

The templates used on the Edit Definition tab are the defaults that are used if there are
no alternate templates available that match the preferred language.  If alternate templates
are available the system will use a locale that is an exact match and then if failing that
use one where the language code matches and then fall back to the default one.

For example, if a patron has a locale of fr-CA and there are templates for both fr-CA and
fr-FR it will use the fr-CA.  If the fr-CA template was deleted it would fall back on using
the fr-FR for the patron since it at least shares the same base language.

Valid locales are the codes defined in the i18n_locale table in the config schema.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
lp1855780 remove unnecessary whitespace 2021-11-17T19:22:16Z Jane Sandberg sandbergja@gmail.com Jane Sandberg sandbergja@gmail.com 2021-11-17T19:22:16Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1eeb05186388debf6a46495107a3a6938dd22b0c
lp1855780 remove unnecessary whitespace

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP#1855780: add grid config settings 2021-11-09T15:51:27Z Galen Charlton gmc@equinoxOLI.org Jane Sandberg sandbergja@gmail.com 2021-11-09T15:51:27Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3ac25b250a0deadb1142f22d5cf843b483310a2b
LP#1855780: add grid config settings

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP#1855780: improve reporting of event test errors 2021-11-09T15:41:58Z Galen Charlton gmc@equinoxOLI.org Jane Sandberg sandbergja@gmail.com 2021-11-09T15:41:58Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2600680797b7943ba28f474779eb2fcac1fff30f
LP#1855780: improve reporting of event test errors

- make error title/caption strings available to i18n
- catch and report on exceptions, not just ILS events

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP#1855780: tweaks to grids 2021-11-08T20:58:04Z Galen Charlton gmc@equinoxOLI.org Jane Sandberg sandbergja@gmail.com 2021-11-08T20:58:04Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=037ced54ca9714dcfb7abae0ed93e4c5068d113b
LP#1855780: tweaks to grids

- make main A/T event definition grid header sticky
- do not display environment ID and parameter ID
  columns by default in the event definition
  editor

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP#1855780: adding the go-back button from Mike Risher's code 2021-09-24T19:21:47Z Rogan Hamby rogan.hamby@gmail.com Jane Sandberg sandbergja@gmail.com 2021-09-24T19:21:47Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=fa802945b2badbde7c822f60be710b7476d9cb28
LP#1855780: adding the go-back button from Mike Risher's code

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html
LP#1855780 Angular Notification/Action Triggers port 2019-12-19T17:56:41Z Mike Risher mrisher@catalyte.io Jane Sandberg sandbergja@gmail.com 2019-12-19T17:56:41Z https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=da3fff6cf5f075ab02ea991ebe38f8600f848b7e
LP#1855780 Angular Notification/Action Triggers port

Port Notification Action Triggers from DOJO to Angular.  This consists of 4 grids, each
navigated to by its corresponding tab. The Trigger Event Definitions grid allows
cloning of records.  When editing an event defintion one can also edit parameters,
environments, and run tests.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
  • [D] Open-ILS/src/eg2/src/app/staff/admin/local/triggers/trigger-edit.component.html