LP2023803 Replace btn-warning with appropriate color Replaces all instances of .btn-warning, which has poor color contrast, with other button colors. Actions that reset forms or delete data use .btn-destroy; other instances may use .btn-info or btn-normal depending on their context. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2023803 Use gray buttons for modal Cancel actions Changes .btn-warning to .btn-normal for all modal dialog Cancel actions. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2051879 Display Org Unit ID in Org Configuration This makes the numeric org unit ID visible in the Organizational Unit Configuration Interface. Release-note: Displays Org Unit ID in Org Config interface. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2047704 Patrons with Negative Balances - Grid Columns This adjusts the negative balances grid so that it shows the most useful columns by default and upon reset. (Before this change, resetting the columns showed ALL available columns.) It also adds local column sortability. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP2051599 Fix Cash Reports User Payments Date Parsing Apply the same date parsing fix for User Payments in the Cash Reports interface as the previous commit, which addressed Desk Payments. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2051599: fix parsing of start and end dates by Cash Reports This patch fixes a bug where if you open the Cash Reports at a time of day where the date in the local time zone is different from the date in UTC and do not interact with the date selectors, the report will not display payments made during the current day. The problem was due to the use of Date.toISOString() when attempting to extract just the date component; since Date.toISOString() forces the timestamp to UTC. The effect is that if you (say) open the Cash Reports page in North America sufficiently late in the date, the date selectors will display your current date, but the query to fetch payment information will (silently) supply the following day. To test ------- [1] Make some patron bill payments. [2] Open the Cash Reports at a time of day when an UTC clock would report a different date from your local date. Observe that no payments are listed or that payments from the previous day are listed. [3] Apply the patch and repeat step 2. This time, opening the Cash Reports page should show the payments for the current day. Release-note: Fix bug that could cause the Cash Reports page to display payments for the wrong day. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2043508 fix misconfigured delete dialogs and add dialogs where they were missing. Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP#2036296: always show note field in Hours of Operation form This patch removes the checkbox to show or hide the notes fields in the hours of operation editor in favor of always displaying them. This patch also adjusts the label to indicate that the note is optional and ensures that the label is properly bound to each note input. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
LP2047168 Patrons with Negative Balances Not Printing Barcode Makes patron barcodes appear when printing or downloading the grid. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1850473 Temporarily silence ESLint in bad HTML Silences the ESLint warnings on two files that we will address in response to separate bugs. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473 More button linting Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473 More button lint issues Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473 Fix button type lint errors Sets the type attribute on buttons where it was previously missing. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473: manual and automated eslint fixes Automatic fixes from `npm run lint -- --fix` Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2002362 Follow-up: workstation registration labels Updates the Angular workstation management form labels to be compatible with recent changes to the org unit selector component. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2043899 Revised org select field labels Reverses course on the new label strategy introduced in bug 1999158, which proved incompatible with some components with user-configurable labels (e.g. patron edit). Rather than introducing a <label> tag by default, we now use the more familiar ARIA label strategy in places where the field does not have a visible label. We will need to revisit these, as all form fields should have visible labels per WCAG, but the ARIA label serves to resolve the immediate problem for screen reader users. Affects all uses of <eg-org-select> and <eg-org-family-select>. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>