LP2056069 Fix button styles in grid actions menu modal Wraps the Menu Item and Visible toggles in <div> tags to fix an error that made them appear as unstyled buttons. Release-notes: Fixes the styling of the Angular grid's Manage Actions Menu modal Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP2056069 Fix button styles in grid column config modal Wraps the Name and Visibility toggles in <div> tags to fix an error that made them appear as unstyled buttons. Release-notes: Fixes the styling of the Angular grid's Manage Columns modal Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP2051566 Make Angular Grid Column Headers Bold Again A recent update changed the Angular grid column headers from A links to buttons, which broke the CSS chain and they lost their bold weight. This restores that. Release-note: Restores bold weight to eg-grid column headers Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
LP1850473 More button linting Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473 More button lint issues Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473 Fix button type lint errors Sets the type attribute on buttons where it was previously missing. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1850473: manual and automated eslint fixes Automatic fixes from `npm run lint -- --fix` Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2043899 Revised org select field labels Reverses course on the new label strategy introduced in bug 1999158, which proved incompatible with some components with user-configurable labels (e.g. patron edit). Rather than introducing a <label> tag by default, we now use the more familiar ARIA label strategy in places where the field does not have a visible label. We will need to revisit these, as all form fields should have visible labels per WCAG, but the ARIA label serves to resolve the immediate problem for screen reader users. Affects all uses of <eg-org-select> and <eg-org-family-select>. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
lp1993824: grids enhancement; support for saving filter sets turned off by default Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
lp1993824: grids enhancement; add grid button adjacent labels to eg-grid Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
lp1993824: grids bug fix; disabled attribute on eg-grid-toolbar-action Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1999158 Form labels for eg-org-select component Adds input directives to <eg-org-select> to support <label> tags with various options. Label tags are included alongside inputs unless explicitly suppressed. Where a visible label would disrupt the current layout, the "visually-hidden" CSS class may be used to hide the label visually while leaving it available to screen readers. All current instances of <eg-org-select> have been updated. Where labels already existed, those with specific layout requirements have been adjusted only to add missing "for" attributes, and the component's automatic output is suppressed with "visually-hidden". While this sometimes results in two <label> tags being present in the DOM, this is valid and doesn't cause any issues. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#2037128 Print Selected Rows on Grids Adds an option to both the Angular and AngularJS grids to print just the selected rows. Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2035535: Add accessibility tests to nightwatch To test: 1. Compile and install this branch 2. `cd Open-ILS/src/eg2` 3. `MOZ_HEADLESS=1 ng e2e` 4. In the output, confirm that a bunch of checks say 'aXe rule', and that they pass Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
LP1818086 Accessible text for grid flair icons (Angular) Adds visually-hidden text alongside grid flair icons so that the title, if given, will be announced in place of the icon keyword. Keywords are hidden in ARIA regardless of whether the title was specified. For the flair column, the ngbTooltip has been replaced with a standard title attribute, for consistency with other icons throughout the interface. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2038230 Add role="gridcell" to initial row cells Adds missing ARIA role="gridcell" attributes to the row selection checkbox, counter, and flair icon (if present) columns in Angular grids, to prevent these cells from being skipped when a screen reader navigates the grid. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1828575: Update ARIA labels for grid toolbar actions Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>