LP#2057948: Add Idempotency-Key to prevent duplicate stripe requests * Create key from sorted list of transaction IDs passed through md5_hex. * Do not include xact param for now, since I am not sure what it is; xact_misc is the list of transaction IDs selected in the payment form. * Pass header through -ua_args option when constructing the Stripe obj, because the per-request method is not published yet to CPAN. Tested with manual code on Ubuntu 22 LTS and Business::Stripe 0.07. Release-note: Adds idempotency to Stripe to prevent duplicate payments Signed-off-by: Ken Cox <kenstir@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#2000270: (follow-up) fix lint This patch also adds a "FIXME" to better signal an area where the patch author was uncertain of how to properly signal to Angular Forms when the OU selector has an invalid value. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2047592 OPAC - My Lists - Button Order LP2047592 OPAC - My Lists - Button Order Moves the View in Catalog button (when visible) to the end of row of buttons so that hiding/sharing a list doesn't visually disrupt the page as much. Release-note: Changes button order in OPAC My Lists Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2000270 Staff catalog lets staff pick invalid pickup locations Added new check to the hold component that disables the 'Place Hold(s)' button if the pickup location is empty or from the list of orgs that are shown but not valid pickup locations. Also modified the org-select component to check if the org it has selected is supposed to be disabled. When the org-selector is required, it will have the relevant class applied and have a little green or red slice. NOTE: The validity is applied in a somewhat hacky way that doesn't appear to be the official Angular way. It might not signal properly if used in a form. Steps to test: [1] In the staff client, go to Cataloging -> Search the Catalog [2] Search for something attempt to Place a Hold on it [3] Click on the Pickup Location input [4] Use the arrows and press tab to select an illegal pickup lib [5] Note the color on the input and the transparency of the button [6] Select a valid pickup location [7] Select a valid user for the hold [8] Note the color on the input and transparency of the button Release-Note: Prevents holds with an invalid pickup location selected from being placed in the angular catalog Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org>
LP #1906859: Create carousels from items To test carousel creation from item buckets: 1. Create an item bucket 2. Add a variety of items to your bucket 3. Select all items 4. Open the buckets menu 5. Under items, select "Create Carousel from Bucket" 6. Give your new carousel a name 7. Go to Local Admin > Carousels and confirm that a carousel now appears. 8. Open the record bucket for the new carousel and confirm that it contains all the titles for the items. To test carousel creation from item status: 1. Scan items into item status 2. Select all items 3. Open the actions menu 4. Select "Create Carousel from Selected Items" 5. Repeat steps 6-8 above Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Andrea Buntz Neiman <abneiman@EquinoxOLI.org> Signed-off-by: Katie Greenleaf Martin <kgm@sparkpa.org> Signed-off-by: Blake <blake@mobiusconsortium.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2043045 - Stop Log Noise - QueryParser.pm pullup() Silence some "Use of uninitialized value" warnings the pop up with every catalog search. Look for these log entries before the fix after performing some catalog searches. Use of uninitialized value in string eq at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1626. Use of uninitialized value in addition (+) at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1661 After the fix is applied, no more should be generated. Release-note: Silences some "Use of uninitialized value" log entries from catalog search Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1929596: Adds help popover text next to 'Convert change to patron credit' Search for a patron Go to Bills Note the popover text next to 'Convert change to patron credit' modifier Release-note: Adds help button for 'Convert change to patron credit' on patron bills Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> <eg-help-popover help-text="[% l('Applies any remaining amount after payment to the patron account for future use.') %]"># Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2047158 Annotate Payment Popup Box Skipped When Using Keyboard Navigation Changed AngularJS text input modal to submit on keydown instead of keyup. This stops the modal from immediately closing after being opened by the enter key. Release-note: Fixes annotate payment when using keyboard navigation Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Eva Cerniňáková <cernin@jabok.cz> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1525394: Return Titles for All Hold Types in SIP The SIP Patron Status Response message can include hold titles if requested by the SIP client. This commit adds Issuance holds to the previous commit addressing part holds, and should finally represent full coverage for our hold types. Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1525394 SIP patron part level holds respond blank Added code to flesh part level hold information in SIP/Patron.pm In order to test this, you will need to identify a patron who has a part level hold. Query SIP with a 63 message like: 6300120151211 104201 Y AOhidden|AApatronbarcode|AC|AY1AZF08D and the server should respond with the title in the |CD field for that part level hold. Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP2046820 Add aria-current to current nav menu item Adds the aria-current="page" attribute to the Angular staff navigation menu item corresponding to the page being viewed, and styles that link with a pale green background. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Shula Link <slink@gchrl.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2048798 Remove inaccurate count of Shelving Locations Removes the count, which was inaccurate, from the Shelving Locations table caption in the staff catalog. Release-note: Removes inaccurate shelving location count in staff catalog Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#2028095: stamp DB update Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2028095: Fix typo in Library Setting Description for acq.default_owning_lib_for_auto_lids_strategy Updated the description for acq.default_owning_lib_for_auto_lids_strategy to the text suggested in the ticket. Release-note: Improves description of the "How to set default owning library for auto-created line item items" Library Setting Steps to test: [1] Run XXXX.data.default_owning_lib_for_auto_lids_strategy_typo_fix.sql or install the seed data anew [2] Go to Administration -> Local Admin -> Library Settings Editor [3] Search for acq.default_owning_lib_for_auto_lids_strategy [4] Read description Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2023803 Replace btn-warning in AngularJS screens Replaces .btn-warning, which has poor color contrast, with other button styles: .btn-destroy if data is being deleted, otherwise .btn-normal. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2023803 Replace btn-warning with appropriate color Replaces all instances of .btn-warning, which has poor color contrast, with other button colors. Actions that reset forms or delete data use .btn-destroy; other instances may use .btn-info or btn-normal depending on their context. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2023803 Use gray buttons for modal Cancel actions Changes .btn-warning to .btn-normal for all modal dialog Cancel actions. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2051156 Mark Item as Missing Pieces barcode field too wide Prior to this change, the barcode input field was the full width of the screen and the submit button was below it. This small change makes it more consistent with other screens. Release-note: Fixes overly large barcode field on Mark Item as Missing Pieces page. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>