Fix a comment typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Modify NCIP::ILS::Evergreen->requestitem to try a little harder.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Simplify NCIP::ILS::Evergreen->retrieve_org_unit_by_shortname().

Use open-ils.actor.org_unit.retrieve_by_shortname instead of a
pcrud search.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a little something caught by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Alter find_bibliograpic_id to find_biblioraphic_ids in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add duplicate request check to NCIP::ILS::Evergreen->requestitem

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a typo in previous commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add RequestItem support to NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in previous commit: $enty for $entry.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add $code option to NCIP::ILS->find_bibliographic_id.

I wonder now, if I should not have overriden the method in the
Evergreen driver, but I thought this would be generically useful.

We will probably want a method that can return all of the IDs at
some point, but for now, any subclasses that need that, can
implement it, themselves.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Check for repeated BibliographId in NCIP::ILS->find_bibliographic_id.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in find_bibliographic_id in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Improve find_bibliographic_id in NCIP::ILS.

Add a check for BibligraphicDescription under ItemOptionalFields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add find_bibliographic_id to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Improve comments in NCIP::ILS.

Add an array example to find_user_barcode and find_item_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update the CheckOutItemResponse.inc template file.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add checkoutitem to NCIP::ILS::Evergreen.

Also add a couple of utility methods to check if a copy is allowed
to circulate and fill holds, as well as one to retrieve a copy
location object by id.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Simplify delete_copy in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Bump _problem_from_event's IQ by a couple of points.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add some "smarts" to _problem_from_event in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix text_code for textcode typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix set_timezone to set_time_zone in NCIP::ILS::Evergreen->renewitem.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add AuthenticationInput checks for more messages in NCIP::ILS.

We add the AUTHENTICATIONINPUT_MESSAGES constant to hold a list of
messages that may have AuthenticationInput set, and then we check
if our message is in the list when trying to find a user barcode
and the UserId field was not present.

Signed-off-by: Jason Stephenson <jason@sigio.com>

UserId does not repeat if present in a message.

Alter NCIP::ILS->find_user_barcode() to not make an array ref out
of UserId inputs. It is not supposed to repeat.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add error checking to NCIP::ILS::Evergreen->checkinitem().

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add RenewItem support for NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in NCIP::ILS::Evergreen->checkinitem().

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix some things in NCIP::ILS::Evergreen picked up by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Move circulation, copy and user checks to check_circ_details method.

Before implementing renewitem in NCIP::ILS::Evergreen, it became
apparent that we'd want to make the same checks for the copy being
checked out, owned by or checked out at our working ou, and being
checked out to the provided user, if any, before proceeding with
renewal. It makes sense therefore to move the checks from being
inside checkinitem to being its own function that returns a
NCIP::Problem or undef.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add check for more copies in NCIP::ILS::Evergreen->delete_copy.

We now check if there are other copies on the call number before
we delete it.

We also fix a thinko when we were checking for additional call
numbers on the bib. We had map where we needed grep.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Deflesh copy->call_number in NCIP::ILS::Evergreen->delete_copy.

To keep things simple, we deflesh the call number of the copy to
be deleted, if it was fleshed earlier, which it was likely to be.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add check for other volumes before delete a bib.

Modify NCIP::ILS::Evergreen->delete_copy() to check for call numbers
other than the one already being deleted on a bib prior to deleting
that bib. If there are other call numbers that are not themselves
deleted, then we do not delete the bib.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add use_force_holds config option for NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a problem detected by perl -c....

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add NCIP::ILS::Evergreen->delete_copy().

Call it from the checkinitem handler.

Also adjust some variable names in checkinitem handler so that they
make more sense.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add the UserId check in checkinitem in NCIP::ILS::Evergreen.

We check if the UserId is supplied in the request that it matches
the user who has the copy checked out. If not, we return a problem.

Also fix a copy/paste-o with item barcodes in a couple of Problem
constructors.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add additional ownership check in NCIP::ILS::Evergreen->checkinitem.

We make sure the NCIP staff user's work org. unit either owns the
copy to be checked in or it was checked out there.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add CheckInItem support to NCIP::ILS::Evergreen.

Add the basic checkinitem handler method.

Also add a retrieve_user_by_id method, and change the name of
retrieve_copy_by_barcode to retrieve_copy_details_by_barcode to
better reflect what it actually does.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a mistake in AcceptItemResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix ProblemDescription for ProblemDetail in NCIP::ILS::Evergreen.

This fixes a mistake in acceptitem when returning a Duplicate Item
problem. The ProblemDetail didn't show up in the response because
the constructor erroneously set ProblemDescription instead of
ProblemDetail.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix errors in AcceptItemResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a logic error in NCIP::ILS::Evergreen->acceptitem.

This is embarrassing: I had =~, when I really wanted !~, when
checking the value of RequestedActionType.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix another mistake in NCIP::ILS::Evergreen.

Forgot the {} around the arguments when creating a NCIP::Response
object in acceptitem.

Signed-off-by: Jason Stephenson <jason@sigio.com>

More syntax errors and thinkos/typos in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix syntax and variable errors in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in NCIP::RequestId.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add AcceptItem processing to NCIP::ILS::Evergreen.

This necessitated the addition of several methods to
NCIP::ILS::Evergreen for looking up users, copies, etc., as well
as for the placing of holds, and checking for some errors. Most
of the new methods will be useful for other message handlers.
The LookupUser handler was also modified to use the new methods
where appropriate.

AcceptItemResonse.inc was also modified to take into account the
new way of passing data to templates. NCIP::ILS::Koha has yet to
be modified to use these new methods.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Some POD fixups.

Use verbatim paragraphs instead of formatted blocks for the code
examples when describing methods.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add find_item_barcode to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Edit find_user_barcode in NCIP::ILS to be more universal.

It now works with messages other than just LookupUser.

Signed-off-by: Jason Stephenson <jason@sigio.com>

NCIP::Item and friends.

Modify NCIP::Item to hold the data for the Item Information field
and add necessary objects for most of its subfields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add NCIP::Item::Id module.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add NCIP::RequestId to handle RequestId information.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a mistake with previous commit.

Needed to add a @{...} around my call to AppUtils->get_org_ancestors
when retrieving the stat_cat entries. I was testing with use_precats
enabled, so I missed it last night.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Avoid the direct use of cstore in NCIP::ILS::Evergreen.

We use an open-ils.circ routine to retrieve asset stat cat entries
instead of an open-ils.cstore search.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix some issues with pcrud and cstore calls in NCIP::ILS::Evergreen.

Simplify some of the _init method along the way.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Eliminate CStoreEditor from ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Modify Evergreen->lookupuser so it doesn't need a CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Flesh user's home_ou in Evergreen->lookupuser.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix "thinko" in ILS->find_user_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Set privilige ValidFromDate to user's account create date.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Some logical fixup to ILS->find_user_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Change ILS->find_barcode to ILS->find_user_barcode.

I anticipate that we'll need a separate method to find an item
barcode.

Also, we return the tag of the field where the barcode was in
list context. We still return only the barcode in scalar context.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Remove NCIP/Handler.pm and family.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix lookupuser problem reporting in Evergreen driver.

Actually set the response object's problem member if we fail to
look up the user.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a typo in POD in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a few issues with retrieving block or trap for LookupUser.

We also now say holds are blocked if holds fulfillment is blocked
for the patron.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add lookup for UserId in NCIP::ILS->find_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Strip leading whitespace in LookupUserResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix LookupUserResponse.inc.

Missing "User" for UserAddressRoleType field.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix an error in Evergreen.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a typo in LookupVersionResponse.inc.

XML sucks if you ask me, but you didn't.

Signed-off-by: Jason Stephenson <jason@sigio.com>

More LookupVersion fixes.

NCIP has too many redundant layers of tags.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix a few things in NCIP::ILS::Evergreen turned up by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

A few fixes for NCIP::ILS::Evergreen.

We need to get the username, password, workstation, etc. from the
credentials member of the config hash.

Also fix a typo on line 459 by deleting an extraneous -.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix omission of "data." in LookupVersionResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add required FromAgencyId and ToAgencyId to LookupVersionResponse.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix typo in lib/NCIP/StructuredPersonalUserName.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Remove some extra whitespace in responses.

Add some - in the main.tt to strip trailing whitespace.

Also remove an extra blank line from the bottom of templates/
includes/header.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update Evergreen code for the better_abstraction branch.

Also add find_barcode to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add POD to lib/NCIP/Problem.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update POD in NCIP::User::Id to indicate that AgencyId is optional.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Have UserId be an array ref in NCIP::User.

Adjust the LookupUserResponse.inc template, and add text to POD
in NCIP::User explaining the fields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Change comments to POD in NCIP::Response module.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Merge branch 'masslnc' into better_abstraction

Add ElectronicAddress element.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add output of Scheme in problem.inc template if it is defined.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Merge branch 'master' into better_abstraction

Add some more POD to the new user-related classes.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fill out NCIP::User and friends.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fixing a bug in the userenv for Koha

Add POD to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add xml filter on the new template include files.

I forgot to do this after testing them.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Prepare NCIP.pm and NCIP/ILS.pm for removal of Handler.pm and cousins.

This moves the rendering of template output from Handler.pm to NCIP.pm.

We also add another useful method, parse_request_type to NCIP::ILS.

Along the way, we go from parsing the XML message with XPath to using
XML::LibXML::Simple.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Make sample config & NCIP.pm aware of NCIP::ILS.

This also means loading the ILS modules by giving the fully
qualified module name.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update templates for new abstraction method.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add unsupportedservice method to NCIP::ILS.

This is used to return an "Unsupported Service" problem message.

We also added default implementations for the message handlers for
the messages required by Autographics' SHAREit that simply return
the Unsuported Service response.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Fixes for ILS::make_header.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Add lookupversion implemenation to NCIP::ILS.

Also fix a few typos.

Signed-off-by: Jason Stephenson <jason@sigio.com>