working/NCIPServer.git
3 years agoLast fix just gave us a different warning.
Jason Stephenson [Sun, 5 Oct 2014 16:14:25 +0000]
Last fix just gave us a different warning.

Try to fix it for real this time.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoTry to fix a warning when checking penalties.
Jason Stephenson [Sun, 5 Oct 2014 16:10:55 +0000]
Try to fix a warning when checking penalties.

Use of uninitialized value in pattern match (m//) at
/home/opensrf/NCIPServer/lib/NCIP/ILS/Evergreen.pm line 1595.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix typo in function name in NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 5 Oct 2014 15:58:14 +0000]
Fix typo in function name in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix copy and paste problem with previous commit.
Jason Stephenson [Sun, 5 Oct 2014 14:59:31 +0000]
Fix copy and paste problem with previous commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAdd UserOptionalFields to more templates.
Jason Stephenson [Sun, 5 Oct 2014 14:56:38 +0000]
Add UserOptionalFields to more templates.

Also add checks for it in more messages for NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAdd NCIP::ILS::Evergreen->handle_user_elements for flexibility.
Jason Stephenson [Sun, 5 Oct 2014 14:26:32 +0000]
Add NCIP::ILS::Evergreen->handle_user_elements for flexibility.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAdd handling of NeedBeforeDate to NCIP::ILS::Evergreen->requestitem.
Jason Stephenson [Sun, 5 Oct 2014 14:02:35 +0000]
Add handling of NeedBeforeDate to NCIP::ILS::Evergreen->requestitem.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix problems with _problem_from_event in NCIP::ILS::Evergreen.
Jason Stephenson [Thu, 2 Oct 2014 00:40:15 +0000]
Fix problems with _problem_from_event in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix mistake in NCIP::ILS::Evergreen on line 924.
Jason Stephenson [Thu, 2 Oct 2014 00:32:43 +0000]
Fix mistake in NCIP::ILS::Evergreen on line 924.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAlter NCIP::ILS::Evergreen->_hold_search() to do just one thing.
Jason Stephenson [Sun, 28 Sep 2014 14:29:39 +0000]
Alter NCIP::ILS::Evergreen->_hold_search() to do just one thing.

Remove the code that had it return a problem if no holds were
found and make it the caller's responsibility to check if a hold
was returned or nothing.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix typos in NCIP::ILS::Evergreen caught by perl -c.
Jason Stephenson [Sun, 28 Sep 2014 14:22:28 +0000]
Fix typos in NCIP::ILS::Evergreen caught by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAdd cancelrequestitem handler to NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 28 Sep 2014 14:19:45 +0000]
Add cancelrequestitem handler to NCIP::ILS::Evergreen.

Also add the CancelRequestItemResponse.inc to the templates.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoMore NCIP::ILS::Evergreen->requestitem() improvements.
Jason Stephenson [Sat, 27 Sep 2014 16:51:18 +0000]
More NCIP::ILS::Evergreen->requestitem() improvements.

We check if item is a NCIP::Problem and return it if it is.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix a comment typo in NCIP::ILS::Evergreen.
Jason Stephenson [Sat, 27 Sep 2014 16:11:47 +0000]
Fix a comment typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoModify NCIP::ILS::Evergreen->requestitem to try a little harder.
Jason Stephenson [Sat, 27 Sep 2014 15:07:03 +0000]
Modify NCIP::ILS::Evergreen->requestitem to try a little harder.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoSimplify NCIP::ILS::Evergreen->retrieve_org_unit_by_shortname().
Jason Stephenson [Sat, 27 Sep 2014 13:58:08 +0000]
Simplify NCIP::ILS::Evergreen->retrieve_org_unit_by_shortname().

Use open-ils.actor.org_unit.retrieve_by_shortname instead of a
pcrud search.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoFix a little something caught by perl -c.
Jason Stephenson [Sat, 27 Sep 2014 12:37:29 +0000]
Fix a little something caught by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

3 years agoAlter find_bibliograpic_id to find_biblioraphic_ids in NCIP::ILS.
Jason Stephenson [Sat, 27 Sep 2014 12:35:26 +0000]
Alter find_bibliograpic_id to find_biblioraphic_ids in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd duplicate request check to NCIP::ILS::Evergreen->requestitem
Jason Stephenson [Tue, 23 Sep 2014 01:51:29 +0000]
Add duplicate request check to NCIP::ILS::Evergreen->requestitem

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a typo in previous commit.
Jason Stephenson [Mon, 22 Sep 2014 19:44:30 +0000]
Fix a typo in previous commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd RequestItem support to NCIP::ILS::Evergreen.
Jason Stephenson [Mon, 22 Sep 2014 19:43:15 +0000]
Add RequestItem support to NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in previous commit: $enty for $entry.
Jason Stephenson [Mon, 22 Sep 2014 18:35:16 +0000]
Fix typo in previous commit: $enty for $entry.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd $code option to NCIP::ILS->find_bibliographic_id.
Jason Stephenson [Mon, 22 Sep 2014 18:32:34 +0000]
Add $code option to NCIP::ILS->find_bibliographic_id.

I wonder now, if I should not have overriden the method in the
Evergreen driver, but I thought this would be generically useful.

We will probably want a method that can return all of the IDs at
some point, but for now, any subclasses that need that, can
implement it, themselves.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in NCIP::ILS::Evergreen.
Jason Stephenson [Mon, 22 Sep 2014 17:24:51 +0000]
Fix typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoCheck for repeated BibliographId in NCIP::ILS->find_bibliographic_id.
Jason Stephenson [Mon, 22 Sep 2014 17:20:57 +0000]
Check for repeated BibliographId in NCIP::ILS->find_bibliographic_id.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in find_bibliographic_id in NCIP::ILS.
Jason Stephenson [Mon, 22 Sep 2014 15:01:36 +0000]
Fix typo in find_bibliographic_id in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoImprove find_bibliographic_id in NCIP::ILS.
Jason Stephenson [Mon, 22 Sep 2014 14:45:27 +0000]
Improve find_bibliographic_id in NCIP::ILS.

Add a check for BibligraphicDescription under ItemOptionalFields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd find_bibliographic_id to NCIP::ILS.
Jason Stephenson [Mon, 22 Sep 2014 14:28:29 +0000]
Add find_bibliographic_id to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoImprove comments in NCIP::ILS.
Jason Stephenson [Mon, 22 Sep 2014 13:58:32 +0000]
Improve comments in NCIP::ILS.

Add an array example to find_user_barcode and find_item_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoUpdate the CheckOutItemResponse.inc template file.
Jason Stephenson [Sun, 21 Sep 2014 19:39:53 +0000]
Update the CheckOutItemResponse.inc template file.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd checkoutitem to NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 21 Sep 2014 19:26:10 +0000]
Add checkoutitem to NCIP::ILS::Evergreen.

Also add a couple of utility methods to check if a copy is allowed
to circulate and fill holds, as well as one to retrieve a copy
location object by id.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoSimplify delete_copy in NCIP::ILS::Evergreen.
Jason Stephenson [Fri, 19 Sep 2014 12:46:07 +0000]
Simplify delete_copy in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoBump _problem_from_event's IQ by a couple of points.
Jason Stephenson [Sun, 14 Sep 2014 22:22:47 +0000]
Bump _problem_from_event's IQ by a couple of points.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd some "smarts" to _problem_from_event in NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 14 Sep 2014 21:49:41 +0000]
Add some "smarts" to _problem_from_event in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix text_code for textcode typo in NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 14 Sep 2014 20:51:34 +0000]
Fix text_code for textcode typo in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix set_timezone to set_time_zone in NCIP::ILS::Evergreen->renewitem.
Jason Stephenson [Sun, 14 Sep 2014 19:57:29 +0000]
Fix set_timezone to set_time_zone in NCIP::ILS::Evergreen->renewitem.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd AuthenticationInput checks for more messages in NCIP::ILS.
Jason Stephenson [Sun, 14 Sep 2014 17:45:35 +0000]
Add AuthenticationInput checks for more messages in NCIP::ILS.

We add the AUTHENTICATIONINPUT_MESSAGES constant to hold a list of
messages that may have AuthenticationInput set, and then we check
if our message is in the list when trying to find a user barcode
and the UserId field was not present.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoUserId does not repeat if present in a message.
Jason Stephenson [Sun, 14 Sep 2014 17:30:59 +0000]
UserId does not repeat if present in a message.

Alter NCIP::ILS->find_user_barcode() to not make an array ref out
of UserId inputs. It is not supposed to repeat.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd error checking to NCIP::ILS::Evergreen->checkinitem().
Jason Stephenson [Sun, 14 Sep 2014 17:14:02 +0000]
Add error checking to NCIP::ILS::Evergreen->checkinitem().

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd RenewItem support for NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 14 Sep 2014 17:07:54 +0000]
Add RenewItem support for NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in NCIP::ILS::Evergreen->checkinitem().
Jason Stephenson [Sun, 14 Sep 2014 15:39:05 +0000]
Fix typo in NCIP::ILS::Evergreen->checkinitem().

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix some things in NCIP::ILS::Evergreen picked up by perl -c.
Jason Stephenson [Sun, 14 Sep 2014 14:44:55 +0000]
Fix some things in NCIP::ILS::Evergreen picked up by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoMove circulation, copy and user checks to check_circ_details method.
Jason Stephenson [Sun, 14 Sep 2014 14:19:54 +0000]
Move circulation, copy and user checks to check_circ_details method.

Before implementing renewitem in NCIP::ILS::Evergreen, it became
apparent that we'd want to make the same checks for the copy being
checked out, owned by or checked out at our working ou, and being
checked out to the provided user, if any, before proceeding with
renewal. It makes sense therefore to move the checks from being
inside checkinitem to being its own function that returns a
NCIP::Problem or undef.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd check for more copies in NCIP::ILS::Evergreen->delete_copy.
Jason Stephenson [Sun, 14 Sep 2014 03:54:50 +0000]
Add check for more copies in NCIP::ILS::Evergreen->delete_copy.

We now check if there are other copies on the call number before
we delete it.

We also fix a thinko when we were checking for additional call
numbers on the bib. We had map where we needed grep.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoDeflesh copy->call_number in NCIP::ILS::Evergreen->delete_copy.
Jason Stephenson [Sat, 13 Sep 2014 18:49:43 +0000]
Deflesh copy->call_number in NCIP::ILS::Evergreen->delete_copy.

To keep things simple, we deflesh the call number of the copy to
be deleted, if it was fleshed earlier, which it was likely to be.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd check for other volumes before delete a bib.
Jason Stephenson [Sat, 13 Sep 2014 17:47:02 +0000]
Add check for other volumes before delete a bib.

Modify NCIP::ILS::Evergreen->delete_copy() to check for call numbers
other than the one already being deleted on a bib prior to deleting
that bib. If there are other call numbers that are not themselves
deleted, then we do not delete the bib.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd use_force_holds config option for NCIP::ILS::Evergreen.
Jason Stephenson [Sat, 13 Sep 2014 15:40:41 +0000]
Add use_force_holds config option for NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a problem detected by perl -c....
Jason Stephenson [Sat, 13 Sep 2014 15:11:25 +0000]
Fix a problem detected by perl -c....

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd NCIP::ILS::Evergreen->delete_copy().
Jason Stephenson [Sat, 13 Sep 2014 15:08:33 +0000]
Add NCIP::ILS::Evergreen->delete_copy().

Call it from the checkinitem handler.

Also adjust some variable names in checkinitem handler so that they
make more sense.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd the UserId check in checkinitem in NCIP::ILS::Evergreen.
Jason Stephenson [Fri, 12 Sep 2014 12:59:50 +0000]
Add the UserId check in checkinitem in NCIP::ILS::Evergreen.

We check if the UserId is supplied in the request that it matches
the user who has the copy checked out. If not, we return a problem.

Also fix a copy/paste-o with item barcodes in a couple of Problem
constructors.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd additional ownership check in NCIP::ILS::Evergreen->checkinitem.
Jason Stephenson [Fri, 12 Sep 2014 12:42:15 +0000]
Add additional ownership check in NCIP::ILS::Evergreen->checkinitem.

We make sure the NCIP staff user's work org. unit either owns the
copy to be checked in or it was checked out there.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd CheckInItem support to NCIP::ILS::Evergreen.
Jason Stephenson [Fri, 12 Sep 2014 02:00:04 +0000]
Add CheckInItem support to NCIP::ILS::Evergreen.

Add the basic checkinitem handler method.

Also add a retrieve_user_by_id method, and change the name of
retrieve_copy_by_barcode to retrieve_copy_details_by_barcode to
better reflect what it actually does.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a mistake in AcceptItemResponse.inc.
Jason Stephenson [Fri, 12 Sep 2014 01:49:55 +0000]
Fix a mistake in AcceptItemResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix ProblemDescription for ProblemDetail in NCIP::ILS::Evergreen.
Jason Stephenson [Wed, 10 Sep 2014 12:37:22 +0000]
Fix ProblemDescription for ProblemDetail in NCIP::ILS::Evergreen.

This fixes a mistake in acceptitem when returning a Duplicate Item
problem. The ProblemDetail didn't show up in the response because
the constructor erroneously set ProblemDescription instead of
ProblemDetail.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix errors in AcceptItemResponse.inc.
Jason Stephenson [Mon, 8 Sep 2014 02:23:46 +0000]
Fix errors in AcceptItemResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a logic error in NCIP::ILS::Evergreen->acceptitem.
Jason Stephenson [Mon, 8 Sep 2014 01:14:32 +0000]
Fix a logic error in NCIP::ILS::Evergreen->acceptitem.

This is embarrassing: I had =~, when I really wanted !~, when
checking the value of RequestedActionType.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix another mistake in NCIP::ILS::Evergreen.
Jason Stephenson [Mon, 8 Sep 2014 01:11:45 +0000]
Fix another mistake in NCIP::ILS::Evergreen.

Forgot the {} around the arguments when creating a NCIP::Response
object in acceptitem.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoMore syntax errors and thinkos/typos in NCIP::ILS::Evergreen.
Jason Stephenson [Mon, 8 Sep 2014 00:44:55 +0000]
More syntax errors and thinkos/typos in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix syntax and variable errors in NCIP::ILS::Evergreen.
Jason Stephenson [Mon, 8 Sep 2014 00:37:43 +0000]
Fix syntax and variable errors in NCIP::ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in NCIP::RequestId.
Jason Stephenson [Mon, 8 Sep 2014 00:31:28 +0000]
Fix typo in NCIP::RequestId.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd AcceptItem processing to NCIP::ILS::Evergreen.
Jason Stephenson [Sun, 7 Sep 2014 20:45:46 +0000]
Add AcceptItem processing to NCIP::ILS::Evergreen.

This necessitated the addition of several methods to
NCIP::ILS::Evergreen for looking up users, copies, etc., as well
as for the placing of holds, and checking for some errors. Most
of the new methods will be useful for other message handlers.
The LookupUser handler was also modified to use the new methods
where appropriate.

AcceptItemResonse.inc was also modified to take into account the
new way of passing data to templates. NCIP::ILS::Koha has yet to
be modified to use these new methods.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoSome POD fixups.
Jason Stephenson [Sat, 6 Sep 2014 00:31:27 +0000]
Some POD fixups.

Use verbatim paragraphs instead of formatted blocks for the code
examples when describing methods.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd find_item_barcode to NCIP::ILS.
Jason Stephenson [Sun, 31 Aug 2014 14:09:36 +0000]
Add find_item_barcode to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoEdit find_user_barcode in NCIP::ILS to be more universal.
Jason Stephenson [Sun, 31 Aug 2014 13:56:03 +0000]
Edit find_user_barcode in NCIP::ILS to be more universal.

It now works with messages other than just LookupUser.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoNCIP::Item and friends.
Jason Stephenson [Sun, 31 Aug 2014 02:21:20 +0000]
NCIP::Item and friends.

Modify NCIP::Item to hold the data for the Item Information field
and add necessary objects for most of its subfields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd NCIP::Item::Id module.
Jason Stephenson [Sat, 30 Aug 2014 20:29:46 +0000]
Add NCIP::Item::Id module.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd NCIP::RequestId to handle RequestId information.
Jason Stephenson [Sat, 30 Aug 2014 20:22:21 +0000]
Add NCIP::RequestId to handle RequestId information.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a mistake with previous commit.
Jason Stephenson [Sat, 30 Aug 2014 13:38:41 +0000]
Fix a mistake with previous commit.

Needed to add a @{...} around my call to AppUtils->get_org_ancestors
when retrieving the stat_cat entries. I was testing with use_precats
enabled, so I missed it last night.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAvoid the direct use of cstore in NCIP::ILS::Evergreen.
Jason Stephenson [Sat, 30 Aug 2014 05:33:49 +0000]
Avoid the direct use of cstore in NCIP::ILS::Evergreen.

We use an open-ils.circ routine to retrieve asset stat cat entries
instead of an open-ils.cstore search.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix some issues with pcrud and cstore calls in NCIP::ILS::Evergreen.
Jason Stephenson [Thu, 28 Aug 2014 01:54:48 +0000]
Fix some issues with pcrud and cstore calls in NCIP::ILS::Evergreen.

Simplify some of the _init method along the way.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoEliminate CStoreEditor from ILS::Evergreen.
Jason Stephenson [Thu, 28 Aug 2014 00:58:33 +0000]
Eliminate CStoreEditor from ILS::Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoModify Evergreen->lookupuser so it doesn't need a CStoreEditor.
Jason Stephenson [Thu, 28 Aug 2014 00:17:52 +0000]
Modify Evergreen->lookupuser so it doesn't need a CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFlesh user's home_ou in Evergreen->lookupuser.
Jason Stephenson [Wed, 27 Aug 2014 22:26:52 +0000]
Flesh user's home_ou in Evergreen->lookupuser.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix "thinko" in ILS->find_user_barcode.
Jason Stephenson [Sun, 24 Aug 2014 16:10:36 +0000]
Fix "thinko" in ILS->find_user_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoSet privilige ValidFromDate to user's account create date.
Jason Stephenson [Sun, 24 Aug 2014 14:41:32 +0000]
Set privilige ValidFromDate to user's account create date.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoSome logical fixup to ILS->find_user_barcode.
Jason Stephenson [Sun, 24 Aug 2014 14:29:51 +0000]
Some logical fixup to ILS->find_user_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoChange ILS->find_barcode to ILS->find_user_barcode.
Jason Stephenson [Sun, 24 Aug 2014 14:11:03 +0000]
Change ILS->find_barcode to ILS->find_user_barcode.

I anticipate that we'll need a separate method to find an item
barcode.

Also, we return the tag of the field where the barcode was in
list context. We still return only the barcode in scalar context.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoRemove NCIP/Handler.pm and family.
Jason Stephenson [Sun, 24 Aug 2014 14:02:56 +0000]
Remove NCIP/Handler.pm and family.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix lookupuser problem reporting in Evergreen driver.
Jason Stephenson [Sun, 24 Aug 2014 02:25:08 +0000]
Fix lookupuser problem reporting in Evergreen driver.

Actually set the response object's problem member if we fail to
look up the user.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a typo in POD in NCIP::ILS.
Jason Stephenson [Sat, 23 Aug 2014 18:40:46 +0000]
Fix a typo in POD in NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a few issues with retrieving block or trap for LookupUser.
Jason Stephenson [Sat, 23 Aug 2014 18:26:31 +0000]
Fix a few issues with retrieving block or trap for LookupUser.

We also now say holds are blocked if holds fulfillment is blocked
for the patron.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd lookup for UserId in NCIP::ILS->find_barcode.
Jason Stephenson [Sat, 23 Aug 2014 16:03:42 +0000]
Add lookup for UserId in NCIP::ILS->find_barcode.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoStrip leading whitespace in LookupUserResponse.inc.
Jason Stephenson [Sat, 23 Aug 2014 15:48:26 +0000]
Strip leading whitespace in LookupUserResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix LookupUserResponse.inc.
Jason Stephenson [Sat, 23 Aug 2014 15:44:56 +0000]
Fix LookupUserResponse.inc.

Missing "User" for UserAddressRoleType field.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix an error in Evergreen.pm.
Jason Stephenson [Sat, 23 Aug 2014 15:38:26 +0000]
Fix an error in Evergreen.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a typo in LookupVersionResponse.inc.
Jason Stephenson [Sat, 23 Aug 2014 15:32:01 +0000]
Fix a typo in LookupVersionResponse.inc.

XML sucks if you ask me, but you didn't.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoMore LookupVersion fixes.
Jason Stephenson [Sat, 23 Aug 2014 15:29:55 +0000]
More LookupVersion fixes.

NCIP has too many redundant layers of tags.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix a few things in NCIP::ILS::Evergreen turned up by perl -c.
Jason Stephenson [Sat, 23 Aug 2014 15:11:52 +0000]
Fix a few things in NCIP::ILS::Evergreen turned up by perl -c.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoA few fixes for NCIP::ILS::Evergreen.
Jason Stephenson [Sat, 23 Aug 2014 14:59:28 +0000]
A few fixes for NCIP::ILS::Evergreen.

We need to get the username, password, workstation, etc. from the
credentials member of the config hash.

Also fix a typo on line 459 by deleting an extraneous -.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix omission of "data." in LookupVersionResponse.inc.
Jason Stephenson [Sat, 23 Aug 2014 14:31:39 +0000]
Fix omission of "data." in LookupVersionResponse.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd required FromAgencyId and ToAgencyId to LookupVersionResponse.
Jason Stephenson [Sat, 23 Aug 2014 14:22:58 +0000]
Add required FromAgencyId and ToAgencyId to LookupVersionResponse.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoFix typo in lib/NCIP/StructuredPersonalUserName.pm.
Jason Stephenson [Sat, 23 Aug 2014 14:09:26 +0000]
Fix typo in lib/NCIP/StructuredPersonalUserName.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoRemove some extra whitespace in responses.
Jason Stephenson [Fri, 22 Aug 2014 11:56:01 +0000]
Remove some extra whitespace in responses.

Add some - in the main.tt to strip trailing whitespace.

Also remove an extra blank line from the bottom of templates/
includes/header.inc.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoUpdate Evergreen code for the better_abstraction branch.
Jason Stephenson [Mon, 18 Aug 2014 12:53:23 +0000]
Update Evergreen code for the better_abstraction branch.

Also add find_barcode to NCIP::ILS.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoAdd POD to lib/NCIP/Problem.pm.
Jason Stephenson [Mon, 18 Aug 2014 00:55:17 +0000]
Add POD to lib/NCIP/Problem.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoUpdate POD in NCIP::User::Id to indicate that AgencyId is optional.
Jason Stephenson [Sun, 17 Aug 2014 16:06:05 +0000]
Update POD in NCIP::User::Id to indicate that AgencyId is optional.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoHave UserId be an array ref in NCIP::User.
Jason Stephenson [Sun, 17 Aug 2014 15:44:41 +0000]
Have UserId be an array ref in NCIP::User.

Adjust the LookupUserResponse.inc template, and add text to POD
in NCIP::User explaining the fields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoChange comments to POD in NCIP::Response module.
Jason Stephenson [Sun, 17 Aug 2014 15:26:09 +0000]
Change comments to POD in NCIP::Response module.

Signed-off-by: Jason Stephenson <jason@sigio.com>

4 years agoMerge branch 'masslnc' into better_abstraction
Jason Stephenson [Sun, 17 Aug 2014 15:08:06 +0000]
Merge branch 'masslnc' into better_abstraction

4 years agoAdd ElectronicAddress element.
Jason Stephenson [Sun, 17 Aug 2014 15:01:14 +0000]
Add ElectronicAddress element.

Signed-off-by: Jason Stephenson <jason@sigio.com>