]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP#1205072 - Action Trigger Granularity Case Sensitivity user/stompro/lp1205072-action-trig-granularity-ui
authorJosh Stompro <stomproj@larl.org>
Tue, 13 Jan 2015 19:36:40 +0000 (13:36 -0600)
committerJosh Stompro <stomproj@larl.org>
Wed, 24 Jun 2015 14:10:24 +0000 (09:10 -0500)
commite7bbd0fcb0179722e1070296444570fd24218766
tree2c53e082741077fdb99a705621aafe45c5647aa5
parentae76b301ad8fcbe135cf51734ab1e2d36bdefe96
LP#1205072 - Action Trigger Granularity Case Sensitivity

This change makes the granularity settings case insensitive.

To test this issue
1. Create/Modify an action trigger to have an all uppercase granularity settings.
2. Run action_trigger_runner.pl with the same granularity set to lowercase
3. Observe that the events are not processed.

After the change is applied the granularity case doesn't matter for either the event_definition
or the flag to action_trigger_runner.pl.

I didn't modify the code path for when the granularity only flag isn't set since it
never gets used, and I don't want to change what I cannot test.  Maybe the best course
of action would just be to remove that section?

Added "weekdays" option to match up with example crontab file.

Replace the release notes entry since the behavior has changed.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger.pm
Open-ILS/src/templates/conify/global/action_trigger/event_definition.tt2
docs/RELEASE_NOTES_NEXT/Administration/action-trigger-granularity.txt