]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
authorJason Stephenson <jstephenson@mvlc.org>
Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 17 Sep 2015 21:35:57 +0000 (17:35 -0400)
commit662684be39cf9717544540bfff180dcf77d7be83
treed1239dbec9eee65846b2dba4f012ba64513f2f93
parent39ee5425a6f5f51379a760d8f197066817d04566
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon

It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon.  This duplication can lead to data loss for the function
update_fleshed_copies.  It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:

"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.

After this patch, the warning disappears.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm