]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP 1170794: Skip Deposit Fee on Renewal user/dyrcona/lp1170794-skip-deposit-fee-on-renewal
authorJason Stephenson <jason@sigio.com>
Thu, 9 Feb 2017 20:27:58 +0000 (15:27 -0500)
committerJason Stephenson <jason@sigio.com>
Thu, 9 Feb 2017 21:49:56 +0000 (16:49 -0500)
commit57f133e156a7ddd74076c041c04bdff492d1d810
tree96b93a8951c66757857167c4cc88e1fd657de6f7
parent47a6251477d9d872c7e97f239c2286917fb29fb1
LP 1170794: Skip Deposit Fee on Renewal

Skip charging the deposit fee if the circulation is a renewal.

This commit sets the Circulator object's skip_deposit_fee to true in
mk_env if the current action is renew.  This causes the deposit fee to
not be charged.

It also adds a check to the Circulator object's check_item_deposits
method so that the ITEM_DEPOSIT_REQUIRED event is not thrown if
skip_deposit_fee is true.  Something similar should be done for the
ITEM_RENTAL_FEE_REQUIRED event, but that is beyond the scope of this
bug.

We also add a rudimentary, but hopefully sufficient, release note.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
docs/RELEASE_NOTES_NEXT/Circulation/skip_deposit_fee_on_renewal.adoc [new file with mode: 0644]