From cd92c579b78cdc4ffcaaf0bb0922412400d311d9 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Wed, 8 Jan 2014 13:21:13 -0800 Subject: [PATCH] Fix bug that caused deleted holdings to be visible in SRU/Z39.50 results Signed-off-by: Jeff Davis Signed-off-by: Ben Shum Conflicts: Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm --- Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm index 2e7000eaef..507f885199 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm @@ -2042,7 +2042,7 @@ sub basic_record_holdings { $logger->debug("Searching for holdings at orgs [".join(',',@ou_ids)."], based on $ou"); for my $cn (@{$tree->call_numbers}) { - next unless ( $cn->deleted eq 'f' || $cn->deleted == 0 ); + next unless ( $cn->deleted eq 'f' || !$cn->deleted ); my $found = 0; for my $c (@{$cn->copies}) { @@ -2078,7 +2078,7 @@ sub _cp_is_visible { my $cp = shift; my $visible = 0; - if ( ($cp->deleted eq 'f' || $cp->deleted == 0) && + if ( ($cp->deleted eq 'f' || !$cp->deleted) && $cp->location->opac_visible eq 't' && $cp->status->opac_visible eq 't' && $cp->opac_visible eq 't' && -- 2.43.2