From 8a103910aab22302528dcdea1b3b42e315f6558a Mon Sep 17 00:00:00 2001 From: Kathy Lussier Date: Thu, 9 Jul 2015 23:23:08 -0400 Subject: [PATCH] lp1466201 Disable Google Analytics in the staff client As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics outright in the staff client; there's far too much potential for leaking patron information." This branch aims to do so. Test plan: Enable Google Analytics in config.tt2. Access the catalog in the staff client. Click Debug to view the source code. Pre-patch, you'll see the Google Analytics javascript within the head element. Post-patch, that javascript will be gone. Viewing the source of a catalog page in a browser should continue to show the Google Analytics javascript within the head element. Signed-off-by: Kathy Lussier Signed-off-by: Ben Shum --- Open-ILS/src/templates/opac/parts/base.tt2 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/templates/opac/parts/base.tt2 b/Open-ILS/src/templates/opac/parts/base.tt2 index 8c24507171..1a3a979d41 100644 --- a/Open-ILS/src/templates/opac/parts/base.tt2 +++ b/Open-ILS/src/templates/opac/parts/base.tt2 @@ -31,7 +31,9 @@ [% END %] - [% INCLUDE 'opac/parts/goog_analytics.tt2' %] + [% IF !ctx.is_staff %] + [% INCLUDE 'opac/parts/goog_analytics.tt2' %] + [% END %] [% PROCESS 'opac/parts/stripe.tt2' %] -- 2.43.2