From 7f00e5a3cd285d1c45dd56306eca5ef7c4d3148b Mon Sep 17 00:00:00 2001 From: Thomas Berezansky Date: Fri, 24 Aug 2012 10:48:39 -0400 Subject: [PATCH] Remove broken error message Checkout fills related hold causes an empty array sometimes, so don't throw out errors for that. Also, the original error would itself fail, throwing an error that would then fail as well, likely due to a copy/paste issue. Signed-off-by: Thomas Berezansky Signed-off-by: Ben Shum --- Open-ILS/xul/staff_client/server/admin/transit_list.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Open-ILS/xul/staff_client/server/admin/transit_list.js b/Open-ILS/xul/staff_client/server/admin/transit_list.js index 2d841cec5d..522cecc0e8 100644 --- a/Open-ILS/xul/staff_client/server/admin/transit_list.js +++ b/Open-ILS/xul/staff_client/server/admin/transit_list.js @@ -278,7 +278,8 @@ admin.transit_list.prototype = { var r_ahr = req3.getResultObject(); if (typeof r_ahr.ilsevent != 'undefined') throw(r_ahr); if (r_ahr.length == 0) { - try { obj.error.standard_unexpected_error_alert(document.getElementById('adminStrings').getString('staff.admin.transit_list.empty_array.error') + document.getElementById('adminStrings').getFormattedString('staff.admin.transit_list.empty_array.error', [r_atc.hold(), transit_id]),E); } catch(F) { alert(E); } + // This can apparently happen under normal operating conditions when "checkout fills related hold" is active. + // So don't throw an error, just pretend that it wasn't a hold transit. do_this(r_atc,null); } else { if (instanceOf(r_ahr[0],ahr)) { -- 2.43.2