From 7ecc442a45668db8a8b1e7aab667c1dc6657b934 Mon Sep 17 00:00:00 2001 From: Jason Stephenson Date: Thu, 29 Jan 2015 07:59:07 -0500 Subject: [PATCH] LP#1415898 Fix Potential Cstore Starvation in KPAC The getit_results function in EGKPacLoader.pm does xact_begin, which opens a connected session to a cstore drone. It later does xact_rollback, which does not disconnect the session. This leaves a drone hanging for several seconds unable to responde to new requests. This commit switches to a rollback call that does disconnect the session. Signed-off-by: Jason Stephenson Signed-off-by: Bill Erickson --- Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm index 0598947b62..32e394b594 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm @@ -222,7 +222,7 @@ sub load_getit_results { } else { $e->xact_begin; $ctx->{hold} = $e->retrieve_action_hold_request($hold_id); - $e->xact_rollback; + $e->rollback; } return Apache2::Const::OK; -- 2.43.2