]> git.evergreen-ils.org Git - Evergreen.git/log
Evergreen.git
9 years agoSmall typo fix for Blu-Ray spelling
Kathy Lussier [Fri, 19 Sep 2014 16:07:11 +0000 (12:07 -0400)]
Small typo fix for Blu-Ray spelling

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoUpdated formats
Snigdha Dagar [Thu, 18 Sep 2014 16:27:13 +0000 (21:57 +0530)]
Updated formats

Updated the formats under basic search according to version 2.6

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoLP 1319560: Another fix for summary.tt2.
Jason Stephenson [Mon, 19 May 2014 13:19:49 +0000 (09:19 -0400)]
LP 1319560: Another fix for summary.tt2.

Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.

It was apparently coming from the .size and not where I thought.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP 1319560: Fix the disappearing hold button.
Jason Stephenson [Thu, 15 May 2014 15:31:56 +0000 (11:31 -0400)]
LP 1319560: Fix the disappearing hold button.

Staff discovered an issue with the tt2 changes that caused the
place hold button to disappear when it shouldn't. Changing an &&
back to || seems to fix this.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP 1319560: Silence template error messages in Apache error log.
Jason Stephenson [Wed, 14 May 2014 19:46:29 +0000 (15:46 -0400)]
LP 1319560: Silence template error messages in Apache error log.

We get a number of messages like the following in our Apache error
logs on a constant basis:

Argument "" isn't numeric in addition (+) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 6.
Argument "" isn't numeric in division (/) at
/openils/var/templates/opac/results.tt2 line 1.
Argument "" isn't numeric in numeric ge (>=) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 38.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds/edit.tt2 line 106.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds.tt2 line 42.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/place_hold.tt2 line 98.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopa/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/holds.tt2 line 215.

This commit adds some sanity checking to make those messages go
away.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoFix LP904860, Cannot print a patron address label
Steven Chan [Mon, 29 Jul 2013 23:27:13 +0000 (16:27 -0700)]
Fix LP904860, Cannot print a patron address label

The sequence of events for printing an address label is as follows.
Staff client Code in the util/print.js file builds an HTML page of the
address label.  The page includes two vital components, 1) a source tag
to pull 'print_win.js' file from the server, and 2) an onload event
handler bound to the body tag to execute a 'print_init()' function that
is defined in the source tag.

However, print_init() is undefined because the source tag contains a
badly formed URL. It needs to be prefixed by 'oils://remote' so that the
new 'oils:' protocol can be used to pull the file remotely from the
server.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1331127 Repair sort logic of previous issuances
Bill Erickson [Tue, 17 Jun 2014 19:14:12 +0000 (15:14 -0400)]
LP#1331127 Repair sort logic of previous issuances

Ensure that the list of previous issuances is sorted correctly (on
date_published) when looking for the previous serial.unit to update its
copy location (when serial.prev_issuance_copy_location is enabled).

The data comes sorted from the DB, but the sorting was lost during the
process of unique-ifying the list.  Ultimately, it was relying on the
order of hash keys, which is undefined.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoLP#1370630: don't log mod_deflate actions by default
Galen Charlton [Wed, 17 Sep 2014 17:22:15 +0000 (10:22 -0700)]
LP#1370630: don't log mod_deflate actions by default

This patch comments out logging of mod_deflate actions,
as this is needed only for debugging.  Otherwise,
deflate_log will grow without bound, as it isn't dealt
with by typical default logrotate configs.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1361801: Add required fields to serial issuance form
Remington Steed [Fri, 29 Aug 2014 18:45:50 +0000 (14:45 -0400)]
LP#1361801: Add required fields to serial issuance form

This commit prevents issuances from being created without a date_published
or holding_code. This has two benefits:

  1. Prevents uncaught exceptions related to submitting null values for
     either of those fields.
  2. Requiring date_published prevents an ugly error when trying to
     predict new issuances from an issuance without a date_published.

This commit does NOT provide any feedback to the user about which fields
are required. That would require further investigation into the Dojo/Dijit
objects being used for the edit form fields.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1246859: Improve username flow for staged users
Jeff Godin [Wed, 30 Oct 2013 20:41:06 +0000 (16:41 -0400)]
LP#1246859: Improve username flow for staged users

Staged users in most cases have a username that consists of a UUID.

Rather than leave the UUID as their username or require staff to
clear the field and replace it with a barcode or other value, it
would be better to remove this username when loading the staged user
in the user editor.

This commit clears the username when loading a stage user if the
username looks like a UUID.

If a barcode has been staged for the loaded staged user, the
username will be populated with that value.

If there is no staged barcode, the username will remain blank and
will be populated using the standard method after staff enters a
value in the barcode field.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1356576 repair sip date_format config typo
Bill Erickson [Wed, 13 Aug 2014 20:44:50 +0000 (16:44 -0400)]
LP#1356576 repair sip date_format config typo

Avoids "Use of uninitialized value in bitwise or (|)" error.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP1309131 - Fix series link
Kathy Lussier [Tue, 12 Aug 2014 21:33:16 +0000 (17:33 -0400)]
LP1309131 - Fix series link

Clicking on a series link with a hyphen failed because the hyphen was
stripped and the two words are joined together. This branch changes
series.tts to replace special characters with a space, which is similar to
the links we build for authors.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1325720 Repair fund rollover year selector query
Bill Erickson [Mon, 2 Jun 2014 20:14:38 +0000 (16:14 -0400)]
LP#1325720 Repair fund rollover year selector query

Dojo dojo stores track values as strings, so values used in data store
queries must be coerced into strings before performing the query.

This fixes the year query in the fund rollover UI so that the page is
able to render the results of a rollover without dying from an JS error
before completing.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1292129: Removed deleted call numbers from the search results to properly show...
Steven Callender [Thu, 13 Mar 2014 17:34:23 +0000 (13:34 -0400)]
LP#1292129: Removed deleted call numbers from the search results to properly show copy count.

The SQL in fm_IDL.xml for setting up the reporter source "Hold/Copy
Ratio per Bib" includes deleted call numbers which in turn can give
an incorrect copy count. The ratio appears to still be correct because
deleted copies are considered in the ratio calculation, but not the
copy count that is displayed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP 1350345: marc_export blows up on bad records.
Jason Stephenson [Wed, 30 Jul 2014 13:26:38 +0000 (09:26 -0400)]
LP 1350345: marc_export blows up on bad records.

Add some eval blocks around calls to MARC::Record->as_usmarc and
MARC::Record->as_xml_record to trap errors in bibliograpic and
authority records.

If MARC::Record reports an error, print the record id and the
error message and continue the export.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1358916: refuse to retrieve over-large MARC records via Z39.50
Galen Charlton [Tue, 19 Aug 2014 20:19:20 +0000 (13:19 -0700)]
LP#1358916: refuse to retrieve over-large MARC records via Z39.50

At least one malformed record discovered in the wild can
cause open-ils.search backends to balloon to over 3G of memory
consumption.  This patch works around that by refusing
to process any (MARC) Z39.50 results that are larger than the
MARC record maximum of 99,999 octets.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1340947: Finish support in oils_ctl.sh for -y and -z options
Jason Boyer [Mon, 14 Jul 2014 12:35:39 +0000 (08:35 -0400)]
LP#1340947: Finish support in oils_ctl.sh for -y and -z options

Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1357364: Explictly create the extension in the "public" schema.
Chris Sharp [Fri, 15 Aug 2014 12:58:04 +0000 (08:58 -0400)]
LP#1357364: Explictly create the extension in the "public" schema.

Thanks to Thomas Berezansky for the suggestion!

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1357364: Allow for sites that may have the intarray extension already installed.
Chris Sharp [Fri, 15 Aug 2014 12:51:44 +0000 (08:51 -0400)]
LP#1357364: Allow for sites that may have the intarray extension already installed.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoDocs: Fix filenames to match references in the docs - second time
Josh Stompro [Sat, 13 Sep 2014 02:57:54 +0000 (22:57 -0400)]
Docs: Fix filenames to match references in the docs - second time

This is just like the fix that Remington Steed sent in on Sept 4th.

These images were creating errors for me when I try to create
an epub version of the docs because they are all referenced as .jpg
but the filenames were .JPG.

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: Staff generated penalties documentation
Kate Butler [Fri, 12 Sep 2014 21:55:08 +0000 (17:55 -0400)]
Docs: Staff generated penalties documentation

Signed-off-by: Kate Butler <katebutler@rodgerslibrary.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: Staff initials settings for patron notes
Kate Butler [Fri, 12 Sep 2014 21:52:51 +0000 (17:52 -0400)]
Docs: Staff initials settings for patron notes

Signed-off-by: Kate Butler <katebutler@rodgerslibrary.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoLP#1294269 Docs: Fixed small documentation formatting bugs
SnigdhaD [Thu, 11 Sep 2014 21:13:11 +0000 (17:13 -0400)]
LP#1294269 Docs: Fixed small documentation formatting bugs

Signed-off-by: SnigdhaD <snigdha.dagar@gmail.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoLP#1241644: Remove xact_finish IS NULL checks from CLAIMSRETURNED and LONGOVERDUE
Jason Boyer [Fri, 18 Oct 2013 14:26:26 +0000 (10:26 -0400)]
LP#1241644: Remove xact_finish IS NULL checks from CLAIMSRETURNED and LONGOVERDUE

Makes open-ils.actor.user.checked_out(.count) results agree with
open-ils.storage.actor.user.checked_out(.count) results.

Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agolp1335958 Remove parameters from current checkouts link
Kathy Lussier [Mon, 30 Jun 2014 18:57:29 +0000 (14:57 -0400)]
lp1335958 Remove parameters from current checkouts link

The limit and offset parameters can cause patrons to be stuck in a small
section of their current checkout lists. Let's remove those two parameters
when linking to that list from the patron dashboard.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jim Keenan <jkeenan@cwmars.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoDocs: Fixed small typo in docs/reports/reporter_daemon.txt
Josh Stompro [Tue, 9 Sep 2014 19:44:50 +0000 (15:44 -0400)]
Docs: Fixed small typo in docs/reports/reporter_daemon.txt

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: Updated usage of autogen.sh to not use param 'u'
Josh Stompro [Tue, 9 Sep 2014 19:42:51 +0000 (15:42 -0400)]
Docs: Updated usage of autogen.sh to not use param 'u'

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: update to 'Address Alerts' feature content
Josh Stompro [Tue, 9 Sep 2014 19:21:38 +0000 (15:21 -0400)]
Docs: update to 'Address Alerts' feature content

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoLP#1359934: prevent error opening patron search form
Galen Charlton [Tue, 9 Sep 2014 17:38:40 +0000 (10:38 -0700)]
LP#1359934: prevent error opening patron search form

As a result of the patch for OpenSRF bug 1316245, JSON2js
in the OpenSRF library is now stricter -- in particular, passing
an undefined value to it results in an exception being thrown.

This patch runs with the increased strictness and fixes an
issue where the patron search form was passing an undefined value
to JSON2js.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoDocs: Fix filenames to match references in the docs
Remington Steed [Thu, 4 Sep 2014 19:21:06 +0000 (15:21 -0400)]
Docs: Fix filenames to match references in the docs

These image files were not displaying in the docs because the filenames
and the references used different capitalization. Web URLs are
case-sensitive, so this commit changes the image filenames to be all
lowercase.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoDocs: added Address Alert documentation for local admin menu feature
Josh Stompro [Fri, 29 Aug 2014 17:43:22 +0000 (13:43 -0400)]
Docs: added Address Alert documentation for local admin menu feature

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agolp949101 Hold Columns for Item Status
Michele Morgan [Wed, 27 Aug 2014 19:25:24 +0000 (15:25 -0400)]
lp949101 Hold Columns for Item Status

Fixes display of hold columns in Item Status Holds/Transit tab.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1306675 TPAC maketext default handler
Bill Erickson [Thu, 15 May 2014 15:22:16 +0000 (11:22 -0400)]
LP#1306675 TPAC maketext default handler

Fall back to an unitialized maketext handler, which defaults to the
template language, when OpenILS::WWW::EGWeb::I18N->get_handle fails to
return a response.

Note that why get_handle() returns undef is not yet known.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1010027: tweak patron columns in patron search interface
Jason Etheridge [Mon, 1 Oct 2012 20:49:04 +0000 (16:49 -0400)]
LP#1010027: tweak patron columns in patron search interface

specifically, remove the Mailing Address and Billing Address columns that come
off the actor table, since they are redundant with the Mailing Addr: Address ID
and Billing Addr: Address ID columns that come off the address table.

Also, alphabetize the columns coming directly off of the user table. The columns
coming off the library card and address tables remain unsorted; I believe their
order is as listed in the fm_IDL.xml file for their corresponding fieldmapper
definitions.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1010027: more internal options for xul lists
Jason Etheridge [Mon, 1 Oct 2012 20:46:56 +0000 (16:46 -0400)]
LP#1010027: more internal options for xul lists

specifically, give fm_columns a sort_headers flag for alphabetizing the columns
returned by label; and delete_me flag for omitting a column definition entirely

Not all xul lists are using fm_columns yet

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1189556: stamping upgrade script for URL_VERIFY description typo fix
Ben Shum [Wed, 27 Aug 2014 04:49:48 +0000 (00:49 -0400)]
LP#1189556: stamping upgrade script for URL_VERIFY description typo fix

Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1189556: Fix typo in URL_VERIFY permission description
Chris Sharp [Tue, 11 Jun 2013 14:09:20 +0000 (10:09 -0400)]
LP#1189556: Fix typo in URL_VERIFY permission description

The description for the URL_VERIFY permission contained a typo,
fixed here.

Added an upgrade sql to update the text.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1322341: Count part holds on records
Thomas Berezansky [Fri, 23 May 2014 19:40:23 +0000 (15:40 -0400)]
LP#1322341: Count part holds on records

Also fix a small mistake in metarecord matching

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1277551: Limit simplified pull list to available copies
Thomas Berezansky [Fri, 18 Apr 2014 13:46:13 +0000 (09:46 -0400)]
LP#1277551: Limit simplified pull list to available copies

Copies that are targeted by a hold but are not in available or reshelving
statuses should not show up on a pull list.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1314370: Enable dojo all the time in the catalog
Ben Shum [Wed, 30 Apr 2014 06:02:49 +0000 (02:02 -0400)]
LP#1314370: Enable dojo all the time in the catalog

Because we rely on the dojo framework for the shelving location filter in the
advanced search, we should choose to use dojo everywhere and not just when
autosuggest, google books, or novelist are enabled.

This is a quick change to toggle the flag for want_dojo to be set all the time.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
9 years agoLP1277556 Fast Item Add no longer opens record after copy is created
Blake Henderson [Tue, 1 Jul 2014 22:06:30 +0000 (17:06 -0500)]
LP1277556 Fast Item Add no longer opens record after copy is created

Altered save_attempt to handle undefined and true cases for replace_on_complete
When fastItemAdd is not used, replace_on_complete is undefined
When it is used, and successful, replace_on_complete will be set to true
then we need it to execute result.on_complete()

Signed-off-by: Blake Henderson <blake@mobiusconsortium.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP1084269, LP1050043 Expert Search Fixes
Liam Whalen [Sat, 28 Jun 2014 22:37:28 +0000 (15:37 -0700)]
LP1084269, LP1050043 Expert Search Fixes

Sorting Expert Search corrected

LP1050043 was issued because attempting to sort the MARC expert search
results, in the staff client, caused the staff client to return to the
basic search page rather than sort the results.

To fix the sorting I had to modify two perl files.

metabib.pm had to be changed in a number of ways.

1. The way the sort works currently assumes the user is doing a full
text search.  So, it passes in the values of titlesort and authorsort as
the sort variable in the URL.  However, in the expert search, it is
looking for the values 'title' and 'author'.  This resulted in the title
sort and author sort never being executed and returning the relevance
sort instead. I modified the search to use a regex instead of eq.

2. If a record has no value associated with it e.g. no 260 c for
pubdate, no 245 $a for title, no 1xx $a for author, then the SQL is
supposed to replace those values with either 'AAAA' or 'zzzz' depending
on the order of the sort.  This should cause records without the
relevant sort values to be pushed to the bottom of the sort results.

But, the PgSQL function COALESCE, which is supposed to do the
replacing, does not do anything if no rows are returned for a record's
relevant value.  To work around this, I surrounded the relevant values
with the MAX() function call, which returns NULL if no row is returned.

Because author sort works on any 1xx value, it sorts those values in
numerical order when there is more than one 1xx in a record.  This
requires the use of an ORDER BY statement, which seems to nullify
the effect of MAX().  So, I had to move the MAX() into a second SELECT
statement in the case of author sort.

3. I added the variables number_default_sort and string_default_sort
to the metabib code because the current code hard codes values of
'9999' and 'zzzzzzzz' into the sort.

Search.pm had to be changed to pass the sort values from the TPAC
into the relevant sort subroutines.  This was done with the addition of
an $arghash variable that checks the cgi parameters for the sort
variable.

As well, Expert search puts the tag and _special params in the
search form.  This causes all other searches to perform Expert searches
afterwords.  To fix this, Search.pm is modified to look for an empty
query value before it conducts an Expert search.  If it is empty and
the Expert search variables are present, then the Expert search is
performed.  Otherwise, a normal search is done.

Finally, to fix the problem reported by LP1050043, I had to modify
searchbar.tt2.  Currently, searchbar.tt2 does not have the values from
the Expert search entered into the <form> where the sort functionality
is located.  This means, when a sort option is chosen, the TPAC no
longer knows which values were used for the Expert search.

This is not obvious at first because after choosing to sort, the
user is returned to a page where the URL has the Expert search values
in it.  This happens because the sort is submitting a form without a
query value, so the TPAC redirects the user to the referring page,
which is the initial Expert search.

To fix this, I added the Expert search values as hidden variables
into the <form> where the sort functionality is located.  I also
removed the use of the "_adv" hidden variable from the <form> when
not in the advanced search.

[LP1094269] Retrive past 100 records in Expert Search

Currently, when paging through the results of the Expert search, the
system will not return more than 100 records.  Going past page 10
causes a no results screen.

This is due to the offset and limit values not being passed into the
argument hash used to create the SQL for the search.  Once the SQL
returns, it returns record ids within the range of the offset and
the limit. So, if the offset is 100 and the limit is 10, the record
ids for search results 100 to 109 are returned.

But, because offset and limit are not being passed into the arghash,
they default to 0 and 100 respectively.  This means the first 100
records are always returned regardless of where in the search pages
you are viewing.  These 100 results were then pruned to the relevant
10 results in Biblio.pm.  However, if the offset starts beyond 100
then no results are returned because the results passed 100 are not
returned by metabib.pm.

This commit passes the offset and limit as arguments in the search
hash.  It also removes offset and limit as parameters of the
search.biblio.marc call. Because offset and limit are needed in the
arghash to limit the number of records returned, it is better to
pass them only via the arghash to ensure that no more than the
necessary number of records are returned.

Offset and limit could be kept as parameters, but it would require
modifying metabib as well to look for those parameters, so I think
forcing the Expert search to pass them as argument parameters is the
better option.

As well, this commit removes the pruning in Biblio.pm that was based
on the offset and limit because that is handled in metabib.pm now
that offset and limit are being supplied in the argument hash.

I have checked the source code and the marc_search function in
Biblio.pm is only called via the Expert search in
WWW/EGCatLoader/Search.pm, so modifying Biblio.pm in this manner
will only affect the Expert search and nothing else.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Sarah Childs <sarahc@zionsvillelibrary.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agolp1182605 Add sort value for holds interfaces
Kathy Lussier [Tue, 19 Aug 2014 18:29:56 +0000 (14:29 -0400)]
lp1182605 Add sort value for holds interfaces

Holds interfaces were still sorting incorrectly, so let's add a sort value
there.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agolp1182605 Abstracting out common functionality from code that sorts call numbers...
Victoria Lewis [Wed, 30 Apr 2014 22:09:07 +0000 (15:09 -0700)]
lp1182605 Abstracting out common functionality from code that sorts call numbers by label_sortkey

Code had been added to insure that LC call numbers are sorting as they should by asset.call_number.label_sortkey.
Code was duplicated in the 'call_number column' in the 'columns' group and in the 'hold_columns'group.

I abstracted the logic out of 'sort_value' and 'render' in the 'call_number' column in the 'columns' group and from
'render' in the 'call_number' column in the 'hold_columns' group to a utility function  called
'sort_call_numbers_by_label_sortkey'.

Signed-off-by: Victoria Lewis <vcamklewis@gmail.com>
modified:   xul/staff_client/server/circ/util.js
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoLP1182605 : LC call numbers sort improperly in tabular displays
Kyle Tomita [Mon, 2 Dec 2013 23:50:17 +0000 (15:50 -0800)]
LP1182605 : LC call numbers sort improperly in tabular displays

The issue was that the column was sorting on the label (call number)
and not label_sortkey.  An attribute 'sort_value' was added that used
label_sortkey.

Signed-off-by: Kyle Tomita <tomitakyle@gmail.com>
modified:   Open-ILS/xul/staff_client/server/circ/util.js
(cherry picked from commit 696ce9e6c36bffd1d8c884baab2f5d36687e741b)

Signed-off-by: Victoria Lewis <vcamklewis@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoFix currently harmless but still confusing sigil error
Dan Wells [Mon, 7 Jul 2014 17:16:58 +0000 (13:16 -0400)]
Fix currently harmless but still confusing sigil error

get_org_descendants() returns an array ref, not a list, so it doesn't
make sense to assign it to an '@orgs' variable.  Lucky for us, our
where-parser treats this single element list containing the ref in the
same manner as the proper ref itself, but at best, it is still very
confusing to see.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoLP#1078787 Fix serial scoping in TPAC
Dan Wells [Thu, 8 May 2014 20:18:11 +0000 (16:18 -0400)]
LP#1078787 Fix serial scoping in TPAC

If you have generated holdings, but are not using the "compressed"
display, your holdings show up regardless of scope.  This change
limits the display to only sdists with a holding_lib in your current
search scope.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoLP#800478: Stamping upgrade script for fund transfer fix
Mike Rylander [Mon, 25 Aug 2014 17:44:55 +0000 (13:44 -0400)]
LP#800478: Stamping upgrade script for fund transfer fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#800478 repair logic error in acq fund transfer
Bill Erickson [Tue, 25 Feb 2014 17:23:13 +0000 (12:23 -0500)]
LP#800478 repair logic error in acq fund transfer

The source data for the amount applied to each allocation and transfer
(in certain circumstances) was incorrect.

The transfer amount should not be the total amount allocated from the
source to the fund, but instead the amount of the funding source credit
in cases where we have to pull money from multiple funding source
credits.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoDocs: Removed use of deprecated file suffix for eg_db_config in install docs
Yamil Suarez [Tue, 19 Aug 2014 21:13:08 +0000 (17:13 -0400)]
Docs: Removed use of deprecated file suffix for eg_db_config in install docs

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: various AsciiDoc formatting fixes for docs
Yamil Suarez [Thu, 7 Aug 2014 21:51:22 +0000 (17:51 -0400)]
Docs: various AsciiDoc formatting fixes for docs

Fixed the 'bad first character' error, the bad apostrophe error. Removed various UTF-8 chars.
Fixed some numbered list formatting, to take out redundant manual numerals…

for example:

. 1 item
. 2 item
. 3 item

became:

. item
. item
. item

also added "+" to wrap around breaks in numbered lists

for example:

. Right-click on the value control for the fixed field that needs to be edited.

 image::media/ffrc1.jpg[]

 . Select the appropriate value for the fixed field from the menu options.

 became:

  . Right-click on the value control for the fixed field that needs to be edited.
  +
  image::media/ffrc1.jpg[]
  +
  . Select the appropriate value for the fixed field from the menu options.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: Improved AsciiDoc formating for tpac_meta_record_holds.txt
Yamil Suarez [Thu, 7 Aug 2014 17:36:20 +0000 (13:36 -0400)]
Docs: Improved AsciiDoc formating for tpac_meta_record_holds.txt

Replaced curly apostrophe with a straight one. Removed manual numbered list.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoOpenSRF Services Update
Kathy Lussier [Thu, 7 Aug 2014 17:40:03 +0000 (13:40 -0400)]
OpenSRF Services Update

Updating list of Evergreen-specific OpenSRF services as of 2.6. Many
thanks to Galen Charlton for providing me with an updated list.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoLP#1339190: Have Evergreen save authtoken state to support IO::Multiplex mode
Mike Rylander [Wed, 9 Oct 2013 15:36:52 +0000 (11:36 -0400)]
LP#1339190: Have Evergreen save authtoken state to support IO::Multiplex mode

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoLP#1339190: support disconnection for SIP multiplex purposes
Mike Rylander [Wed, 11 Sep 2013 20:02:24 +0000 (16:02 -0400)]
LP#1339190: support disconnection for SIP multiplex purposes

This patch adds a disconnect method to close the OpenSRF
connect; this method is invoked only when the Net::Server::Multiplex
personality is in use.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoLP#1302207 - Attempt to validate ISBNs in AddedContent.pm.
Jason Stephenson [Wed, 9 Jul 2014 20:34:26 +0000 (16:34 -0400)]
LP#1302207 - Attempt to validate ISBNs in AddedContent.pm.

When getting ISBNs from the database, they often contain extra stuff
after the ISBN that sometimes causes problems for Business::ISBN.

This commit attempts to resolve some of that by looking only for the
part of the ISBN data that resembles an ISBN and using just that part.
If the ISBN data doesn't look like an ISBN, then it is discarded.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1302207 - Order AddedContent identifiers
Thomas Berezansky [Fri, 11 Apr 2014 20:05:07 +0000 (16:05 -0400)]
LP#1302207 - Order AddedContent identifiers

When multiple exist coming out in a consistent order is preferred.

In this case, use ID order.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoDocs: How to create routing list and shows address on routing list
Erica Rohlfs [Wed, 6 Aug 2014 20:22:24 +0000 (16:22 -0400)]
Docs: How to create routing list and shows address on routing list

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: How to use MARC Fixed Field Editor
Erica Rohlfs [Wed, 6 Aug 2014 20:21:16 +0000 (16:21 -0400)]
Docs: How to use MARC Fixed Field Editor

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: How to perform metarecord search and hold
Erica Rohlfs [Wed, 6 Aug 2014 20:20:42 +0000 (16:20 -0400)]
Docs: How to perform metarecord search and hold

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: MARC Record Attribute Definitions, Multi Valued Fields, Composite Record Attributes
Erica Rohlfs [Wed, 6 Aug 2014 20:19:25 +0000 (16:19 -0400)]
Docs: MARC Record Attribute Definitions, Multi Valued Fields, Composite Record Attributes

Defines RADS, MVF, and CRA and explains how to modify

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: How to use the MARC 007 Physical Characteristics Wizard
Erica Rohlfs [Wed, 6 Aug 2014 20:17:11 +0000 (16:17 -0400)]
Docs: How to use the MARC 007 Physical Characteristics Wizard

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocs: Fix patron registration screenshot
Remington Steed [Wed, 6 Aug 2014 12:47:40 +0000 (08:47 -0400)]
Docs: Fix patron registration screenshot

The previously committed screenshot contains site-specific information
which is not broadly beneficial. This commit replaces it with a more
generic screenshot.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoDocs: Update commands for authority importing script
Remington Steed [Tue, 5 Aug 2014 15:23:20 +0000 (11:23 -0400)]
Docs: Update commands for authority importing script

The tools used for importing authority records from the command line have
been modified since the original docs were written. Testing revealed these
changes, which are reflected in this commit.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoDocs 2.6: Update screens for register/edit patron
Remington Steed [Tue, 5 Aug 2014 13:29:40 +0000 (09:29 -0400)]
Docs 2.6: Update screens for register/edit patron

Update screenshots and wording to reflect new "Update Expire Date" button.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoFix 030.schema.metabib.sql breakage.
Jason Stephenson [Wed, 6 Aug 2014 13:18:37 +0000 (09:18 -0400)]
Fix 030.schema.metabib.sql breakage.

The fix for LP 1322285 introduced a change to 030.schema.metabib.sql
that was not only not needed, but breaks building a fresh schema.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoStamping upgrade script for LP 1322285.
Jason Stephenson [Mon, 4 Aug 2014 17:05:10 +0000 (13:05 -0400)]
Stamping upgrade script for LP 1322285.

Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
9 years agoAdd release notes for the no fixed field default upgrade.
Jason Stephenson [Mon, 4 Aug 2014 16:57:52 +0000 (12:57 -0400)]
Add release notes for the no fixed field default upgrade.

A reingest is recommened after running the database script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
9 years agoLP#1322285: Exclude default values for fixed fields when ingesting
Mike Rylander [Fri, 20 Jun 2014 13:29:56 +0000 (09:29 -0400)]
LP#1322285: Exclude default values for fixed fields when ingesting

Default values for fixed fields that can exist in either 008 or 006
will cause search to be over-broad.  So, we avoid including those now.

I also took the time to move the baseline schema around a bit in order
to keep related code in more appropriate files and avoid continuously
redefining functions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
9 years agoLP#1348731: have SIP gateway use a login nonce
Bill Erickson [Tue, 8 Oct 2013 19:58:56 +0000 (15:58 -0400)]
LP#1348731: have SIP gateway use a login nonce

Since multiple SIP clients may use the same credentials, avoid the
same-username race condition to authentication by applying a login nonce
value.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#1348731: Optional Auth login nonce to differentiate same-username logins
Bill Erickson [Tue, 8 Oct 2013 19:52:12 +0000 (15:52 -0400)]
LP#1348731: Optional Auth login nonce to differentiate same-username logins

If multiple login attempts are made using the same username within a
very short period of time, a race condition exists where, upon
completion of the first login, the auth init cache data for any pending
logins are removed, since there can only be one instance of cached init
data per username.

This adds support for allowing the caller to pass in a random string
which is added to the cache key as a way to differentiate between logins
using the same username.

The seed is passed into auth init as an optional secondary parameter
and passed again (via the "nonce" argument) to auth complete to ensure
consistent cache keys across both interactions.

Example:

my $nonce = rand($$);

my $seed = request(
    'open-ils.auth',
    'open-ils.auth.authenticate.init', $username, $nonce );

my $response = request(
    'open-ils.auth',
    'open-ils.auth.authenticate.complete',
    {
        username => $username,
        password => md5_hex($seed . md5_hex($password)),
        type     => 'opac',
        nonce    => $nonce
    }
);

The race condition has been observed with the SIP2 gateway when
multiple devices have been configured to use the same account.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#1341703 Thinko in Batch Edit (hidden by older OpenSRFs)
Mike Rylander [Mon, 14 Jul 2014 18:57:38 +0000 (14:57 -0400)]
LP#1341703 Thinko in Batch Edit (hidden by older OpenSRFs)

There's a bug on line 272 of O::A::Cat.pm where we called a non-existent
method named respond_complete on the invocant object. Instead, we need to
call that on the client object (spelled $conn in this method). Batch bib
edit won't work on new OpenSRF's until this is fixed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoForward-port 2.6.2 upgrade script
Dan Wells [Mon, 14 Jul 2014 21:21:48 +0000 (17:21 -0400)]
Forward-port 2.6.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoForward-port 2.5.6 upgrade script
Dan Wells [Mon, 14 Jul 2014 21:18:20 +0000 (17:18 -0400)]
Forward-port 2.5.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoDocumentation: updated some SIP content
Yamil Suarez [Wed, 9 Jul 2014 21:23:49 +0000 (17:23 -0400)]
Documentation: updated some SIP content

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocumentation: added AsciiDoc version of old SIP docs from EG 1.6/2.0 docs
Yamil Suarez [Wed, 9 Jul 2014 01:13:07 +0000 (21:13 -0400)]
Documentation: added AsciiDoc version of old SIP docs from EG 1.6/2.0 docs

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocumentation: Upgrade instructions examples
Remington Steed [Wed, 9 Jul 2014 19:40:00 +0000 (15:40 -0400)]
Documentation: Upgrade instructions examples

This commit adds a note (with examples) about upgrading the database schema
across major versions. It also reformats a long line into multiple lines,
changes a NOTE to a TIP, makes a small correction, and replaces a repetitive
command with a short explanation.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoLP#1339767: follow-up: Thumbs.db, not Thumbs.DB
Galen Charlton [Wed, 9 Jul 2014 16:07:32 +0000 (09:07 -0700)]
LP#1339767: follow-up: Thumbs.db, not Thumbs.DB

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1339767: add Thumbs.DB to .gitignore
Galen Charlton [Wed, 9 Jul 2014 15:47:09 +0000 (08:47 -0700)]
LP#1339767: add Thumbs.DB to .gitignore

Removes a minor annoyance for documenters who use recent
versions of Windows

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoForward port 2.5.5 and 2.6.1 upgrade scripts
Dan Wells [Fri, 6 Jun 2014 13:19:58 +0000 (09:19 -0400)]
Forward port 2.5.5 and 2.6.1 upgrade scripts

Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoDocumentation: Add the authentication proxy chapter
Robert Soulliere [Thu, 3 Jul 2014 15:18:15 +0000 (11:18 -0400)]
Documentation: Add the authentication proxy chapter

- Some content taken from the 2.2 release notes.
- Added a few steps on how to set up authentication proxy in Evergreen.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
9 years agoLP#968514: Revive bib/auth importing docs from 2.1, add intro
Remington Steed [Fri, 6 Jun 2014 15:59:58 +0000 (11:59 -0400)]
LP#968514: Revive bib/auth importing docs from 2.1, add intro

This commit revives the following sections from the 2.1 version of the docs
and updates them for 2.6:

  - marc_export: Exporting Bibliographic Records into MARC files
    - includes new options for 2.6
  - Importing Authority Records from Command Line
  - Importing Authority Records from the Staff Client

The first two are included in a new section called "Support Scripts"
within the "Developer Resources" section, with a new intro and summary
of other commonly used scripts provided with Evergreen. The third section
is moved inside the Cataloging chapter "Batch Importing MARC Records",
with slight modifications to the intro to that chapter.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoDocs: Minor wording change
Erica Rohlfs [Fri, 30 May 2014 19:12:29 +0000 (15:12 -0400)]
Docs: Minor wording change

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
9 years agoDocumentation: Update upgrade instruction for 2.6.1
Robert Soulliere [Wed, 2 Jul 2014 18:57:16 +0000 (14:57 -0400)]
Documentation: Update upgrade instruction for 2.6.1

- Update location references for 2.6.1.
- Update database updates to include 2.6.1 update.
- Add a note regarding reingesting bib records after updates.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
9 years agoDocumentation: added "search URL" text inside of "using OPAC" section
Yamil Suarez [Tue, 1 Jul 2014 18:58:33 +0000 (14:58 -0400)]
Documentation: added "search URL" text inside of "using OPAC" section

Replaces temporary text that was accidentally added to the "using OPAC" section.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocumentation: Added 'Using the OPAC' documentation & OPAC WCAG support mention
Yamil Suarez [Mon, 30 Jun 2014 22:05:40 +0000 (18:05 -0400)]
Documentation: Added 'Using the OPAC' documentation & OPAC WCAG support mention

Older DocBook content that covered how to do searches on the OPAC was updated
to use Asciidoc. Also a simple mention of the 2.6 OPAC WCAG support was added.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
9 years agoDocumentation for Located URI Visibility
Kathy Lussier [Fri, 27 Jun 2014 19:31:56 +0000 (15:31 -0400)]
Documentation for Located URI Visibility

Documentation for the new visibility options available for Located URI's
in 2.6.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
9 years agoFix syntax in filter_group_selector.tt2
Dan Wells [Thu, 26 Jun 2014 21:46:30 +0000 (17:46 -0400)]
Fix syntax in filter_group_selector.tt2

Attempt to fix build breakage introduced by 7e4e9d669

Signed-off-by: Dan Wells <dbw2@calvin.edu>
9 years agoLP#1326149 Use a TPAC-settable TIME_FORMAT for local time formats
Dan Scott [Wed, 4 Jun 2014 17:09:48 +0000 (13:09 -0400)]
LP#1326149 Use a TPAC-settable TIME_FORMAT for local time formats

We had tried to use the format.time library setting, but that is meant
for Dojo which uses the Unicode formats, that are incompatible with
the POSIX strftime() formats required by Template::Plugin::Date.

At the same time, we need to expose the raw machine-readable time
for schema.org consumers, so express that in a @content attribute.

And we might as well use a more meaningful <time> element instead of
the meaningless <span>, just for good measure.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 Remove duplicate title attributes
Bill Erickson [Fri, 30 May 2014 16:55:47 +0000 (12:55 -0400)]
LP#1301599 Remove duplicate title attributes

Thanks to Ben Shum for spotting these!

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 Additional TPAC facets structure markup
Bill Erickson [Thu, 10 Apr 2014 20:59:14 +0000 (16:59 -0400)]
LP#1301599 Additional TPAC facets structure markup

Labeling facets with <h4> tags provides additional page structure for
screen readers in the TPAC results pages.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 TPAC replace aria-label with title
Bill Erickson [Thu, 10 Apr 2014 20:49:36 +0000 (16:49 -0400)]
LP#1301599 TPAC replace aria-label with title

As appropriate, replace aria-label attributes with traditional HTML
title attributes.

For ref, from the LP entry:

http://www.w3.org/TR/2013/WD-aria-in-html-20131003/#first-rule-of-aria-use

"If you can use a native HTML element [HTML5] or attribute with the
semantics and behaviour you require already built in, instead of
re-purposing an element and adding an ARIA role, state or property to
make it accessible, then do so."

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 TPAC add missing metabib filter label
Bill Erickson [Thu, 3 Apr 2014 18:53:36 +0000 (14:53 -0400)]
LP#1301599 TPAC add missing metabib filter label

In the quick search bar along the top.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 TPAC advanced search from labels
Bill Erickson [Thu, 3 Apr 2014 17:31:29 +0000 (13:31 -0400)]
LP#1301599 TPAC advanced search from labels

Instead of using titles / aria-labels directly on advanced search
selectors, provide selector IDs so the existing text labels can be
turned into <labels> and linked (by id) to their form control.

This means we only need one label per form control, which improves
usability from an accessibility perspective.

Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 TPAC advanced search additional labels
Bill Erickson [Wed, 2 Apr 2014 20:46:25 +0000 (16:46 -0400)]
LP#1301599 TPAC advanced search additional labels

Provides a number of labels, primarily for select widgets, in the TPAC
advanced search form for improved accessibility.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#1301599 TPAC result table accessibility improvements
Bill Erickson [Wed, 2 Apr 2014 20:43:49 +0000 (16:43 -0400)]
LP#1301599 TPAC result table accessibility improvements

* Give the main result table a screenreader-only header to describe the
  table columns.
* Set the role=presentation in one of the sub-tables used only for
  layout.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#925776 Add placeholder script for backport to 2.5 for function staff uri visibility
Ben Shum [Thu, 26 Jun 2014 19:33:30 +0000 (15:33 -0400)]
LP#925776 Add placeholder script for backport to 2.5 for function staff uri visibility

Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#925776 Stamping upgrade script for staff uri visibility
Ben Shum [Thu, 26 Jun 2014 19:30:26 +0000 (15:30 -0400)]
LP#925776 Stamping upgrade script for staff uri visibility

Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#925776 Adding upgrade script
Mike Rylander [Fri, 2 May 2014 13:42:28 +0000 (09:42 -0400)]
LP#925776 Adding upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoLP#925776: Recheck located uri visibility
Mike Rylander [Fri, 2 May 2014 13:10:09 +0000 (09:10 -0400)]
LP#925776: Recheck located uri visibility

Previous to this commit, once we have determined that there are no
local Located URIs or foreign copies, we include the record in the
result set in the staff client.  However, the desire of library staff
is that foreign Located URIs be valid as a visibility limiter.  So
we now recheck at the end for that situation.  This honors the new
"Located URIs act like copies" global flag.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>