Remington Steed [Fri, 6 Jun 2014 15:59:58 +0000 (11:59 -0400)]
LP#968514: Revive bib/auth importing docs from 2.1, add intro
This commit revives the following sections from the 2.1 version of the docs
and updates them for 2.6:
- marc_export: Exporting Bibliographic Records into MARC files
- includes new options for 2.6
- Importing Authority Records from Command Line
- Importing Authority Records from the Staff Client
The first two are included in a new section called "Support Scripts"
within the "Developer Resources" section, with a new intro and summary
of other commonly used scripts provided with Evergreen. The third section
is moved inside the Cataloging chapter "Batch Importing MARC Records",
with slight modifications to the intro to that chapter.
Jeff Godin [Wed, 30 Oct 2013 17:17:25 +0000 (13:17 -0400)]
Add alert in user editor for method errors
Add an alert() in the user editor so that method errors are not
silent.
Without this, a method error (such as when saving a patron fails at
the db level) is silent. Better to at least inform the user that
something is amiss.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Sat, 22 Mar 2014 01:05:14 +0000 (21:05 -0400)]
LP#1115599: Ignore canceled lineitems during batch cancel
Continue ignoring already-canceled lineitems during batch cancel so that
a) no unnecessary calls are made and b) staff can be alerted when no
viable lineitems were selected for the requested action.
Kathy Lussier [Wed, 29 Jan 2014 22:07:29 +0000 (17:07 -0500)]
LP#1115599: Allow cancelled lineitems to be received and invoiced
Acquisitions staff need to be able to receive and invoice cancelled items,
particularly when those items are backordered. This branch restores the
ability to perform these actions on cancelled lineitems from the PO
screen.
Remington Steed [Tue, 25 Mar 2014 13:30:38 +0000 (09:30 -0400)]
Change xref syntax to avoid docs processing bug
The current Documentation processing script can't handle the newer xref
syntax for cross references. Let's use the older syntax for now, and
consider changing over in the future, after the processing bug is fixed.
Remington Steed [Thu, 20 Mar 2014 19:52:30 +0000 (15:52 -0400)]
Docs: Revive/merge content into "Using the Staff Client"
This commit brings in three old sections and merges with any similar
content.
- Revive old section about sticky check box settings
- Merge old section about Font and Sound settings
Adds a brief section about zooming in the OPAC, and otherwise only
reformats some lines to make them git-friendly.
- Docs: Fix and copy Customize Toolbars section
The old "Customizable Toolbar" docs section is already revived in the
Evergreen Book "System Configuration and Customization" chapter. Since
this feature seems to belong under "Using the Staff Client ->
Workstation Administration", this commit duplicates it into that
chapter. This also fixes a few asciidoc bugs in both places.
In addition, the section "Button Bar/Toolbar" that was also under
"Workstation Administration" has been moved up a level, since it
pertains more to staff client users rather than admins. And the
admin-specific content at the end of that section has been replaced
with a link to the newly duplicated "Customizable Toolbar" section.
The preamble to the installation instructions, intended for
developers, is a bit unclear. The instructions describe actions
that should take place at two different points in the installation.
This commit moves the instructions to download and install the Dojo
Toolkit until after the opensrf Linux user already owns the
/openils directory. It also adds the appropriate note for non-devs
to skip this section.
Signed-off-by: Elliot V <evoris@slcconline.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Mike Rylander [Sun, 2 Mar 2014 21:29:27 +0000 (16:29 -0500)]
Calculate proximity in the DB for speed
We need to calculate and store a (potenially adjusted) proxmity for
each hold and copy for use in targetting and optimization of op
capture. Before this commit, we do that within the hold target
code itself. Now we'll do it when the hold-copy map is inserted,
because we have the same information available at that time as we
have in the targeter. This will both speed up the apparent cost of
the calculation, because it avoids the cost of a network round-trip,
and the total number of SELECTs we must issue, because the proximity
value will now be cached for use by the proximity map function.
Backward compatability is retained for the create_prox_map() function
in case any other code is depending on that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Dan Scott [Fri, 25 Oct 2013 17:54:35 +0000 (13:54 -0400)]
Add pgTAP test for normalized MARC records
Specifically, we're concerned about ensuring that any changes related to
the fix for Encode (requiring the removal of the effectively useless but
now erroring decode_utf8()) do not inadvertently change the content of
the MARC records on ingest. Because we wouldn't want to have to reingest
everything to normalize search, etc.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Conflicts:
Open-ILS/src/sql/Pg/t/README
Dan Scott [Mon, 21 Oct 2013 15:58:06 +0000 (11:58 -0400)]
Encode.pm change to the UTF8 flag
In the past, decode_utf8() silently ignored attempts to decode data
with the UTF8 flag on. However, Encode.pm changed around 2.53 and
resulted in wide-character errors preventing the likes of
--load-all-sample from working.
Since our data should already be UTF8 when it hits these functions, we
should not be trying to decode it in the first place.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
Open-ILS/src/perlmods/lib/OpenILS/Utils/Normalize.pm
Ben Shum [Sat, 8 Feb 2014 08:42:07 +0000 (03:42 -0500)]
LP1125471 - Use label instead of id in recording in-house use prompt
When recording multiple in-house use with the library settings for threshold
prompts, the prompt would bring up the ID as the variable instead of the name
of the non-cataloged material. This caused confusion among staff members who
might see a message like: "Are you sure you want to mark 9 as having been used
21 times?" (9 being the id, not the name of the non-cataloged material)
This commit leverages existing code which had been commented out and under
the ID to use the label name for the non-cataloged material instead. Also,
minor bugfix with a missing semi-colon at the end of the function being used.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Mon, 30 Dec 2013 18:49:01 +0000 (13:49 -0500)]
Vandelay: increase queued item creation timeout
Allow up to 10 minutes to create each queued vandelay record to avoid
timeouts in item creation caused by pathologicaly long-running record
match set queries.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Mike Rylander [Thu, 12 Sep 2013 17:26:21 +0000 (13:26 -0400)]
Keep standard INNER joins above possible OUTERs
We always join metabib.record_attr, and we always use an INNER join
to the core table, so keep that join first. Likewise with the join
to biblio.record_entry. Dynamic joins may be OUTER, though, and while
join reordering in Postgres is smart, let's not give it the chance to
fail.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 9 Nov 2012 21:12:58 +0000 (16:12 -0500)]
Prevent odd TPAC base URL redirect
As it stands, in a default install, if you browse to
http://yourserver.com/eg/opac
you are redirected to a login page, and if you login, you then get
to the 404 page. This behavior is caused by the fact that *any*
URLs which do not match a few select cases are assumed to be
"secure" resources, when in fact they might not even exist.
This commit catches any attempt to browse this 'base' and simply
redirects to the "home" page instead.
This addresses the most obvious and likely 404 of this type, but
we might consider catching some other cases (e.g. eg/opac/record/).
In addition (or as an alternative), we could also create a function
call which simply checks the validity of a URL before we ask the
user to login to see it.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Mike Rylander [Fri, 7 Feb 2014 21:00:01 +0000 (16:00 -0500)]
Include calculated 0-prox locations in the stalling interval for op capture
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
Mike Rylander [Tue, 21 Jan 2014 17:31:13 +0000 (12:31 -0500)]
Use copy owning library as the context for finding best hold sort order setting
In the olden days before best hold sort order and proximity adjustment, there was
no need to consider any context org other than "here", because the choices were,
essentially, FIFO or Traditional applied within the hard-boundary range. However,
now we need to decided whose rule to follow, and the most correct arbiter of that
is the owning library of the call number of the copy. We avoid copy circ lib
because that can change with floating copies.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Form submission for list creation with an empty name value now prevents
list creation and redirects the user to a new error page explaining why
list creation failed.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Jeff Godin [Wed, 30 Oct 2013 17:20:28 +0000 (13:20 -0400)]
Skip duplicate username check when username unchanged
Changing a username, then changing back to the user's current
username results in a duplicate username detection -- a false
positive due to the API call finding a user with that username --
the current user. This prevents you from saving any other changes
you may have made to the user.
This can be prevented by skipping the duplicate username check if
the user is not new and the username in the field matches the
username stored in the in-memory Javascript representation of the
user.
There's still a potential corner case which could be avoided by
using a new/modified API call to either accept an "except this
au.id" argument or to return the au.id of the found user, but I
don't see a need for that at this point.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Tue, 21 Jan 2014 18:52:49 +0000 (13:52 -0500)]
LP1271218 - clarify how opt-in user notifications are shown in my account
As reported in LP127128, end users may not need to be shown the message that
"No notification preferences are configured" when in fact this message is only
displayed when the user opt-in notification settings are not configured.
So, alter this to only show the table and div when there are settings to be
configured and otherwise show nothing.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Remington Steed [Wed, 27 Nov 2013 14:55:35 +0000 (09:55 -0500)]
LP#842991 Reports needs to error when deleting fails
When attempting to delete a report template, the reports interface
incorrectly shows "Action Succeeded" even when it partly fails. If the
user performing the delete does not own all the dependent reports and
outputs, then the perl function returns 1 to indicate that some were
deleted, but not all. However, the javascript that calls that function
does not check for a return value of 1. This commit adds that check, and
also improves the formatting of the related error messages.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Steven Callender [Thu, 10 Oct 2013 20:09:06 +0000 (16:09 -0400)]
Fixed title/author display at checkout for non-pre-cat items.
Fixed a display problem on checkout where items that were formely pre-cats
were still displaying the pre-cat data. Now it will make sure the item is
still a pre-cat before using the dummy data.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Serials: Batch Receive interface Copy Location widget was inert
Choosing a value from the Copy Location widget wasn't working. You'd
get a default copy location (or the one supplied by the Receive Unit
Copy Template) no matter what you set that control too.
This is fixed. One does not read from XUL menulist element by using its
'value' property.
LP#882586: In Serial Control View, show copy templates owned by ancestors
When creating/editing distributions, dropdowns for Receive Unit Template
and Bind Unit Template now show copy templates owned not only at the
distribution's holding lib, but at any of the holding lib's ancestors.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Fri, 4 Oct 2013 21:44:56 +0000 (14:44 -0700)]
LP#1235474: fix failure of authority browse context menu to render
This patch fixes a situation where if an authority record that would
be brought up by the authority browse context menu in the MARC editor
lacks an 003 field, the context menu would not be rendered all, meaning
that the default context menu (e.g., cut/copy/paste/etc.) would be
displayed instead.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Thu, 16 Jan 2014 18:58:12 +0000 (13:58 -0500)]
Fix proximity adjustment calculator
The canonical use case for proximity adjustment is to use it broadly
to effect the local proximity of items within a particular area, in
a like manner, across many parts of the org tree. However, in cases
where it is lightly used, or used with non-overlapping criteria columns,
there are cases where the adjustment will spread beyond its intended
range of influence.
The changes here create a much stricter and correct test for rule
matching, which will end in the correct choice of rules in all cases.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
In prereq installer, don't try to chown extracted files to original UID/GID
As this Makefile is designed to be used by a make process running as
root, this will avoid problems on some systems when tar extracts
files and tries to give them the same UID/GID as they have in their
archives, but those accounts don't exist on the local system.
e.g, libdbi has files set 1000/1000. On most systems, there's a user
and a group with these IDs, but there can be systems where nothing
uses those IDs, and where tar fails with e.g. 'tar: libdbi-0.8.3:
Cannot change ownership to uid 1000, gid 1000: Invalid argument'
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Tue, 14 Jan 2014 18:30:48 +0000 (13:30 -0500)]
LP#1234201: fix menu item to display patron requests (if summary is horizontal)
This patch adds a missing command element to the horizontal
patron summary display so that the 'Acquisition Requests' menu
item will work.
To test:
[1] Set the Patron circulation summary is horizontal library setting
to true.
[2] Retrieve a patron and try using the Acquisition Requests menu
item. It will do nothing.
[3] Apply the patch and clear cache in the staff client.
[4] Repeat step 2. This time, the Acquisitions Request menu item
should bring up the list of the patron's requests.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Srey Seng <sreyseng@gmail.com>
Galen Charlton [Tue, 14 Jan 2014 16:00:38 +0000 (11:00 -0500)]
LP#1269042: prevent acq seach from building dropdown of every copy ID in the DB
This patch ensures that if a user sets a search field in the
acquisitions general search form to the line item details copy ID
(labeled "LID - Evergreen Copy ID"), the form presents a normal
input widget rather than trying to build a drop-down containing
every copy ID in the database. Except for very small databases,
the previous behavior would mean that an open-ils.pcrud backend
would eventually consume a great deal of memory trying to service
a request for all copies in the system.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jeff Godin [Wed, 30 Oct 2013 19:29:24 +0000 (15:29 -0400)]
Treat empty username as invalid in user editor
There seems to be undesired interaction between the required
attribute and the isValid method on a dojo/dijit ValidationTextBox.
If both are set, isValid needs to check for an empty value,
otherwise the field is considered valid the moment it gains focus.
We don't want an empty username to be considered valid, because we
know that we will be unable to save the user.
We can work around this by teaching the isValid function to consider
an empty value as invalid.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Melissa Ceraso <mceraso@biblio.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Srey Seng [Tue, 7 Jan 2014 22:30:49 +0000 (14:30 -0800)]
LP#1266937: Fix missing/incorrect regex for authority in Vandelay.pm
Add in missing "~" in function import_record_list_impl when
type is authority records. Also replace "auth" with "authority"
so that the generated values match up with functions in the
database.
Signed-off-by: Srey Seng <sreyseng@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Chris Sharp [Wed, 8 Jan 2014 19:51:59 +0000 (14:51 -0500)]
fix pub date data type in reporter.classic_item_list
As noticed by Ben Shum in IRC, reporter.classic_item_list
had pub_date, a free text field, classified as "int". This
changes that to "text" to prevent errors.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Jeff Davis [Wed, 8 Jan 2014 21:21:13 +0000 (13:21 -0800)]
Fix bug that caused deleted holdings to be visible in SRU/Z39.50 results
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
Galen Charlton [Mon, 25 Nov 2013 18:05:21 +0000 (10:05 -0800)]
LP#1254816: prevent cases where a Google Book preview is not displayed
Due to quirks in how different parts of the Google Books API
processes ISBN searches, it is possible for a Google Books Preview
badge to get displayed, but when the user tries to display the preview,
the embedded preview does not get displayed.
This patch fixes the problem by grabbing the preview link from
the GB volumes search results, which in turn can be fed into the
Embedded Viewer initialization.
An ISBN that can be used to reproduce the problem is 9781937994198.
Before the patch, the badge is displayed but not the preview; after
the patch, both badge and preview should be displayed.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Steven Chan [Wed, 15 May 2013 21:30:15 +0000 (14:30 -0700)]
Fix LP1180140, View Holds not working for a serial with subscription and no issuances
A request is made to
open-ils.circ.holds.retrieve_all_from_title,
which is the function Circ/Holds.pm/all_rec_holds().
In the function, when checking for issuance holds, there is a missing @
to dereference the list of issuance IDs, so that the ahr table is search
with badly formed input, which results in returning an undefined list
instead of an empty list. The error will occur for any record with a
serial.subscription entry but with no related entries in
serial.issuance.
We also recode the initialization of the response object in order to
clarify its expected structure, a hash of array references.
Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Remington Steed [Thu, 21 Nov 2013 15:29:22 +0000 (10:29 -0500)]
Docs: integrate holds docs from EG 2.1
The small amount of Holds docs present in master seemed to fit well at
the end of the older Holds documentation, so this commit appends them
to the new holds.txt file, deletes the previous holds_management.txt file,
and makes the appropriate change to root.txt.
This commit also includes several small formatting improvements, wording
changes, and bug fixes.
Mike Rylander [Wed, 13 Nov 2013 23:15:21 +0000 (18:15 -0500)]
Fix boolean lists; Better atom regex; Caching
First, we didn't need to make $last_type local, and it broke explicit
grouping anyway. That's removed, and we now reset that (and a few more
like it) at calls to the top level parse() method. This introduces a
situation where a long list of booleans could cause query plan problems,
so we limit the plan depth to 40 (20 ||'d conditions).
Second, we are smarter about finding the boundary of atoms. Previous
to this commit, and curly brace could send the parser into a tailspin
from which it would not recover. Now we use alternation instead of
a character class, which is much safer with the default multi-character
float syntax specifier.
Third, as a catch-all, if we can't parse the remained of a query we
now simply say so (when in debug mode) and go away, instead of risking
an infinite loop. We do this via a final, unqualified "else" clause
in decompose().
Finally, instead of building 10+ regexp objects on each query parse,
cache them per QP subclass and reuse them.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Mon, 25 Nov 2013 15:14:08 +0000 (10:14 -0500)]
Re-apply the changes provided by 0802 for backport
Preserve record order of subfields for authority heading extraction
When extracting headings from authority records we currently read the
subfields of a tag in configuration order. We should, instead, read
them in record order, to preserve the desired sorting properties that
the cataloger has encoded in the record.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 22 Nov 2013 19:55:26 +0000 (14:55 -0500)]
LP#1254146 gracefully handle custom trees sans entries
Avoid references to custom tree entries when no tree entries for a
custom tree exist. Prevents:
egweb: template error: undef error - Can't call method "org_unit" on an
undefined value at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader/Util.pm line 185.\n
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 3 Oct 2013 21:54:03 +0000 (17:54 -0400)]
Relax MFHD subfield 'a' requirement for caption/patterns
If going by the book, every caption/pattern field would have a
subfield 'a', since the data from subfield 'i' would be moved to
'a' if 'a' was empty. Since that is arcane, and our own wizards
used to bend this rule, let's make some minor adjustments to our
expectations:
1) When calculating date progression, don't expect there to be an 'a'
subfield which needs to be "carried" into.
2) When determining whether a field is 'open-ended', check the first
availabile enum/chron subfield rather than hard-coding the check to
'a'.
These changes do not affect the display formatters, so strings
generated from 'a'-less caption/pattern combos are not exactly right,
but they suffice.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Mike Rylander [Fri, 15 Nov 2013 21:40:36 +0000 (16:40 -0500)]
Enforce one-payment-per-xact-per-call
There is no legitimate reason for a transaction to receive more than
one payment per call to open-ils.circ open-ils.circ.money.payment,
but we have seen the staff client generate such a data structure. This
leads to seemingly duplicate payments, and is bad all around. So,
we will enforce the restriction by taking only the first payment per
xact in the list of payments.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Replace erroneous calls to $e->retrieve_authority_record($rec_id).
On lines 153 and 175 of OpenILS::Application::Cat::Authority calls
like the above should be $e->retrieve_authority_record_entry($rec_id).
This branch replaces the two misspelled calls with the proper ones.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Conflicts [just whitespace]:
Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/Authority.pm
Liam Whalen [Mon, 7 Oct 2013 05:11:56 +0000 (22:11 -0700)]
LP#1037171 Removed Expert Search paramters from subject links
After performing an Expert Search, if a user visits a record and then
clicks on one of the author, subject, or series search links within
that record, then they are given the results of the Expert Search again
instead of the relevant subject or author search.
This is happening because the Expert Search parameters are retained in
the URLs via the TT2 MACRO mkurl. In particular, the tag parameter is
used to identify an Expert Search, so if it is present in a URL, than an
Expert Search will be attempted regardless of which other paramaters are
in the URL.
To fix this, I created two varialbes within header.tt2 above the
definition of mkurl. These variables group common URL paramters for
Expert Searches and General Search parameters together. These variables
can be used wherever mkurl is used to strip out unneeded search
paramters.
There is a third variable that is already present within many of these
pages named stop_parms. While I initially tried to modify this
variable, I found that there are some instances where the general search
parameters should be retained while the Expert Search parameters must go.
This commit uses these three variables togehter as input into the third
arugment of the mkurl MACRO. The third arugment specifies which
paramtes to remove from the previous URL before making a new URL based
on the pervious URL.
I also added the query parameter to the Place Hold's hold_source_page
URL variable. I did this, so that the query terms would be preserved
once the user is done placing the hold or decides to cancle the placing
of the hold.
As well, I used the new variables to remove Expert Search paramters
from the Advanced Search links on the results and record pages.
Signed-off-by: Liam Whalen <whalen.ld@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Steven Callender [Thu, 14 Nov 2013 20:42:12 +0000 (15:42 -0500)]
LP1251424 - Fix for submit button when placing holds in staff client
I've moved the initializing of the cur_hold_barcode variable
to within the function rather than floating outside of it.
This seemed to fix an intermittent issue where the submit
button would not become activatable when first going to the
place hold screen via the staff client. To create the hold,
ths user had to cycle through the "Place hold by patron barcode"
option and then back to "Place hold for me" option.
It looked like behind the scenes for certain org units that
variable would not be set and the button will not open until
it at least has something. This causes it to be set on the initial
loading of the screen.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Added a definition to the HOLD_ITEM_CHECKED_OUT event in ils_events.xml.
Trying to be generic between the opac and the staff client the message
reads, "The item you have attempted to place on hold is already checked
out to the requestor."
[LFW: I made a tiny spelling change to be consistent with other
appearances in Evergreen of the term "requestor".]
Acq: Improvements to account-matching incoming EDI messages
The way the EDI fetcher works gives us a problem. That process iterates
over EDI accounts for which it has FTP host and credential information,
downloads documents from each of those sites, and files the messages
within those documents under the EDI account from which the login
credentials came. The problem is that in practice the exact same host
and login information is used by multiple accounts under the same
vendor, and files relating to these sub-accounts are commingled, so that
you can't make the decision about which messages should be filed under
which accounts based on the name of the document or its location. You
have to make that decision later, based on its contents.
We are already incompletely doing this, distinguishing between
sub-accounts under which we could file our messages when the vendor
specifies the buyer's SAN next to the specific sub-account number *and*
those sub-accounts belong to different Evergreen org units. We still
need ways to distinguish in other cases.
This will do what is natural for at least one vendor, and match the
message content against the vendacct field of the acq.edi_account table.
*Also,*
We were re-retrieving the working acq.edi_message row from the database
before writing it, throwing away possible changes to the object in hand
made by O::A::Acq::EDI::process_parsed_msg(). We should only do that in
the case where that function has raised an exception.
We were doing the same kind of thing in another place actually inside
process_parsed_msg() where we set the edi_message's purchase_order field
based on the first lineitem encountered if the message itself didn't
specify a valid PO identifier.
This supports making account-correction work for ORDRSP messages in
addition to INVOIC messages.
We also propagate that same correction to the provider and shipper
fields of any invoices that get created from said edi_message.
Mike Rylander [Fri, 1 Nov 2013 17:57:35 +0000 (13:57 -0400)]
Add indicators; Remove junk tags
First, we were not supplying authority tag indicators when generating the
overlay template. The xml merge function does not currently transfer
indicators, but we need to do this anyway because newer MARC::Field version
balk at fields with no indicators.
Second, PG 9.1+ adds wrapper tags to xml content that is passed to XMLELEMENT
as an array. So, we'll use XMLAGG to get around that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Tue, 29 Oct 2013 15:37:36 +0000 (11:37 -0400)]
Use all subfield values to link authority records to bibs
Given an Evergreen instance with two authority records loaded, one
being a more specific than the other via a repeated subdivision subfield,
we must make sure that we use all the bib-supplied subfield values when
attempting to auto-link to the correct authority. Otherwise, the "shorter"
authority record may be selected as appropriate, and data in the bib record
would be lost.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Mon, 14 Oct 2013 16:21:58 +0000 (09:21 -0700)]
LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()
This follows up on observations made by Steven Chan that
suggests that even the act of creating an anonymous hash and
passing it to a global function can cause (I assume) JavaScript
execution contexts to be leaked.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
This implements using the new custom event rather than
xulG.set_tab() to refresh a refresh of the checkout tab. It
also removes use of a callback function to request the tab
refresh in favor of a simple setTimeout().
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1086458: define custom event for refreshing the checkout page
Using a custom event handled by a chrome event handler rather
than calling xulG.set_tab() directly avoids any possibility of
leaking objects and executation contexts from the code that's
requesting refresh of the checkout page.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Mon, 14 Oct 2013 15:23:23 +0000 (08:23 -0700)]
LP#1086458: convert last-print information hash to JSON string before caching
By serializing the printing message and context information to a
JSON string before caching it, we avoid inadvertantly dragging in
things like Javascript execution contexts and possibly references
to objects created by the checkout interface. This was contributing
to the staff client memory leaks observed during receipt printing.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 25 Oct 2013 16:15:25 +0000 (12:15 -0400)]
Respect source XML subfield order during overlay
When adding specific subfields to a field as described by an add
or replace rule we were adding them in rule-order. Instead, they
should be added in source-XML physical order. This commit does
that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Thu, 24 Oct 2013 20:10:00 +0000 (16:10 -0400)]
Make sure that # can be used in auth browse
Because we use URLs to call the SuperCat browse API, we need to
be more careful about encoding parameters. #, in particular, breaks
auth browse because it's seen as a URL fragment separator by the browser
and web server.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Yamil Suarez <yamil@yamil.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 24 Oct 2013 13:54:49 +0000 (09:54 -0400)]
RDA / TPAC: Add 264 for pubinfo graphic 880 lookups
Per https://bugs.launchpad.net/evergreen/+bug/1243746 the publication
info in search results was coming up empty for RDA records because they
use 264 for publication info instead of 260.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Remington Steed [Wed, 16 Oct 2013 20:13:50 +0000 (16:13 -0400)]
Serials Docs: Improve format, fix typos, and update
This commit makes several minor changes to the Serials doc files, mostly
changes in formatting or corrections of bugs/typos. This list covers
most of the changes:
- Add row on 'receiving' to Serials interfaces comparison table
- Improve formatting of actionable items (using bold and arrows),
e.g. Click on *First Menu* -> *Next Menu* -> *Last Menu*
- Standardize formatting of form field names (using italics)
- Improve unclear wording
- Correct an outdated description of copy template 'status' field
(changed before 2.3)
- Change heading level for a subsection
Dan Scott [Mon, 21 Oct 2013 15:12:06 +0000 (11:12 -0400)]
Fix "elfield" typo noted by Ben Ostrowsky
Per sylvar in IRC and in
https://bugs.launchpad.net/evergreen/+bug/1240636, "elfield" should be
"selfield" (even though the code in question is currently inside an "#if
0" block and will never execute).
Dan Wells [Mon, 14 Oct 2013 19:24:39 +0000 (15:24 -0400)]
Fix integrated subscription editor record field
When trying to edit a subscription using the new 'integrated' editor,
it foolishly tries to populate an unfiltered bre dropdown selector.
This works OK in test environments, but (as expected) fails miserably
with production-size data sets.
The end result is that the dropdown either never populates, or takes
a really long time. If the user saves before the dropdown loads, the
associated record ID is lost, and the subscription is no longer
properly associated with the record.
To fix this, simply turn the dropdown into a disabled text input
instead, as the ability to edit this field would generally be more
harmful than it is necessary.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Wed, 4 Sep 2013 18:55:57 +0000 (14:55 -0400)]
Vandelay copy overlay call number merge
When overlaying a copy, if the copy brings with it a new call number
which collides with an existing call number AND said copy is the only
copy linked to its (old) call number, merge the copy's (old) call
number into the (new) existing call number, i.e. the one we collided
with.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Thu, 10 Oct 2013 19:54:40 +0000 (15:54 -0400)]
Adding 0842 due to 2_3 backport issues
A clean backport of 0841 was not possible due to partial schema
differences in the upgrade. While we may have planned ahead better,
add a script just for 2_3 upgraders which ends up being a no-op for
2_4+
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
projects / Evergreen.git / log