]> git.evergreen-ils.org Git - Evergreen.git/log
Evergreen.git
10 years agolp1193487 Circulation Policy Column Picker not saving configuration.
Garry Collum [Sun, 4 Aug 2013 20:10:26 +0000 (16:10 -0400)]
lp1193487 Circulation Policy Column Picker not saving configuration.

The circulation policy column picker is not saving its configuration
because ui.grid_columns.conify.config.circ_matrix_matchpoint is not
defined in the config.usr_setting_type table.  This updates the sql
to populate the table.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoStamping 0838 - remove bibcn normalizers
Dan Wells [Mon, 7 Oct 2013 20:10:04 +0000 (16:10 -0400)]
Stamping 0838 - remove bibcn normalizers

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoThe identifier|bibcn field is best served by having no normalizers applied
Lebbeous Fogle-Weekley [Wed, 2 Oct 2013 19:28:35 +0000 (15:28 -0400)]
The identifier|bibcn field is best served by having no normalizers applied

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoOPAC: Make advanced search -> numeric search -> bib cn hone in on right target
Lebbeous Fogle-Weekley [Wed, 2 Oct 2013 19:18:17 +0000 (15:18 -0400)]
OPAC: Make advanced search -> numeric search -> bib cn hone in on right target

The bib call number search under the advanced search page's numeric
search pane was doing the wrong thing.  By thinking the search field
desired was called 'bib_cn' where it's actually called 'bibcn', it
generated searches that just fell back to the broader search class
'identifier'.  This would often find your matches, but would also find
too many records that *shouldn't* have been matches.

Discovered with help from Erica Rohlfs and Mike Rylander.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoDocumentation: Add migrating patron data from 2.1 docs.
Robert Soulliere [Thu, 3 Oct 2013 19:48:19 +0000 (15:48 -0400)]
Documentation: Add migrating patron data from 2.1 docs.

Converted and added documentation from http://docs.evergreen-ils.org/2.1/html/migratingpatrons.html.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
10 years agoLP#1207281: require SSL when downloading offline patron list
Galen Charlton [Thu, 26 Sep 2013 21:24:42 +0000 (14:24 -0700)]
LP#1207281: require SSL when downloading offline patron list

This patch builds on the previous one by forcing use of
SSL for downloading the offline patron list.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoLP#1207281 Prevent download of offline patron list without authentication
Michael Peters [Tue, 24 Sep 2013 20:57:37 +0000 (16:57 -0400)]
LP#1207281 Prevent download of offline patron list without authentication

This patch addresses the vulnerability which allowed a user with the proper
knowledge of the location of offline patron lists to download the file over
regular HTTP without any staff credentials.

This small addition to eg_vhost.conf.in will present users with a login prompt
when trying to access the /standalone/ subdirectory on an Evergreen server.

Users are able to download the patron list in the staff client as normal
because they already have obtained credentials during the normal staff client
authentication process.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoLP#1066141: add authtoken check and related permission for age to lost function
Ben Shum [Fri, 12 Oct 2012 02:04:30 +0000 (22:04 -0400)]
LP#1066141: add authtoken check and related permission for age to lost function

The SET_CIRC_LOST permission is now required in order to invoke
the open-ils.circ.circulation.age_to_lost method.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoFix an omission in the log redaction configuration.
Jason Stephenson [Wed, 30 Jan 2013 21:56:12 +0000 (16:56 -0500)]
Fix an omission in the log redaction configuration.

open-ils.actor.patron.password_reset.commit was omitted in the
<log_protect> block of opensrf_core.xml.example.  This commit adds
it and updates the release notes for 2.3 to include it.

There is also a release notes file informing users that they need to
edit opensrf_core.xml to address this issue.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoFix delete items confirmation typo.
Pasi Kallinen [Wed, 11 Sep 2013 05:54:55 +0000 (08:54 +0300)]
Fix delete items confirmation typo.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoBetter handling of purchase_order being non-numeric
Lebbeous Fogle-Weekley [Thu, 5 Sep 2013 17:24:54 +0000 (13:24 -0400)]
Better handling of purchase_order being non-numeric

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoAction/Trigger load environment via stream
Bill Erickson [Thu, 22 Aug 2013 20:47:27 +0000 (16:47 -0400)]
Action/Trigger load environment via stream

Load objects in the A/T environment via streaming response instead of
atomic, to avoid very large messages.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
10 years agoHave TPAC put user input at the end in all cases
Mike Rylander [Fri, 30 Aug 2013 15:22:27 +0000 (11:22 -0400)]
Have TPAC put user input at the end in all cases

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
10 years agoStream facet data
Mike Rylander [Wed, 28 Aug 2013 19:05:36 +0000 (15:05 -0400)]
Stream facet data

For certain shapes of facet datasets, the .atomic version of the
json_query call can produce an XMPP message large enough to cause
ejabberd to fall over unceremoniously.  Switch to a streaming
CStoreEditor-based call instead to avoid this.

Ideally, this would use message bundling (aka, chunking) as well,
but the C parts of OpenSRF don't seem to support that yet.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoStamping upgrade script for biblio A/T title variable fix
Ben Shum [Sat, 7 Sep 2013 03:20:16 +0000 (23:20 -0400)]
Stamping upgrade script for biblio A/T title variable fix

Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

10 years agoreset title variable when looping with biblio A/T
Jason Etheridge [Thu, 8 Nov 2012 16:27:13 +0000 (11:27 -0500)]
reset title variable when looping with biblio A/T

Two templates that I'm concerned with, though there may be others that could use
this treatment: biblio.record_entry.email and biblio.record_entry.print

Basically, they can group events from the same user and consolidate bibs, but as
they loop through the bibs they're not clearing the temporary variable that
contains the bib title, so we get duplicated and run-on titles in the output.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

10 years agoThe ILS User reports source branches to an All Hold Requests linked source
Chris Sharp [Mon, 19 Aug 2013 18:29:23 +0000 (14:29 -0400)]
The ILS User reports source branches to an All Hold Requests linked source
that was marked class="circ" instead of class="ahr".  This corrects that problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoFix some bad break syntax
Ben Shum [Sat, 7 Sep 2013 02:49:30 +0000 (22:49 -0400)]
Fix some bad break syntax

Change </br> to a more appropriate <br/>

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoUnify appellee/appellant relators
Pasi Kallinen [Wed, 4 Sep 2013 06:07:47 +0000 (09:07 +0300)]
Unify appellee/appellant relators

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoFix schema.org mapping for MusicAlbum, add Map
Dan Scott [Fri, 5 Apr 2013 17:21:47 +0000 (13:21 -0400)]
Fix schema.org mapping for MusicAlbum, add Map

We had set LDR[06] = j to MusicRecording, but that is really meant for
individual songs. Use MusicAlbum instead, and per
http://schema.org/MusicAlbum, use a new MusicGroup itemtype with a
'byArtist' property for the primary artist rather than the generic
'accountablePerson'.

Also map LDR[06] = e to Map, because that seems like a safe bet.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/templates/opac/parts/record/authors.tt2

10 years agoSave times in HH:MM format for hours of operation
Pasi Kallinen [Wed, 17 Jul 2013 16:07:45 +0000 (19:07 +0300)]
Save times in HH:MM format for hours of operation

When editing Hours of Operation, save the times in HH:MM format,
as that is what the database wants.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoFixing LP 1203796.
Chris Sharp [Mon, 22 Jul 2013 16:35:46 +0000 (12:35 -0400)]
Fixing LP 1203796.

The alternate view in the Item Status screen shows a "Total Circs"
field that was under-counting circulations because UNION filtered
out duplicates.  This commit replaces UNION with UNION ALL, which
allows duplicate rows.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoStamping upgrade for browse normalization timing fix
Ben Shum [Thu, 22 Aug 2013 16:11:54 +0000 (12:11 -0400)]
Stamping upgrade for browse normalization timing fix

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoBrowse normalization timing fix
Mike Rylander [Tue, 20 Aug 2013 20:00:48 +0000 (16:00 -0400)]
Browse normalization timing fix

When indexing browse entries, we need to normalize the value we want to use
before we go looking for it in the table, for uniqueness.  We do in master,
we need to in 2.3 as well.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoCorrectly mark nested INNER joins as such
Mike Rylander [Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)]
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Conflicts [just whitespace style]:
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm

10 years agoFix A/T object cache
Thomas Berezansky [Thu, 1 Nov 2012 13:08:38 +0000 (09:08 -0400)]
Fix A/T object cache

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP1183467 ACQ view funding source list permissions
Bill Erickson [Thu, 23 May 2013 17:30:43 +0000 (13:30 -0400)]
LP1183467 ACQ view funding source list permissions

Limit the set of funding sources visible in the funding source list
interface by those the user has view permissions for, not just those the
user has edit permissions for.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoStamping upgrade script for series title normalizer improvement
Mike Rylander [Thu, 22 Aug 2013 15:26:20 +0000 (11:26 -0400)]
Stamping upgrade script for series title normalizer improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoRemove [ and ] characters from seriestitle index LP#1187521
Steven Callender [Tue, 4 Jun 2013 18:11:50 +0000 (14:11 -0400)]
Remove [ and ] characters from seriestitle index LP#1187521

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoRepair remaining Authority Fixed Field editor entries
Mike Rylander [Fri, 12 Jul 2013 18:43:57 +0000 (14:43 -0400)]
Repair remaining Authority Fixed Field editor entries

The "Item" fixed field is only valid for MFHD records, so we remove
that entirely from AUTH records.  The "GeoSubd" fixed field is
spelled "GeoDiv" everywhere, so we align that naming so that it can
be saved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoPropagating 2.3.10 DB upgrade script
Bill Erickson [Thu, 22 Aug 2013 14:24:57 +0000 (10:24 -0400)]
Propagating 2.3.10 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoInvoke skull-and-crossbones popup in batch receive for server-side errors
Lebbeous Fogle-Weekley [Mon, 23 Jan 2012 23:44:00 +0000 (18:44 -0500)]
Invoke skull-and-crossbones popup in batch receive for server-side errors

And introduce a minor bumper rail to guide serials users who might try
to hand-edit a holding code.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
    Open-ILS/xul/staff_client/server/serial/batch_receive.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoCopying 2.3.8-2.3.9 SQL upgrade script
Bill Erickson [Wed, 21 Aug 2013 13:51:10 +0000 (09:51 -0400)]
Copying 2.3.8-2.3.9 SQL upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoAcq general search: improve searching for negative comparisons
Lebbeous Fogle-Weekley [Wed, 19 Sep 2012 19:27:03 +0000 (15:27 -0400)]
Acq general search: improve searching for negative comparisons

This aims to address Launchpad bug #1031535.  I think the bug only
really shows up when searches involve invoices either as the core type
or with filter fields.  If a search doesn't involve invoices, the
problematic joins aren't present.

Could use more testing though.  Seems to make the problem go away, and
other basic searches seem to work, but I certainly haven't tested
everything.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoStamping upgrade script for dewey sort fix
Ben Shum [Tue, 20 Aug 2013 14:50:43 +0000 (10:50 -0400)]
Stamping upgrade script for dewey sort fix

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1150939 fix dewey sort
Jason Etheridge [Thu, 7 Mar 2013 16:59:09 +0000 (11:59 -0500)]
LP#1150939 fix dewey sort

There's a bit in the code where it tries to pad the first digit group,
if it's the only digit group, but it assumed the digit group was the
first token.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1208572 - Fixes for reporter.classic_item_list
Chris Sharp [Mon, 5 Aug 2013 18:10:56 +0000 (14:10 -0400)]
LP1208572 - Fixes for reporter.classic_item_list

This view was created before the extend_reporter schema and the reporter.
materialized_simple_record existed.  Rewriting the view definition to include
those.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoDB numbering for patron duplication check depth setting
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 14:32:42 +0000 (10:32 -0400)]
DB numbering for patron duplication check depth setting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

10 years agoAdjust Kyle Tomita's patron dupe check fix to use the depth concept
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 13:31:16 +0000 (09:31 -0400)]
Adjust Kyle Tomita's patron dupe check fix to use the depth concept

Addressing these comments:
https://bugs.launchpad.net/evergreen/+bug/1185524/comments/3

And also renaming the OU setting to better peer with similar settings
affecting staff client (not OPAC) patron registration.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
10 years agoLP1185524 - Duplicate patron checking in the user editor is limited to workstation OU
Kyle Tomita [Fri, 31 May 2013 18:33:59 +0000 (11:33 -0700)]
LP1185524 - Duplicate patron checking in the user editor is limited to workstation OU

Added a new library setting opac.duplicate_patron_check_use_consortium.
When true, the duplicate check will use the consortium (1) as the OU.
When false or not set, the duplicate check will use the workstation OU.

The setting is checked in subroutine that creates the search request and
sets the OU accordingly.

[LFW: Signing off but following with material changes next commit.]

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm

10 years agoFix LP985075, cannot save Patron Acquisition Request form
Steven Chan [Mon, 5 Aug 2013 16:13:54 +0000 (12:13 -0400)]
Fix LP985075, cannot save Patron Acquisition Request form

The form is shown using a dojo EditPane attached to an EditDialog,
however, attaching the pane was done manually, resulting in the dialog
acting improperly and the pane positioned improperly.

Instead, we use dojo's attr method to define the content attribute of
the dialog to be the pane.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoFixing LP 1072892 - repeated rows in reporter.classic_item_list view
Chris Sharp [Wed, 31 Jul 2013 15:03:25 +0000 (11:03 -0400)]
Fixing LP 1072892 - repeated rows in reporter.classic_item_list view

The view joined the actor.card table in such a way that all library
cards (active or not) were being returned.  This commit changes that
behavior so that only the current card (from actor.usr.card) is returned.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1211506 fix numeric sorting in staff client grids
Bill Erickson [Tue, 13 Aug 2013 14:03:10 +0000 (10:03 -0400)]
LP1211506 fix numeric sorting in staff client grids

To recover numeric (vs. ascii-betical) sorting of number and money
values in grids, cast the cached sort values back into numbers.

This was tested in the billing interface, but should repair numeric
sorting for most grids.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoAlways show grid buttons on My Selection List
Pasi Kallinen [Mon, 22 Jul 2013 07:16:36 +0000 (10:16 +0300)]
Always show grid buttons on My Selection List

Fix LP#1028601 by showing the selection list creation buttons in the acq
search UI even when there are no search results.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoSolidify caption/holding relationship, improve MFHD::Holding comparisons
Dan Wells [Tue, 2 Jul 2013 15:55:21 +0000 (11:55 -0400)]
Solidify caption/holding relationship, improve MFHD::Holding comparisons

[This commit has been squashed for merging. LFW]

  * This commit:
    - Makes sure that holding data is valid for the given caption
      for new holding objects
    - Teaches field_values() to fall back to '*' (unknown marker)
      when a holding is missing data
    - Allows the caption() method to be a setter

  * This commit:
    - Makes the comparison operator consider chron data, not just
      enumeration data
    - Teaches the comparison operator a way to handle 'unsure' data
      (that is, data presented in brackets [])

  * The code was assuming the $end_holding param would be uncompressed,
    but this was not stated anywhere, nor enforced.  Let's allow the
    method to take both compressed and uncompressed holdings as the "end"
    (and handle it appropriately).

  * Add some holdings with missing and unsure data to test the new
    comparison operators handling of such data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoFix logic in get_compressed_holdings()
Dan Wells [Wed, 8 May 2013 19:09:41 +0000 (15:09 -0400)]
Fix logic in get_compressed_holdings()

[This commit has been squashed for merging. LFW]

  * This commit rearranges some of the logic branches to protect
    against an unusual case of having two holding statements with
    the same start value, but one being open-ended and one not.

  * The logic in get_combined_holdings() was a little sloppy and
    repeated some steps unnecessarily.  This cleans things up.

    See the test case in the previous commit for more clarity.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoTie in new MFHD method to serials module/MFHD tests for compressing, combining
Dan Wells [Tue, 7 May 2013 22:23:27 +0000 (18:23 -0400)]
Tie in new MFHD method to serials module/MFHD tests for compressing, combining

[This commit has been squashed for merging. LFW]

 *  Now that we have a potentially better alternative, let's call
    get_combined_holdings() in place of get_compressed_holdings() in
    Serial.pm.

 *  First, add a test for the new get_combined_holdings() method.

    Second, add a known problem case for get_compressed_holdings().
    The fix will come in a subsequent commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoAdd new get_combined_holdings() method to MFHD.pm
Dan Wells [Tue, 7 May 2013 22:19:34 +0000 (18:19 -0400)]
Add new get_combined_holdings() method to MFHD.pm

This commit adds a new method to the MFHD module which creates an
array of compressed holdings from all holdings for a given caption,
combining as needed.

NOTE: This method is similar to, but much less aggressive/strict than
get_compressed_holdings(). Ultimately, get_compressed_holdings()
might be deprecated in favor of this.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoAcq: When processing EDI invoices, skip unknown line item references
Lebbeous Fogle-Weekley [Mon, 24 Jun 2013 15:47:40 +0000 (11:47 -0400)]
Acq: When processing EDI invoices, skip unknown line item references

See LP #1172373.

In their electronic invoices, vendors sometimes include a mix of line
items that your ILS knows about, because you ordered them through it,
and line items of which your ILS knows nothing. We should not fail
altogether at processing invoices, but instead process what line items
we can.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoAcq: When building invoices from EDI messages, avoid bad data
Lebbeous Fogle-Weekley [Tue, 16 Apr 2013 19:18:17 +0000 (15:18 -0400)]
Acq: When building invoices from EDI messages, avoid bad data

From some vendors, these EDI messages contain strings (useless ones,
like just the name of the vendor) where we had been expecting numeric
identifiers.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoValidate date ranges in Close Dates editor
Pasi Kallinen [Wed, 17 Jul 2013 17:24:26 +0000 (20:24 +0300)]
Validate date ranges in Close Dates editor

Complain in Closed Dates Editor when ending date is earlier than starting date.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoPrevent paste from empty clipboard throwing an error
Pasi Kallinen [Tue, 23 Jul 2013 07:49:47 +0000 (10:49 +0300)]
Prevent paste from empty clipboard throwing an error

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoFix IDL and OU setting check for staged users
Jeff Godin [Tue, 29 May 2012 14:28:50 +0000 (10:28 -0400)]
Fix IDL and OU setting check for staged users

The IDL had references to sequences that do not exist:

staging.usr_stage_row_id_seq -- a typo, fixed

In the case of staging.billing_address_stage_row_id_seq, the
staging.billing_address_stage table is created with LIKE,
and uses the sequence staging.mailing_address_stage_row_id_seq

The OU setting check for the open-ils.actor.user.stage.create API
call was not passing an org unit, and would always fail.

We now pass the home_ou of the user being staged.

At this point, the opac.allow_pending_user OU setting type must
be manually created before its value can be set.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoLP1203753 AuthProxy barcode login support
Bill Erickson [Mon, 22 Jul 2013 19:21:15 +0000 (15:21 -0400)]
LP1203753 AuthProxy barcode login support

When users attempt a barcode-based login with AuthProxy, the system will
determine the username of the user (based on the barcode) and use the
username instead of the barcode for all proxied login attempts.  This
allows users to use their barcodes (or barcode-looking usernames) to
log in via remote authenticators.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoFix LP#1187402: Datafield contents turned undefined in Marc Editor after adding 006...
Pasi Kallinen [Fri, 19 Jul 2013 06:04:04 +0000 (09:04 +0300)]
Fix LP#1187402: Datafield contents turned undefined in Marc Editor after adding 006, 007 or 008

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dan@coffeecode.net>
10 years agoExplicit function ownership is not the job of upgrade scripts
Mike Rylander [Wed, 17 Jul 2013 21:13:57 +0000 (17:13 -0400)]
Explicit function ownership is not the job of upgrade scripts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/sql/Pg/version-upgrade/2.4.0-2.4.1-upgrade-db.sql

Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoStamping upgrade script for copy stats SP fix
Mike Rylander [Wed, 17 Jul 2013 17:29:14 +0000 (13:29 -0400)]
Stamping upgrade script for copy stats SP fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP 1103706 Hold ratios in circ policies cause errors when trying to renew items
Fredrick Parks [Wed, 10 Jul 2013 18:12:17 +0000 (11:12 -0700)]
LP 1103706 Hold ratios in circ policies cause errors when trying to renew items

Changed the function action.copy_related_hold_stats to accept a bigint as the perameter instead of an integer.
Copy_related_hold_stats is only called by the function action.item_user_circ_test which trys to pass a bigint.

Signed-off-by: Fredrick Parks <fparks@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoStamping upgrade script for authority labeling fix
Mike Rylander [Wed, 17 Jul 2013 17:25:29 +0000 (13:25 -0400)]
Stamping upgrade script for authority labeling fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAuthorities: 4XX fields have wrong names
Lebbeous Fogle-Weekley [Thu, 11 Jul 2013 19:31:37 +0000 (15:31 -0400)]
Authorities: 4XX fields have wrong names

In Evergreen we have authority fields defined in the database that
relate to control sets.  These are used somewhere today (I'm fuzzy on
that at the moment; some places once had and may still have hardcoded
labels) but they also will be used by the bib and auth browser
that's not yet merged to master (see LP #1177810).

The 4XX tags among the set I'm talking about (in
authority.control_set_authority_fields) are mislabled, saying See Also
where they ought to say See From, e.g.
http://www.loc.gov/marc/authority/ad400.html

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoImplement a concurrent-run cache for result rendering a la initial search queue compr...
Mike Rylander [Fri, 12 Jul 2013 17:11:57 +0000 (13:11 -0400)]
Implement a concurrent-run cache for result rendering a la initial search queue compression

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoCapture and log AuthProxy logins with no account
Dan Wells [Wed, 10 Oct 2012 13:22:33 +0000 (09:22 -0400)]
Capture and log AuthProxy logins with no account

The current AuthProxy.pm code assumes that if the external auth
passes, the Evergreen account will be there.  This protects
against cases where a user is in the external auth system but
has no matching account in Evergreen.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoMake AuthProxy LDAP bind code more robust
Dan Wells [Thu, 27 Sep 2012 21:35:03 +0000 (17:35 -0400)]
Make AuthProxy LDAP bind code more robust

The existing version of LDAP_Auth.pm assumed that the user's
bind DN could be derived from the base DN, the ID attribute, and
the user's ID.  This is frequently the case, but not always,
particularly in Active Directory setups using sAMAccountName. This
commit instead uses the initial LDAP lookup as the authority for
determining the user's DN.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoMove action.hold_request_cancel_cause inserts to 950.data.seed-values.sql
Pasi Kallinen [Tue, 2 Jul 2013 06:13:40 +0000 (09:13 +0300)]
Move action.hold_request_cancel_cause inserts to 950.data.seed-values.sql
so they're picked up for translation.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoMove acq.user_request_type data for i18n picking
Pasi Kallinen [Tue, 2 Jul 2013 05:34:16 +0000 (08:34 +0300)]
Move acq.user_request_type data for i18n picking

Move acq.user_request_type inserts into 950.data.seed-values.sql
so those get picked up for translation.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1200735 stamping upgrade for usrname index
Bill Erickson [Fri, 12 Jul 2013 19:19:23 +0000 (15:19 -0400)]
LP1200735 stamping upgrade for usrname index

Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoLP#1200735: improve performance of patron search by username
Galen Charlton [Fri, 12 Jul 2013 19:10:32 +0000 (15:10 -0400)]
LP#1200735: improve performance of patron search by username

This patch adds an additional index on actor.usr.usrname.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoFix LP1177916, Cannot activate PO which contains only direct charges
Steven Chan [Sat, 15 Jun 2013 17:06:43 +0000 (13:06 -0400)]
Fix LP1177916, Cannot activate PO which contains only direct charges
We add a safety check in the function
Application/Acq/Order.pm/create_lineitem_list_assets(), which is called
by create_po_assets(), which is the service call initiated by the user
trying to activate a PO.

The safety check prevents the function from processing if there are no
line items specified in the arguments.

P.S. It would be better to stop the sequence of events earlier in the
client, but that will need more coding, which can been done in another
fix.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoPatron Editor can enter erroneous values for Claims-returned count
Steven Chan [Thu, 23 May 2013 22:22:15 +0000 (15:22 -0700)]
Patron Editor can enter erroneous values for Claims-returned count

In the staff client, Patrons interface, Edit screen, when
mouse-scrolling up and down the Edit form, it is possible to
inadvertently change the value in Claims-returned Count or Claims Never
Checked Out Count field.  It will happen if the mouse hovers over either
data field while using the mouse wheel.

Both data fields use the dijit.form.NumberSpinner widget to provide a
'spin' behaviour.  The fix involves cancelling the mouse scroll event as
it propagates to input fields in table rows that are using the
dijit.form.NumberSpinner widget, because the mouse scroll would be
applied too early by the widget, before the user has intentionally
focussed on one of the input fields.  Now, mouse scrolling has no effect
on the two input fields; it will only have an effect in scrolling the
page up or down.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoAdd missing oils_i18n call #2 to upgrade script
Dan Wells [Wed, 10 Jul 2013 15:39:08 +0000 (11:39 -0400)]
Add missing oils_i18n call #2 to upgrade script

Simple thinko fix for missing translation function call.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agoStamping upgrade for Gwich'in language typo
Dan Wells [Wed, 10 Jul 2013 15:26:07 +0000 (11:26 -0400)]
Stamping upgrade for Gwich'in language typo

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1158206 - include upgrade script to fix Gwich'in typo
Ben Shum [Wed, 10 Jul 2013 00:47:20 +0000 (20:47 -0400)]
LP1158206 - include upgrade script to fix Gwich'in typo

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoFix LP1158206 - The language is Gwich'in.
Pasi Kallinen [Thu, 13 Jun 2013 06:06:26 +0000 (09:06 +0300)]
Fix LP1158206 - The language is Gwich'in.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1156905 lineitem worksheet sorts copies by org
Mark Cooper [Mon, 18 Mar 2013 22:45:14 +0000 (15:45 -0700)]
LP1156905 lineitem worksheet sorts copies by org

Lineitem copies (details) were set to be sorted by branch ('owning_lib')
by default. However this was not happening because the lineitem_details
'owning_lib' referenced a fieldmapper object (not an id or name).
This submission sets the owning_lib to the shortname so that sorting can
occur in the intended way.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoAdd missing oils_i18n call to upgrade script
Dan Wells [Wed, 10 Jul 2013 15:39:08 +0000 (11:39 -0400)]
Add missing oils_i18n call to upgrade script

Simple thinko fix for missing translation function call.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agoStamping upgrade script for empty seed description
Dan Wells [Wed, 10 Jul 2013 14:53:41 +0000 (10:53 -0400)]
Stamping upgrade script for empty seed description

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1158211 - add upgrade script to fill empty description
Remington Steed [Wed, 10 Jul 2013 13:32:07 +0000 (09:32 -0400)]
LP1158211 - add upgrade script to fill empty description

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoDescription for circ.holds.default_shelf_expire_interval
Pasi Kallinen [Tue, 11 Jun 2013 08:01:53 +0000 (11:01 +0300)]
Description for circ.holds.default_shelf_expire_interval

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1183414: OPAC patron opt-in settings table does not work correctly
Pasi Kallinen [Mon, 27 May 2013 09:02:38 +0000 (12:02 +0300)]
LP1183414: OPAC patron opt-in settings table does not work correctly

Fix the template logic error, trying to use a variable before
it is defined.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoCorrect Linux staff client build instructions
Dan Scott [Tue, 9 Jul 2013 20:53:29 +0000 (16:53 -0400)]
Correct Linux staff client build instructions

There were a few things going on here; 2.3 introduced linux32-client and
linux64-client targets, so the old linux-client Make target no longer
worked.

Also, Wine isn't generally how many of us would recommend running staff
clients when there's a perfectly good native client likely to better
support printing, etc.

Also, rather than pointing at evergreen-ils.org for downloads, which
won't work in many situations (and which prevents the use of the
auto-update mechanism), use the "updates" target to point at the locally
downloadable clients. Eventually we'll properly document the use of
auto-updates, but for now this is hopefully a step in the right
direction.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoBuild 64-bit Linux client updates when asked
Dan Scott [Tue, 9 Jul 2013 23:43:17 +0000 (19:43 -0400)]
Build 64-bit Linux client updates when asked

A copy/paste error led to a request for linux64-updates-client to
generate 32-bit clients instead of the requested 64-bit clients.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1187016 Prevent new copies on activated POs
Bill Erickson [Wed, 5 Jun 2013 21:29:36 +0000 (17:29 -0400)]
LP1187016 Prevent new copies on activated POs

If a PO has already been activated, prevent users from adding new copies
in the Item Count entry under the full lineitem copy grid.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoreturn, not next, from eval BLOCK
Dan Scott [Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)]
return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoSilence uninit var warnings from query normalizer
Dan Scott [Fri, 21 Jun 2013 03:11:20 +0000 (23:11 -0400)]
Silence uninit var warnings from query normalizer

$field_info can return undef from the search for a matching ID from the
list of normalizers, which in turn generates several uninit var warnings
when attempts are made to access members of the undef variable. We saw
6700 occurrences of these warnings during a typical day of operations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years agoAdd (noop) upgrade script for 2.2.10
Lebbeous Fogle-Weekley [Wed, 19 Jun 2013 19:42:07 +0000 (15:42 -0400)]
Add (noop) upgrade script for 2.2.10

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years ago2.3.8 stub upgrade script
Bill Erickson [Wed, 19 Jun 2013 14:47:20 +0000 (10:47 -0400)]
2.3.8 stub upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoFixes to MARC batch import docs
Kathy Lussier [Fri, 14 Jun 2013 19:51:42 +0000 (15:51 -0400)]
Fixes to MARC batch import docs

Added needed subheadings to the MARC batch update docs. Also shortened
line lengths and modified intro that focused on 2.2 new features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoRepair fine generator memory leak
Bill Erickson [Mon, 27 Aug 2012 14:38:48 +0000 (10:38 -0400)]
Repair fine generator memory leak

Calling "next" from within a "try" block results in a memory leak,
presumably because "try" is a tangled nest of subs and evals.
Replacing the "try" with a good ol' "eval" avoids the leak.

This can be reproduced with the following:

---------
use Error qw/:try/;

foreach (0..200000) {
    try {
        next;
    } catch Error with {
    };
}
---------

This particular leak in the fine generator is onerous when the fine
generator is run often (e.g. every 15 mins), which means circs that
have already been processed for the day are re-analzyed over and over,
causing the code to continue early (next) to the next loop iteration
for large numbers of circs.  It also happens when a circs are skipped
because they have no fine interval, rate, or max fine.

You know this is happening because you will see something like this in
the storage stderr log:

Exiting eval via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

Exiting subroutine via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

This patch does not avoid the "exiting eval via next" warning, since
we're still next'ing out of the eval.  It just avoids the memory leak
(and the "Exiting subroutine" warning).  More extensive refactoring is
needed to to completely remove the second warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoSearch clicked /and/ preceding sf values
Mike Rylander [Tue, 30 Apr 2013 20:45:55 +0000 (16:45 -0400)]
Search clicked /and/ preceding sf values

When looking for authority records to control a bib field, we currently
search using exactly, and only, the subfield that was clicked.  This
commit changes that so that the full field up to and including the clicked
subfield is used in the simple authority heading search we perform to find
the best-match (pivot) authority record.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years agoMake Force/Recall holds always return as nearest
Thomas Berezansky [Thu, 26 Jul 2012 14:25:32 +0000 (10:25 -0400)]
Make Force/Recall holds always return as nearest

Without even running the hold rules.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

(Just whitespace conflicts on tab vs space -- repaired by hand.)

10 years agoTPAC - set autofocus to user input when placing holds in staff client
Ben Shum [Sat, 2 Mar 2013 07:21:58 +0000 (02:21 -0500)]
TPAC - set autofocus to user input when placing holds in staff client

When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.

This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.

Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/place_hold.tt2

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAcq: Be fuzzy about case when retrieving EDI documents
Lebbeous Fogle-Weekley [Mon, 15 Apr 2013 18:06:54 +0000 (14:06 -0400)]
Acq: Be fuzzy about case when retrieving EDI documents

The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login
credentials.

Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.

If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters.  But that seems wildly unlikely.  If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record
Simon Hieu Mai [Mon, 3 Jun 2013 21:45:08 +0000 (17:45 -0400)]
LP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record

Put the cursor back to the current fixed field after reload
the MARC record table.

Signed-off-by: Simon Hieu Mai <hieu.mai@mnsu.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1183340 selectivly apply editable funds sorting
Bill Erickson [Thu, 23 May 2013 13:11:25 +0000 (09:11 -0400)]
LP1183340 selectivly apply editable funds sorting

Avoid sorting editable funds to the front of the fund list when there
are no org units at which the user has the ADMIN_ACQ_FUND permission.
Otherwise, we are sorting on an empty 'IN' list in pcrud, which results
in an error.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP1081576 - fix utf8 characters in searches using portal page
Ben Shum [Thu, 23 May 2013 20:32:49 +0000 (16:32 -0400)]
LP1081576 - fix utf8 characters in searches using portal page

Replace escape() with encodeURIComponent() on the portal page to allow utf8
characters to be passed more appropriately to the subsequent search in catalog.

Thanks Dan Scott for pointing this out.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
10 years agoLP1183357 Pass locale to bib search (tpac)
Bill Erickson [Thu, 23 May 2013 13:43:52 +0000 (09:43 -0400)]
LP1183357 Pass locale to bib search (tpac)

Pass the TPAC locale value, which is collected at each page load, to the
bib search API call.  This allows us to take advantage of language-based
relevance bumps.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoFix Launchpad Bug 1183418.
Jason Stephenson [Thu, 23 May 2013 15:44:05 +0000 (11:44 -0400)]
Fix Launchpad Bug 1183418.

Clicking on an author with a dash or dates in the name on the search
results page comes up with 0 results. It looks like the dash is stripped
from the date and/or name.

Clicking on such a link from the record view actually works because
the dash is replaced with a space.

This branch changes table.tt2 to replace special characters in author
output with a space in the same way that authors.tt2 does.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoDatabase upgrade script for 2.2.9
Lebbeous Fogle-Weekley [Thu, 16 May 2013 20:12:14 +0000 (16:12 -0400)]
Database upgrade script for 2.2.9

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
10 years ago2.3.6 -> 2.3.7 DB upgrade script
Bill Erickson [Thu, 16 May 2013 19:52:38 +0000 (15:52 -0400)]
2.3.6 -> 2.3.7 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
10 years ago2.3.7 Translations Newpot
Bill Erickson [Wed, 15 May 2013 20:09:22 +0000 (16:09 -0400)]
2.3.7 Translations Newpot

Signed-off-by: Bill Erickson <berick@esilibrary.com>