Bill Erickson [Fri, 14 Sep 2012 19:30:15 +0000 (15:30 -0400)]
Consistent permission filtering in ACQ search results
Add permission checks to search result objects when calling unified
search in 'idlist' mode, consistent with the existing permission checks
for non-id-list mode. Without this, different forms of the call return
different sets of results.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
LP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query
You could see this in the Simplified Hold Pull List interface. Using
the filter dialog would refresh the grid and populate it with rows
corresponding to your filters, but it would throw away your setting from
the context org dropdown (labeled "Show the pull list for..." there).
FlattenerGrid had a broken mechanism for trying to nicely mix a user's
input from things like context org dropdowns with whatever they put into
the filter dialog, and now that mechanism has been fixed.
This also means a tiny change to the User Event Log interface to react
to the slight change in FlattenerGrid's API.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Simon Hieu Mai [Wed, 19 Dec 2012 20:33:54 +0000 (14:33 -0600)]
LP#1088561: remove current password (renew password issue with TPAC)
If a user chooses to have their browser remember their password for the
catalog, it can fill in the password to the change password form page
as hidden dots. This behavior was observed specifically with Firefox.
Instead, add autocomplete="off" attribute to the form to force users to
enter existing password to change to a new password as intended.
Signed-off-by: Simon Mai <hieu.mai@mnsu.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Tue, 18 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Make config.update_coded_value_map() consistent
The version of this function in the upgrade file is different than
the one in the 002.schema.config.sql file. This commit fixes the
broken logic in the 002 file and makes it match the logic in the
old upgrade file.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dscott@laurentian.ca>
James Fournie [Tue, 18 Dec 2012 20:45:51 +0000 (12:45 -0800)]
Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details. This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Scott [Tue, 18 Dec 2012 13:52:55 +0000 (08:52 -0500)]
Dojo IDL: Set the "Accept-Language" header
The internationalization support for /reports/fm_IDL.xml keys off of the
Accept-Language header - which, if not set to ^[a-z]{2}-[A-Z]{2}$, falls
back to en-US. Setting the header in the dojo.xhrGet() request makes
Apache able to serve up the right flavour of /reports/fm_IDL.xml
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Dan Scott [Tue, 18 Dec 2012 12:39:18 +0000 (07:39 -0500)]
Set locale properly in Apache configuration
A RewriteCond only applies to the next RewriteRule, while our config was
attempting to apply multiple rules for a single condition. Fix that up
by using skip (S) rules to apply blocks of rules for the condition in
question.
Also, use the HTTP:Accept-Language value directly, rather than relying
on a backreference (which did not seem to be working as desired).
These fixes enable screens like the Register Patron interface to present
field labels from the IDL in the correct locale, whereas previously they
would always default to en-US.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Pasi Kallinen [Sun, 2 Dec 2012 20:49:42 +0000 (22:49 +0200)]
LP#1078596: Cannot translate strings handled by fieldmapper
Strings that should be translatable only show up in English,
for example in the Patron Registration screen.
There's a bug in the fieldmapper where it sets a variable to
an empty array, but later in the code only checks whether that
particular variable exists, not if it's an empty array.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Tue, 4 Dec 2012 16:04:08 +0000 (11:04 -0500)]
ACQ: repair lineitem cancel-reason fleshing
When fetching lineitems for display in the general lineitem list page,
if the lineitem is cancelled, be sure we correctly retrieve the
cancel-reason object.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Tue, 6 Nov 2012 21:32:23 +0000 (16:32 -0500)]
Fix foreign character display in receipts
This commit makes two changes to the staff client print code to
help with the proper display of foreign characters:
1) Specify the utf-8 charset in the receipt Data URIs.
2) Properly encode the entire data string using encodeURIComponent
rather than encode(). Failing to do so was causing XULRunner to
be "creative" with the interpretation of the data.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Michael Peters [Thu, 13 Sep 2012 20:28:04 +0000 (16:28 -0400)]
LP#1047475 Set action.hold_request.email_notify to default to false
LP#1047475 points out that email notify prefs are ignored in TPAC.
Even if a patron deselects email notify during hold request time, it
will always be set to true due to the column default.
This change defaults the column in the database to false (like most
other similar columns are) and resolves the bug.
Credit to Steve Callender for the idea.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Pearl [Tue, 11 Dec 2012 15:13:41 +0000 (10:13 -0500)]
LP: #1086064 Ignore spaces in opac username/barcode entry field
Too often, patrons copy the spacing on the barcode on their keytag,
or enter a spurious space before entering their name/barcode. This
change will remove spaces in their name/barcode.
(For now, keep the login screen's directions to omit spaces when
entering the username/barcode.)
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Tue, 4 Dec 2012 15:08:36 +0000 (10:08 -0500)]
Highlight selected facets over multiple lines
As reported by Dan Pearl in LP# 1086150, selected facets that wrap over
multiple lines only have the first line highlighted. Which is odd, and
easily fixed with a small tweak to the CSS.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Acq: Yet more efforts to sanitize data for the EDI translator
I specifically did this to address cases reported to me by Galen
Charlton in which get_li_attr_jedi() would return the string "nul", but
I hope this is a nail in the coffin for problems involving
JEDI-producing Action/Trigger templates feeding the EDI translator
strings that the latter doesn't like.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sat, 8 Dec 2012 23:36:12 +0000 (18:36 -0500)]
Roll in some Evergreen in Action chapters
For the initial import we're keeping the formatting and words identical,
so that we can manually sycnhronize changes as needed between the FLOSS
Manuals version of this documentation and the AsciiDoc version.
Receipt template editor sections moved to this chapter.
Converted to asciidoc by rsoulliere. Index terms added by rsoulliere
Some duplicate images were also removed from media directory.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Ben Shum [Wed, 21 Nov 2012 19:17:59 +0000 (14:17 -0500)]
KPAC - fix getit_results with short titles
When using the "Get it" options to either add an item to a list or place an
item on hold, one would get an internal server error whenever attemping this
on a bib record with a short title.
Turns out that the substr function that shortens the length of long titles
breaks when the title is 18 characters or less.
Add an IF check around the substr function to avoid this error.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Pasi Kallinen [Tue, 27 Nov 2012 10:39:02 +0000 (12:39 +0200)]
LP#1082260: Update OPAC low search hits template for i18n
The OPAC lowhits.tt2 template is only partially translatable,
and the translatable part is impossible to make sound good
for languages with different word order than English.
This patch changes the already translatable part so there
are 4 different phrases to translate (instead of two phrase
fragments), and makes the search hints translatable.
For English language, the patch does not introduce any visible differences.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 19 Nov 2012 20:55:34 +0000 (15:55 -0500)]
Docs: Add offline circulation basics
Based heavily on the documentation from Evergreen 1.6, which was in turn
based heavily on the Sitka documentation for offline mode, add some
coverage of the offline processes for registering patrons, checking
items in and out, renewing items, and uploading & processing
transactions.
Dan Scott [Thu, 27 Sep 2012 03:25:53 +0000 (23:25 -0400)]
Apply the 0715 update for acq settings_group
We add the 'acq' config.settings_group in the seed data, and add the
other settings groups in the 2.1-2.2 upgrade script, but need to add the
acq settings_group to the 2.1-2.2 upgrade script.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
After upgrade, list records with missing or incorrect 901$c
This is a common cause of pain for upgrades. Let's try to identify the
problem early (even if it takes forever on a site with 3 million bibs)
and offer advice on correcting the problem if it is flagged.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Check for stop fines reason of CHECKIN or RENEW before closing a circulation
transaction when the balance reaches zero.
Also, if the stop fines reason is LOST, then check a new ou setting,
circ.lost.xact_open_on_zero, to determine if the transaction is closed or
kept open. The setting is checked for the circulation copy's circ_lib.
Add CircCommon->can_close_circ.
Following up on Dan Wells' comments on Launchpad Bug 793550, I have moved
the logic to check if the circ transaction can be closed to its own utility
function in OpenILS::Application::Circ::CircCommon. This potentially
consolidates the logic in one place in case we need to use it elsewhere.
Instead of checking for stop fines reasons of CHECKIN and RENEW and
checking for checkin time on the circ, we just check for checkin time.
Both CHECKIN and RENEW should set the checkin time.
Also, use the constant for stop fines reason of LOST, rather than the
literal string "LOST".
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Mon, 12 Nov 2012 16:46:21 +0000 (11:46 -0500)]
No need for vanity info in OpenSRF article
We don't credit particular authors in the Evergreen docs, and we don't
want to dissuade contributors from improving & evolving any particular
section of the docs, so get rid of a hangover attribution from the
OpenSRF article.
Dan Scott [Mon, 12 Nov 2012 16:32:31 +0000 (11:32 -0500)]
Add "Intro to OpenSRF" to development section
We have the Asciidoc source, so let's drop it into place. Triggered by a
request for info on OpenSRF development on IRC that was answered with
"we don't really have much information on that" response. *Poof*, now
we have some.
Dan Scott [Mon, 12 Nov 2012 16:28:58 +0000 (11:28 -0500)]
Docs: resolve transform errors and warnings
ePub really doesn't like absolute references to images - which is good,
it shouldn't. Also, single line NOTE blocks are much easier to deal with
using the prefix approach (and don't generate warnings during normal
HTML generation).
Dan Scott [Wed, 7 Nov 2012 17:55:49 +0000 (12:55 -0500)]
make_release: add the \set eg_version command to upgrade script
We were echoing the output to STDOUT instead of redirecting it to the
upgrade script that we were generating. Let's go the last mile and
actually get it into the upgrade script.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Mike Rylander [Wed, 10 Oct 2012 21:36:52 +0000 (17:36 -0400)]
Make it possible to suppress IDL fields
Some clients of external services, particularly pcrud and reporter-store,
need to be able to access tables that contain columns we'd rather restrict.
For instance, the passwd field on actor.usr.
To effect this feature we provide a blacklist attribute for fields, called
suppress_controller, which works in the same way as the class controller
attribute but names controllers not allowed to use the field. When the field
is explicitly named in a query (fieldmapper select block or json_query) an
error is thrown, and suppressed fields are ingored in general fieldmapper
search/retreive requests.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 2 Nov 2012 19:28:27 +0000 (15:28 -0400)]
CStoreEditor auto-activity log redaction
CStoreEditor logs all update calls to the activity log as key/value
pairs on the updated object. Avoid loging key/value pairs for objects
when the API call being relayed by CStoreEditor is on the list of
log-protect API calls. Instead, log "**DETAILS REDACTED**".
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 11 Oct 2012 04:56:40 +0000 (00:56 -0400)]
TPAC: Address some search syntax leaks in links
Expand the list of filtered characters to cover all of the special
characters documented for the Evergreen search grammar
(http://evergreen-ils.org/dokuwiki/doku.php?id=documentation:technical:search_grammar)
when generating links in the TPAC so as to avoid inadvertently launching
filtered searches when a user clicks on something that should just be a
display value.
For example, if a title includes "Presenting a subject: tips for
consultants", it should _not_ launch a search for "subject" containing
"tips for consultants".
This commit addresses most of the link problems in the record
display, as well as the author links in the search results table.
Still problematic are the facets (which seem to rely on exact matching,
such that filtering out the problematic characters is itself
problematic) and autocomplete (which requires modifying the Autocomplete
Dojo widget).
In addition, this commit makes the series code actually display, as it
was using a non-standard method to attempt to return the results from
the BLOCK (and failing). Also, it makes the links for authors in the
record details match the MODS32 definition for personal name parts and
only use the "acdq" subfields. This enables a click on the link to
actually return results; previously, in the case where the author field
included (for example) a subfield "g" value, that value would be
included in the generated link and would likely lead to 0 hits.
For authors, we substitute with a space rather than just eliding the
substituted value. Authors are particularly likely to have dates like
1899-1978; "1899 1978" matches, but "18991978" will not.
Perhaps we should take the same approach with the others, or break down
the search/replace logic a little further (for example, we could remove
the "-" only if it is preceded by a space or is at the start of the
string and is followed immediately by a character, and preserve it if it
is surrounded by digits). But this seems to take us pretty far down the
road of less negatively surprising results.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 11 Oct 2012 03:35:13 +0000 (23:35 -0400)]
TPAC: Add search torture tests to concerto record
In addition to # signs causing problems in facets, we found that search
syntax in general is surfaced directly in most links that are exposed to
users in the TPAC. This commit adds several examples to the record with
the title "Trombone concerto (1991)":
In the title, there is an embedded "subject:" search which will be
triggered by autocomplete.
In the author (100 field), there is an embedded "author:" search which
will be triggered from the record details page. This also includes
another usage of the # sign.
In the subject fields, there are:
* an embedded "subject:" search which will be triggered from the
facets, autocomplete, and record details page
* an embedded negation operator which will be triggered from the
facets, autocomplete, and record details page
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Wed, 10 Oct 2012 19:50:49 +0000 (15:50 -0400)]
Munge concerto to include # signs in series facets
Search for "Piano concerto in C major, op. 39" or "Beethoven: concertos
and overtures" and you'll get facets with # signs to assist with fixing
LP # 856811.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Wed, 10 Oct 2012 21:26:06 +0000 (17:26 -0400)]
Sample Apache error syslog captures stderr
Not all STDERR output and not all $req->log->foo() output makes it to
the Apache error log when using the 'ErrorLog syslog:local7'
configuration directive. This changes the sample config to match the
CustomLog config so that all output is captured and redirected to
syslog.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mark Cooper [Tue, 23 Oct 2012 05:01:22 +0000 (22:01 -0700)]
LP#1066629: Acq: Receiving an item should not change the status to "In Process" in many cases
As suggested, when received, restrict copy status update for lineitem copies to only those that were on-order. Otherwise copies may have the status set to 'In Process' inappropriately.
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Mark Cooper [Wed, 10 Oct 2012 04:04:32 +0000 (21:04 -0700)]
LP#826917: Marc editor, CTRL+F6, F7, F8 no longer working on 2.0+
Updated marcedit.js to recognize F6/7/8 according to codes at:
http://www.cambiaresearch.com/articles/15/javascript-char-codes-key-codes.
Did not modify behavior (so input focus is not adjusted post record load).
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Thu, 18 Oct 2012 18:54:08 +0000 (14:54 -0400)]
Rollback cstore transaction before bbag record load
To avoid timeouts, which results in transaction rollbacks, preemptively
roll back the bookbag fetching cstore transaction before we retrieve
what could be a very large list of bookbag records data.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Scott [Tue, 9 Oct 2012 20:49:09 +0000 (16:49 -0400)]
Authority popups are empty: fix dojo.query() usage
When you right-click on a controllable field to display the contents of
the matching authority records, the contents of the matching authority
records simply appear as empty grey boxes.
This is another case of needing to iterate over multiple values
separately rather than using one convenient CSS selector.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 28 Sep 2012 17:58:07 +0000 (13:58 -0400)]
ACQ invoice tabs scroll improvements
Avoid nested scrollbars on tabbed ACQ invoice UI. This is done by
removing a ContentPane layer and setting doLayout='false' on the
TabContainer, which allows the individual tabs to control their own
height dynamically, which means no more hard-set 600px height on the
tabs.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Mon, 17 Sep 2012 18:50:36 +0000 (14:50 -0400)]
ACQ scroll back to top of lineitem info page
When displaying the lineitem "info" page (li attributes, marc record),
be sure to scroll to the top of the page instead of relying on the
previous scroll location. In particular, if you last viewed a LI
toward the bottom of the page, returned (causes scroll down), then go
back into the info page, the page will be scrolled to the bottom.
The solution is a little funkier than I'd hoped. The scroll-to point
has to be a node that is a) within the scrolling dojo div and b). non-
visible when scrollIntoView is called. Since the top-level
page div may be different, depending on who is loading li_table, we rely
on the caller to place an id=oils-scroll-to-top div in the page for
general top-scrolling. (Note, also, window.scrollTo does not work when
it's the div and not the full page that needs scrolling).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Namely, this means:
- You see five facets per category by default, not ten.
- You can click a link to see all the facets in a category
(before this it was impossible to display more than ten).
- When viewing all the facets in a category, you can click a link
to reduce the list back to five.
- This number five I'm talking about is configurable in config.tt2.
- Alphabetical sorting of facets grouped by the same numbers of
results is restored.
Steven Callender [Mon, 15 Oct 2012 14:48:28 +0000 (10:48 -0400)]
Added a check for the money.collections_tracker table when using the open-ils.collections.users_of_interest.warning_penalty.retrieve API call.
Users that are already entered into the money.collections_tracker table should not be recalled from the open-ils.collections.users_of_interest.warning_penalty.retrieve API. This change will check for the existance of the user in the money.colletions_tracker table.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 11 Oct 2012 05:43:01 +0000 (01:43 -0400)]
TPAC: Respect location visibility for result copies
Robert Soulliere noted in LP# 1062502 that copies in a location marked
"opac_visible = FALSE" were erroneously being displayed in search
results. This would occur if at least one copy on a record was in a
visible location, but other copies were in an invisible location.
This commit prevents copies in hidden locations from being displayed,
and also adds guards for the visibility of the copy status and the
circulation library.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Serials: Don't force a Receive Unit Template in Alt Serials Control
Mary Llewellyn reported that she used to be able to use serials and
perform copy-less receiving without any value in this field.
The requirement that a value be set in the Receive Unit Template field
of serial distributions was added (by me) in 2.1 to the alternate serials
control interface, but is not enforced at lower levels.
I now believe that requiring a value here must have been a ham-handed
way to avoid a difficult-to-troubleshoot issue in copy-FUL receiving,
but copy-LESS serials receiving workflows indeed don't need this, so
this commit removes the requirement.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 5 Sep 2012 18:39:36 +0000 (14:39 -0400)]
Use current fiscal year for PO creation (API)
When creating a PO, if no fiscal_year is specified by the caller, use
the current fiscal year of the ordering agency. This change primarily
affects the Open-ILS/src/support-scripts/acq_order_reader.pl script (and
any other direct API callers) which does not offer the user a chance to
set the fiscal year manually.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Thu, 20 Sep 2012 19:17:36 +0000 (15:17 -0400)]
Fix autosuggest when in no-vis-check mode
When autosuggest is configured to avoid visiblity checking, it sends a
special org unit id of -1 to the database as a signal. However, the stored
procedure is expecting a NULL instead. This allows either by transforming
-1 to NULL within the stored procedure.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
Michael Peters [Fri, 21 Sep 2012 15:47:41 +0000 (11:47 -0400)]
TPAC: Add a progress spinner after pressing search on Advanced Search
Advanced Search had no indication of progress once you've submitted
a search. We should add a "progressbar_green.gif" like the basic search
has, so the user knows their search is in progress, and (hopefully)
avoids them from hammering submit to get a result.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Wed, 3 Oct 2012 19:00:26 +0000 (15:00 -0400)]
ACQ invoice receive UI handles async LI retrieval
openils.acq.Linetitem.fetchAndRender() now fetches lineitems
asynchronously. This commit causes the invoice receive UI to calculate
the copies to be received after all lineitems have been (async) fetched.
Without this, it always appears as though there are no copies to receive
Dan Scott [Thu, 11 Oct 2012 02:06:32 +0000 (22:06 -0400)]
TPAC: Avoid 500 errs on record page due to ipv6 ignorance
Net::HTTP does not handle ipv6 addresses properly, and is subject to
failing to return a request object if handed one (some systems seem to
prefer ipv6). This commit checks the value of the request object before
invoking any methods on it, and also short-circuits the AC lookup loop
if the host could not be resolved to avoid flooding the logs with
multiple "Unable to connect..." warnings.
If Net::HTTP grows ipv6 support, this commit can still stay in place and
the lookups will just start magically working.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 10 Sep 2012 13:32:17 +0000 (09:32 -0400)]
TPAC: Remove noise, misleading text from myopac/holds/circs/circ_history
There are many "class='hide_me'" elements that will never be displayed
and which are currently just extra bits to ship over the wire. Same for
the inline comments.
Also move most of the inline styles out to the stylesheet.
Also remove the explicit widths on the table cells; if the font size
changes or the translated text is wider than the table cells, then the
display will become comical.
Also remove explicit <br> tags from localized strings; given the
likelihood that font sizes and column widths will change, <br> tags
inside localized strings make very little sense.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Mike Rylander [Mon, 8 Oct 2012 18:12:49 +0000 (14:12 -0400)]
Be more strict about dates we generate
ISO-8601 dates must have a 4-character year component, however strftime does
not left-pad years to 4 characters when the century is one character long even
though the man page for strftime(3) suggests otherwise:
%F Equivalent to %Y-%m-%d (the ISO 8601 date format). (C99)
This makes stricter ISO-8601 parsers, such as Perl's DateTime module, unhappy.
So, we'll do it ourselves using the glibc extensions available to strftime for
specifying a padding character and desired length.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 8 Oct 2012 19:08:47 +0000 (15:08 -0400)]
Checkout: further validation of due date override
The check_past() function failed if given a date that was not strictly
in YYYY-mm-dd format; interestingly, a common transposition typo such
as "0212-10-20" results in "212-10-20" getting passed to check_past(),
and therefore generating an invalid date. Throw an exception in
check_past() rather than returning true, because we are not in fact
stating that the due date is in the past - and catch the exception and
flag the due date override box accordingly in the checkout screen.
We could bubble the exception up to the user, but hopefully highlighting
the checkout box as being in an invalid state will catch the attention
of the users.
[LFW: Slightly amended a comment in OpenILS/WWW/EGCatLoader/Util.pm]
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 8 Oct 2012 15:25:41 +0000 (11:25 -0400)]
TPAC: Invalid due dates cause 500 server error
CStore appears to return dates with leading 0s (such as '0212-10-08
23:59:59-05:17:32') with the leading 0s stripped off, resulting in
cases with 1-digit or 3-digit years for which DateTime::Format::ISO8601
returns an error.
We can protect against this problem by adding some defensive code to the
TPAC utility method to add the 0s back to the start of the year. We can
also log the problem when it occurs so that administrators can fix the
problem dates in the database.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
LP1052941: Internal Server Error when adding to My List in staff client.
Don't redirect in EGCatLoader/Account.pm when in staff client context and
we're adding to a My List/Bookbag.
Add a wrapper macro to bookbag_actions.tt2 to wrap the add to book bag URLs
with some javascript that opens a new tab in the staff client. This is to
prevent the staff person from losing their search results as they would if
the new URL were opened in their current tab.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
projects / Evergreen.git / log