]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1707549: Remove Perl 5.24+ syntax restriction
authorMike Rylander <mrylander@gmail.com>
Tue, 1 Aug 2017 16:34:11 +0000 (12:34 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Tue, 1 Aug 2017 19:08:10 +0000 (15:08 -0400)
commitd4394198b7deb382857a9f4cc15db4cf43f68568
tree08ab903e02715ef27816f1f361d8048723810025
parent471e9cfcbb3e5518216729f47f0f9bb7721ece7b
LP#1707549: Remove Perl 5.24+ syntax restriction

Quoth the Perl docs: "An experimental feature added in Perl 5.14 allowed each,
keys, push, pop, shift, splice, unshift, and values to be called with a scalar
argument. This experiment is considered unsuccessful, and has been removed.
The postderef feature may meet your needs better."

The specific instance here was probably just a typo or thinko the did the
right thing on Perls "of a certain age" ... so, we fix that here, now.

To test:

[1] Upon applying the patch, verify that Perl 5.24+ will successfully
    compile metabib.pm, that the open-ils.storage service will
    start up, and that catalog searches continue to work.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm