]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1747963 Fix "trim list" feature in web client
authorRemington Steed <rjs7@calvin.edu>
Wed, 7 Feb 2018 19:41:47 +0000 (14:41 -0500)
committerBill Erickson <berickxx@gmail.com>
Wed, 21 Mar 2018 15:03:25 +0000 (11:03 -0400)
commit95600c41a94dedea632cecc9d3354b170c09a947
tree03648e269320fd27f6e6dfc8abaa9c5f4e621ab9
parent59e796a9ecb056b9f829a37f7d05dcef26cc3d24
LP#1747963 Fix "trim list" feature in web client

The use of splice() here caused buggy behavior and seemed to be a typo,
so I tried using slice() instead. But that still didn't work correctly.
The list stopped adding items after it reached 21 total, so scanning a
new barcode didn't add it to the list but only refreshed the list.

Instead, this commit sets the length of the array to 20, which shortens
the array as described in the MDN documentation for Array.length. Now it
behaves like it did in the XUL client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/web/js/ui/default/staff/circ/checkin/app.js