]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1686194 Account for adjustments when generating fines
authorDan Wells <dbw2@calvin.edu>
Mon, 24 Apr 2017 18:29:04 +0000 (14:29 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Tue, 20 Jun 2017 14:05:01 +0000 (10:05 -0400)
commit7293106cb51986fafe5f1d0636c628121052ed55
tree62dc522b84d2319da910fa421f5c63f7867330e0
parent2ffefc8be99b37329f6f7d0daa9c8f0e55079c73
LP#1686194 Account for adjustments when generating fines

Fine generation stops at a predetermined 'max fines' amount, but this
does not account for possible adjustments which lower the effective
fine amount.  This situation is common in cases where lost items are
returned, and the library wants to generate additional overdues upon
that event.

With this commit, fine generation will pull in any adjustments applied
to overdue fines, and use those to offset the current total fine when
checking for max fines.

Also includes test for this condition.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/perlmods/live_t/09-lp1198465_neg_balances.t
Open-ILS/tests/datasets/sql/neg_bal_custom_transactions.sql