]> git.evergreen-ils.org Git - Evergreen.git/commit
Acq: re-use more code for two ways of creating invoices (EDI and manual)
authorLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Wed, 20 Feb 2013 14:41:03 +0000 (09:41 -0500)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 18 Apr 2013 19:33:05 +0000 (15:33 -0400)
commit66e9aa3948a392b6fdc0cb33cf977a38514e16df
treeb499a60bfe8d764a60e7a7d118eed4aaaee4cd37
parent44684888b39212679bc98cd5472d87195806a150
Acq: re-use more code for two ways of creating invoices (EDI and manual)

This solves two problems.

 1) With EDI invoices, we had been failing to disencumber fund debits
    related to the invoiced lineitems, although that worked for manual
    invoices.
 2) With manual invoices, we would not automatically uncancel copies
    when the user decided to invoice them despite their canceled status.
    This was already working in EDI invoices though.  This is especially
    important since our schema lumps "backordered" in with "canceled,"
    and in theory backordered things do show up eventually.

There were earlier version of this commit out there with bugs that
prevented the EDI workflow from working correctly (the manual invoice
flow worked and still should).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Invoice.pm