]> git.evergreen-ils.org Git - Evergreen.git/commit
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
authorJason Stephenson <jstephenson@mvlc.org>
Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)
committerBen Shum <bshum@biblio.org>
Thu, 17 Sep 2015 19:41:55 +0000 (15:41 -0400)
commit4cf6cc76bd063f88027fb18f7687c613a4d4813f
tree09c35c7b568be0711b36c7ae23432df08d767fbd
parent4eab98f15fb6f70c06b4f360d9dfa08cc19fb7f4
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon

It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon.  This duplication can lead to data loss for the function
update_fleshed_copies.  It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:

"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.

After this patch, the warning disappears.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm