]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1642344: XUL report cloning
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 29 Jun 2018 18:45:27 +0000 (14:45 -0400)
committerMike Rylander <mrylander@gmail.com>
Fri, 14 Sep 2018 16:42:15 +0000 (12:42 -0400)
commit4939e9dc6c8a280a23106e3aac81d54e4f485171
tree7fbbd7c86b008749c032ceda614d2721f7dfe352
parentb8605e04530bdd927323575d6e7ae84869efcb1c
LP#1642344: XUL report cloning

This patch allows report templates of version 4 and earlier
(which would have been created by the XUL staff client) to
be upgraded to template version 5 (used by the web staff
client) when the user clones a report. This closes a limitation
introduced in the reporter module for the web staff client.

Note that during the conversion, inner joins are used by
default when IDL classes have a 'has_a' relation rather than
defaulting to left outer joins, improving correctness of the
generated SQL query.

To test
-------
[0] Apply the patch.
[1] In a test database that has reporter templates created
    by (or for) the XUL staff client, create clones of
    those templates.
[2] Verify that the output of reports created using the new
    templates matches output of reports from the original
    templates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/web/js/ui/default/staff/reporter/template/app.js
Open-ILS/web/js/ui/default/staff/test/unit/egReporter.js
Open-ILS/web/reports/oils_rpt_folder_window.js