]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1526543 Truthiness check for reset_password is flawed
authorDan Wells <dbw2@calvin.edu>
Thu, 13 Feb 2014 16:56:19 +0000 (11:56 -0500)
committerBen Shum <bshum@biblio.org>
Tue, 5 Jan 2016 21:02:43 +0000 (16:02 -0500)
commit448bf4bb5ca8a804c7e95432fa4f84e7a158eb53
treea6b58c67659a7a34463f06a5f24111b5e25c3a38
parent31aab46a8ccb76f0422516f6724cfb8e35e04b61
LP#1526543 Truthiness check for reset_password is flawed

We expect boolean options in config.tt2 to be 'true' or 'false',
but the code was simple asking 'IF reset_password', which is true
for either value.

Instead, match on the string (as we do in other places).

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link staying no matter which way
  'reset_password' is set in config.tt2
- Apply patch, and change 'reset_password' value in config.tt2 to 'false'
- RESULT: Password reset link doesn't show up

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/templates/opac/parts/login/form.tt2