]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#842991 Reports needs to error when deleting fails
authorRemington Steed <rjs7@calvin.edu>
Wed, 27 Nov 2013 14:55:35 +0000 (09:55 -0500)
committerDan Wells <dbw2@calvin.edu>
Tue, 21 Jan 2014 22:23:32 +0000 (17:23 -0500)
commit1a37aefeb0fc58ddc8ec4e4835bd4871c4c5bd7e
treec6b6cbedb6ec9ff02fbb3ec93e8761c42d5da7e3
parentbdd7b7745e857372a6d0178bd76a5f19412501fe
LP#842991 Reports needs to error when deleting fails

When attempting to delete a report template, the reports interface
incorrectly shows "Action Succeeded" even when it partly fails. If the
user performing the delete does not own all the dependent reports and
outputs, then the perl function returns 1 to indicate that some were
deleted, but not all. However, the javascript that calls that function
does not check for a return value of 1. This commit adds that check, and
also improves the formatting of the related error messages.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/web/opac/locale/en-US/reports.dtd
Open-ILS/web/reports/oils_rpt_folder_window.js